Please merge laptop-mode-tools 1.55 (universe) from debian (unstable)

[David Sugar]

Binary package hint: laptop-mode-tools

There are many upstream fixes that seemed worthwhile to get since the last merge.

[Stefano Rivera (stefanor)]

Hi, you let an auto-generated quilt patch slip through again, please format it correctly.

I don't think we need that preinst file. Everyone install this will have upgraded through lucid.

[David Sugar (dyfet-deactivatedaccount)]

I will revise and try to get a new patch out later today.

[David Sugar (dyfet-deactivatedaccount)]

debdiff laptop-mode-tools_1.55-1.dsc laptop-mode-tools_1.55-1ubuntu1.dsc

Among other things, I removed the preinst script.

[David Sugar (dyfet-deactivatedaccount)]

debdiff laptop-mode-tools_1.52-1ubuntu2.dsc laptop-mode-tools_1.55-1ubuntu1.dsc

[Benjamin Drung (bdrung)]

You forgot to add ubuntu-sponsors

[Stefano Rivera (stefanor)]

Err that was probablay me unsubscribing them

Instead of removing "debian/patches/debian-changes-1.55-1" how about just commenting it out in debian/patches/series?

[David Sugar (dyfet-deactivatedaccount)]

new debdiff's posted

[Stefano Rivera (stefanor)]

This is a little tricky to review because the changelog is incomplete. We prefer a changelog entry that clearly describes the merge i.e. all remaining changes.

Some other issues I can see:
* The maintainer needs to be updated. update-maintainer knows what to do.
* It looks like debian renamed sleep.d/99laptop-mode to 01laptop-mode yet we recreate 99

Sorry, but a full review is going to need a better changelog

[Benjamin Drung (bdrung)]

Please resubscribe ubuntu-sponsors once you have addressed the issues mentioned in the previous comment.

[David Sugar (dyfet-deactivatedaccount)]

This should be targeted for Natty

[David Sugar (dyfet-deactivatedaccount)]

It will happen then when we resync....should I keep this open to verify the merge for Natty or mark this as invalid?

[Stefano Rivera (stefanor)]

> It will happen then when we resync

We have ubuntu modifications in laptop-mode-tools, so it won't automatically be synced. If you can please address my previous comments, target the upload at natty, and resubscribe sponsors, it can be uploaded.

[Launchpad Janitor (janitor)]

[Expired for laptop-mode-tools (Ubuntu) because there has been no activity for 60 days.]