Ubuntu

merge laptop-mode-tools 1.52-1 from Debian unstable main

Reported by Ritesh Raj Sarraf on 2009-09-01
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
laptop-mode-tools (Ubuntu)
Medium
Steve Langasek

Bug Description

Binary package hint: laptop-mode-tools

Please merge laptop-mode-tools from Upstream/Debian.

Tormod Volden (tormodvolden) wrote :

For this to happen in Karmic, please follow the Feature Freeze Exception (FFe) process, https://wiki.ubuntu.com/FreezeExceptionProcess

Ritesh Raj Sarraf (rrs) wrote :

The version of laptop-mode-tools in Ubuntu is quite outdated. Is there any particular reason behind it ?
This bug report is a request to sync laptop-mode-tools to the latest one from Debian.

The current version in Ubuntu (1.47) is missing many power saving features that were added into the new releases. It also is missing many bug fixes that were introduced with newer kernels.

The upstream version of laptop-mode-tools can be tracked here.
http://launchpad.net/laptop-mode-tools

Changed in laptop-mode-tools (Ubuntu):
assignee: nobody → Ubuntu Release Team (ubuntu-release)
Martin Pitt (pitti) wrote :

Right, if someone is interested in merging laptop-mode-tools. The last merge was done by a community member who apparently missed to do it in Karmic, so I assign it to the foundations team for now.

I didn't review the changelog, if the changes are too intrusive for feature freeze, this will have to wait for karmic+1.

Changed in laptop-mode-tools (Ubuntu):
assignee: Ubuntu Release Team (ubuntu-release) → Canonical Foundations Team (canonical-foundations)
status: New → Triaged
Tormod Volden (tormodvolden) wrote :

I would suggest someone takes a look at https://merges.ubuntu.com/l/laptop-mode-tools/REPORT and merges the latest Debian version at least. Also, for a FFe, it would be good to identify bugs that will be fixed by the new version.

Changed in laptop-mode-tools (Ubuntu):
importance: Undecided → Low
importance: Low → Medium
summary: - sync laptop-mode-tools to the latest release from upstream
+ merge laptop-mode-tools with the latest release from Debian

I really hope to see that in Karmic, my laptop is really lacking power-saving features ! (Max 1hour with ubuntu (without laptop-mode), 2 hours with windows 7 :-/)

Ritesh Raj Sarraf (rrs) wrote :

Reminder for Lucid. Development is open.

Whoopie (whoopie79) wrote :

Please find attached a debdiff for laptop-mode-tools_1.52-1ubuntu1.

Tormod Volden (tormodvolden) wrote :

Whoopie, the debdiff looks good, but the changelog has not been merged with the Debian version. Also using your full name in the changelog is preferred.

summary: - merge laptop-mode-tools with the latest release from Debian
+ merge laptop-mode-tools 1.52-1 from Debian unstable main
Tormod Volden (tormodvolden) wrote :

Whoopie, forget about my changelog merge comment. I keep looking at the wrong files :)

Tormod Volden (tormodvolden) wrote :

The distro pocket should be "lucid" and not "karmic-proposed".

Whoopie (whoopie79) wrote :

I hoped to see it in karmic-proposed. That's why I used "karmic-proposed" as distro pocket.

If the only outstanding issue is my real name, then please use the debdiff with your own name. I don't need any credit or so, it's just important for me to have a newer version in Ubuntu. Thanks for your understanding!

Steve Langasek (vorlon) wrote :

There is no way this would be a candidate for karmic-proposed. It will only be included in lucid.

Tormod Volden (tormodvolden) wrote :

Can somebody upload this to lucid please?

Steve Langasek (vorlon) wrote :

The update-manager change to force removal of laptop-mode-tools on upgrade to lucid should be uploaded before this merge. I'll review the merge in the meantime.

Steve Langasek (vorlon) wrote :

Feedback on the proposed merge:

- the Debian package adds handling in the postinst for restarting the various power management daemons that it hooks into, but the merge drops these postinst changes. Why? Either the functionality of the two postinst scripts should be merged, or the reason for dropping the Debian changes should be documented in the changelog.
- the Debian package adds handling for /usr/lib/pm-utils/power.d in a slightly different place within debian/rules than the Ubuntu package had it; since the behavior is identical, we should use the Debian code to reduce our delta.
- the usr/lib/pm-utils/sleep.d/99laptop-mode in the package includes undocumented changes wrt the Debian version - we shouldn't diverge from Debian on such minor things as setting a LAPTOP_MODE variable vs. repeating the path. We do need to remain consistent in our handling of $ENABLE_LAPTOP_MODE, however; and this should be documented in the changelog.

I'm making the changes described above, and will commit them to bzr for inclusion in the upload.

Changed in laptop-mode-tools (Ubuntu):
status: Triaged → In Progress
Steve Langasek (vorlon) on 2009-12-01
Changed in laptop-mode-tools (Ubuntu):
assignee: Canonical Foundations Team (canonical-foundations) → Steve Langasek (vorlon)
Launchpad Janitor (janitor) wrote :
Download full text (6.9 KiB)

This bug was fixed in the package laptop-mode-tools - 1.52-1ubuntu1

---------------
laptop-mode-tools (1.52-1ubuntu1) lucid; urgency=low

  [ Whoopie ]
  * Merge with Debian (LP: #422620; LP: #469517, #308065, #307947),
    remaining changes:
    + Drop sdparm Recommends to Suggests: It is in universe.
    + etc/laptop-mode/laptop-mode.conf: change default spindown time and
      power management modes.
    + Add/Modify pm-utils hooks to ensure laptop-mode is running as
      expected after power change or thaw/resume
      - power.d/laptop-mode: runs laptop-mode on power change
      - sleep.d/99laptop-mode: don't run laptop-mode if disabled in
        /etc/default/laptop-mode
    + etc/init.d/laptop-mode: Check if laptop mode is disabled in
      /etc/default/laptop-mode (that's the file laptop_mode looks into, too,
      but it incorrectly evaluates the ENABLE_LAPTOP_MODE setting) as well
      as in /etc/default/acpi-support.
    + usr/sbin/laptop_mode: Do not parse arguments, ignore "force" and
      let start/stop mean enable/disable.
    + /usr/sbin/laptop_mode: Do not read $ACTIVATE_WITH_POSSIBLE_DATA_LOSS
      from /var/run/laptop-mode-state to see if state has changed.
    + debian/rules: Do not ship acpi/apm scripts (we handle that ourselves)
    + debian/laptop-mode-tools.preinst: Remove any old acpi/apm scripts
    + debian/laptop-mode-tools.postinst: Create /etc/default/laptop-mode
      (with ENABLE_LAPTOP_MODE=false) if the file does not exist yet and we
      are on ppc.
    + Also accept "stop" as second argument since the init script
      calls laptop_mode with "init stop"

  [ Steve Langasek ]
  * Dropped changes, merged in Debian: sleep.d/96laptop-mode: superseded by
    sleep.d/99laptop-mode

laptop-mode-tools (1.52-1) unstable; urgency=low

  * New Upstream Release
    + Initialize DEBUG to 0 by default. THanks to Matthijs Kooijman for
      pointing it out. (Closes: #546371)
    + Add an option to completely disable ethernet devices when on battery.
    + Introduce hooks to enable debug mode for individual modules
    + Use iwconfig to determine device type for iwlwifi devices also
    + Collect the correct exit code for iwconfig execution.
    + Use iwconfig in wireless-iwl-power. Thanks to Darren Hoo for spotting it
    + Handle spaces in mount point names. Thanks to Louis Simard for the patch
    + Clarify about Global Debug mode and Module Specific Debug mode.
    + Fix incorrect variable reference in video-out module. Thanks to Hans
      Werner for noticing that.
  * laptop-mode-tools.preinst: remove (and backup) the obsolete
    /etc/pm/sleep.d/99laptop-mode config file. Thanks to Tormod
    Volden for the fix. (LP: #384875)

laptop-mode-tools (1.51-1) unstable; urgency=low

  * New Upstream Release
    + Add option to blacklist usb devices by their device id.
      Thanks to <email address hidden> for the patch
    + Trigger timer change for power mgmt by doing a device open/close
      The open/close operation can fail if the audio device is busy.
      Since this failure is non-fatal (worst case is that the timer changes
      don't get activated), we don't bother if it was successful or not.
    + Add support fo...

Read more...

Changed in laptop-mode-tools (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers