Comment 6 for bug 250935

Revision history for this message
Alexey Borzenkov (snaury) wrote :

1. Well, if it's true it should be very easy to change: just s[etc/pm/][usr/lib/pm-utils/] in the debdiff.
2. Unfortunately, I have no clue if Debian currently uses acpi-support/pm-utils or anything else. At the very least they don't have hacks in /etc/acpi/power.sh like Ubuntu has, so they must be doing something differently.
3. At first I was thinking about changing pm-utils, but then I realized that pm-utils shouldn't control laptop-mode-tools either. So I decided that the correct place for hooks is laptop-mode-tools itself.
4. As far as I reviewed laptop_mode script it should. It should actually do it without arguments as well, but I thought it is better to pass auto anyway. It's just important not to pass start/stop, comment "Old options. We always do "auto" for any option now" is misleading: check for start/stop is done after auto-detection.

Additionally, compared to Debian, Ubuntu's laptop_mode has state check commented out, which means we don't have problems like "previous state is incorrect after hibernate/thaw and settings are not reapplied". Just calling laptop_mode auto at the right moments seems to be sufficient in Ubuntu (as long as /etc/init.d/laptop-mode is in runlevels).