Comment 0 for bug 2106263

Revision history for this message
Mitch Burton (mitchburton) wrote :

[ Impact ]

landscape-client fails to build on plucky because of the removal of
the deprecated unittest.makeSuite API from CPython.

Build log showing errors: https://launchpadlibrarian.net/783617119/buildlog_ubuntu-plucky-amd64.landscape-client_24.12-0ubuntu1_BUILDING.txt.gz

This can be corrected by replacing calls to makeSuite with the
recommended unittest.defaultTestLoader.loadTestsFromTestCase.

Additionally, override_dh_auto_install is failing on the
install -D -o root -g root
lines because of errors changing ownership during build.

Because root:root ownership during build is not required for these
executables to function, the ownership change can be dropped from
these install lines.

[ Test Plan ]

Test a build on a plucky machine. I did this using LXD and debuild.
Also, test a build on Launchpad by uploading to a PPA. Ensure build
succeeds and the landscape-client and landscape-common packages are
installable.

Check the ownership and permissions of
/usr/share/landscape/landscape-sysinfo.wrapper
It should be root:root and 0755

Check the ownership and permissions of
/usr/lib/landscape/apt-update
It should be root:landscape and 4754

Make sure that the MOTD appears normally, including landscape-sysinfo
information.

Make sure that landscape-client can register to a landscape-server
deployment and report package state.

[ Where problems could occur ]

landscape-sysinfo.wrapper could have broken permissions, which would
impact update-motd, either by introducing errors or by failing to show
the sysinfo.

landscape's apt-update could have broken permissions, which could prevent
landscape-client from reporting packages.

[ Other Info ]

The current MP targeted at this bug also includes the fix for
LP: #2087852