failing to build on plucky

[Mitch Burton]

[ Impact ]

landscape-client fails to build on plucky because of the removal of
the deprecated unittest.makeSuite API from CPython.

Build log showing errors: https://launchpadlibrarian.net/783617119/buildlog_ubuntu-plucky-amd64.landscape-client_24.12-0ubuntu1_BUILDING.txt.gz

This can be corrected by replacing calls to makeSuite with the
recommended unittest.defaultTestLoader.loadTestsFromTestCase.

Additionally, override_dh_auto_install is failing on the
install -D -o root -g root
lines because of errors changing ownership during build.

Because root:root ownership during build is not required for these
executables to function, the ownership change can be dropped from
these install lines.

autopkgtests are also failing: https://autopkgtest.ubuntu.com/results/autopkgtest-plucky-mitchburton-landscape-client-ppa/plucky/amd64/l/landscape-client/20250404_202328_93494@/log.gz

This appears to be because the landscape user does not exist - this can likely
be resolved by using the same environment variables, LANDSCAPE_CLIENT_USER and
LANDSCAPE_CLIENT_BUILDING, that are using in debian/rules for the build tests.

Beyond the above, some tests are failing during autopkgtest because of http_
and https_proxy environment variables: https://autopkgtest.ubuntu.com/results/autopkgtest-plucky-mitchburton-landscape-client-ppa/plucky/amd64/l/landscape-client/20250407_093831_f2105@/log.gz

[ Test Plan ]

Test a build on a plucky machine. I did this using LXD and debuild.
Also, test a build on Launchpad by uploading to a PPA. Ensure build
succeeds and the landscape-client and landscape-common packages are
installable.

Check the ownership and permissions of
/usr/share/landscape/landscape-sysinfo.wrapper
It should be root:root and 0755

Check the ownership and permissions of
/usr/lib/landscape/apt-update
It should be root:landscape and 4754

Make sure that the MOTD appears normally, including landscape-sysinfo
information.

Make sure that landscape-client can register to a landscape-server
deployment and report package state.

[ Where problems could occur ]

landscape-sysinfo.wrapper could have broken permissions, which would
impact update-motd, either by introducing errors or by failing to show
the sysinfo.

landscape's apt-update could have broken permissions, which could prevent
landscape-client from reporting packages.

[ Other Info ]

The current MP targeted at this bug also includes the fix for
LP: #2087852

[Launchpad Janitor (janitor)]

This bug was fixed in the package landscape-client - 24.12-0ubuntu2

---------------
landscape-client (24.12-0ubuntu2) plucky; urgency=medium

  [ Bryan Fraschetti ]
  * d/p/2087852-feat-manage-ubuntu-sources-glob.patch: include DEB822 formatted sources
    when managing apt sources by regex matching .sources files (LP: #2087852)

  [ Mitch Burton ]
  * Fix FTBFS (LP: #2106263)
    - d/p/unittest-makeSuite-deprecation.patch: fix tests on python versions
      where unittest.makeSuite has been removed
    - d/rules: don't make root:root owner of installed executables
    - d/tests/control: set environment variables for autopkgtest user and
      build environment
    - d/p/allow-http-proxy-in-tests.patch: fix tests by making them
      insensitive to http/https proxy environment variables

 -- Mitch Burton <email address hidden> Wed, 26 Mar 2025 17:47:28 -0700