Activity log for bug #2066983

Date Who What changed Old value New value Message
2024-05-23 20:34:51 Markus bug added bug
2024-05-23 20:43:47 Spencer Runde landscape-client (Ubuntu): status New In Progress
2024-05-23 20:43:50 Spencer Runde landscape-client (Ubuntu): assignee Spencer Runde (spencerrunde)
2024-05-28 19:24:27 Launchpad Janitor merge proposal linked https://code.launchpad.net/~spencerrunde/ubuntu/+source/landscape-client/+git/landscape-client/+merge/466518
2024-05-28 19:48:08 Spencer Runde description There is a bug in the /etc/update-motd.d/50-landscape-sysinfo (Symlink to /usr/share/landscape/landscape-sysinfo.wrapper) script in Ubuntu. The script incorrectly sets the load threshold due to a typo, causing the system information to be disabled unnecessarily when the system load is actually within acceptable limits. Steps to Reproduce: 1. Open the /etc/update-motd.d/50-landscape-sysinfo script. 2. Notice the line where THRESHOLD is set: THRESHOLD="${cores:-1}.0". 3. The correct variable should be CORES instead of cores. Expected Behavior: The threshold should be calculated based on the number of CPU cores, e.g., THRESHOLD="${CORES:-1}.0", and system information should be displayed correctly when the load is below this threshold. Actual Behavior: The threshold is incorrectly set to 1.0 due to the typo, causing system information to be disabled unnecessarily. Version Information: Ubuntu 24.04 LTS: landscape-common 24.02-0ubuntu5 Ubuntu 22.04.4 LTS: landscape-common 23.02-0ubuntu1~22.04.2 [ Impact ] * The CPU load is incorrectly calculated, and users won't get system info in the message-of-the-day (motd). * The `cores` variable was misnamed; it should be `CORES` since bash variables are case-sensitive [ Test Plan ] Steps to Reproduce: 1. Open the /etc/update-motd.d/50-landscape-sysinfo script. 2. Notice the line where THRESHOLD is set: THRESHOLD="${cores:-1}.0". 3. The correct variable should be CORES instead of cores. To trigger MOTD and view incorrect calculation: sudo run-parts /etc/update-motd.d/ Notice message: " System information disabled due to load higher than 1.0" even on systems with multiple cores. [ Where problems could occur ] * This fix will necessarily run the system process info on more systems during MOTD. If the CPU load threshold was poorly chosen, then overly-loaded systems might be slow during MOTD while landscape-sysinfo runs
2024-05-28 20:12:26 Launchpad Janitor merge proposal linked https://code.launchpad.net/~spencerrunde/ubuntu/+source/landscape-client/+git/landscape-client/+merge/466523
2024-05-28 20:25:18 Spencer Runde description [ Impact ] * The CPU load is incorrectly calculated, and users won't get system info in the message-of-the-day (motd). * The `cores` variable was misnamed; it should be `CORES` since bash variables are case-sensitive [ Test Plan ] Steps to Reproduce: 1. Open the /etc/update-motd.d/50-landscape-sysinfo script. 2. Notice the line where THRESHOLD is set: THRESHOLD="${cores:-1}.0". 3. The correct variable should be CORES instead of cores. To trigger MOTD and view incorrect calculation: sudo run-parts /etc/update-motd.d/ Notice message: " System information disabled due to load higher than 1.0" even on systems with multiple cores. [ Where problems could occur ] * This fix will necessarily run the system process info on more systems during MOTD. If the CPU load threshold was poorly chosen, then overly-loaded systems might be slow during MOTD while landscape-sysinfo runs [ Impact ]  * The CPU load is incorrectly calculated, and users won't get system info in the message-of-the-day (motd).  * The `cores` variable was misnamed; it should be `CORES` since bash variables are case-sensitive * Affects landscape-client on noble, mantic, jammy, and focal. [ Test Plan ] Steps to Reproduce:     1. Open the /etc/update-motd.d/50-landscape-sysinfo script.     2. Notice the line where THRESHOLD is set: THRESHOLD="${cores:-1}.0".     3. The correct variable should be CORES instead of cores. To trigger MOTD and view incorrect calculation: sudo run-parts /etc/update-motd.d/ Notice message: " System information disabled due to load higher than 1.0" even on systems with multiple cores. [ Where problems could occur ]  * This fix will necessarily run the system process info on more systems during MOTD. If the CPU load threshold was poorly chosen, then overly-loaded systems might be slow during MOTD while landscape-sysinfo runs
2024-05-28 20:26:25 Mitch Burton bug added subscriber Mitch Burton
2024-05-28 21:47:34 Launchpad Janitor merge proposal linked https://code.launchpad.net/~spencerrunde/ubuntu/+source/landscape-client/+git/landscape-client/+merge/466526
2024-05-28 21:51:49 Launchpad Janitor merge proposal linked https://code.launchpad.net/~spencerrunde/ubuntu/+source/landscape-client/+git/landscape-client/+merge/466527
2024-05-28 21:55:09 Launchpad Janitor merge proposal linked https://code.launchpad.net/~spencerrunde/ubuntu/+source/landscape-client/+git/landscape-client/+merge/466528
2024-05-28 22:19:36 Spencer Runde bug added subscriber Ubuntu Sponsors
2024-07-02 21:23:41 Dan Bungert landscape-client (Ubuntu): status In Progress Fix Committed
2024-07-02 21:23:45 Dan Bungert landscape-client (Ubuntu): assignee Spencer Runde (spencerrunde)
2024-07-02 21:25:04 Dan Bungert removed subscriber Ubuntu Sponsors
2024-07-03 04:57:07 Launchpad Janitor landscape-client (Ubuntu): status Fix Committed Fix Released
2024-07-05 13:53:12 Timo Aaltonen landscape-client (Ubuntu Noble): status New Fix Committed
2024-07-05 13:53:13 Timo Aaltonen bug added subscriber Ubuntu Stable Release Updates Team
2024-07-05 13:53:17 Timo Aaltonen bug added subscriber SRU Verification
2024-07-05 13:53:20 Timo Aaltonen tags verification-needed verification-needed-noble