/etc/update-motd.d/50-landscape-sysinfo shows error in WSL

Bug #1855522 reported by Balint Reczey
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
landscape-client (Ubuntu)
Undecided
Unassigned
Eoan
Undecided
Unassigned

Bug Description

[ Impact ]

 * MOTD on WSL (1) includes the following error:
   => There were exceptions while processing one or more plugins. See
      /home/ubuntu/.landscape/sysinfo.log for more information.
 * It is not desired to show an error when Ubuntu makes the first impression.

[ Test ]

 * Run update-motd on WSL 1.
 * Observe no errors shown

[ Regression potential ]

 * The fix is very simple, it handles EINVAL the same way as EOPNOTSUPP. If the new code does not crash, it should be ok.

Revision history for this message
Balint Reczey (rbalint) wrote :
Revision history for this message
Balint Reczey (rbalint) wrote :
tags: added: patch patch-forwarded-upstream
Revision history for this message
Balint Reczey (rbalint) wrote :
Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

Reproducible with Ubuntu 18.04.2 on Windows 10 Pro 1903:

2019-12-08 20:21:00,383 ERROR Network plugin raised an exception.
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/landscape/sysinfo/sysinfo.py", line 99, in run
    result = plugin.run()
  File "/usr/lib/python3/dist-packages/landscape/sysinfo/network.py", line 32, in run
    for info in self._get_device_info():
  File "/usr/lib/python3/dist-packages/landscape/lib/network.py", line 181, in get_active_device_info
    speed, duplex = get_network_interface_speed(sock, interface)
  File "/usr/lib/python3/dist-packages/landscape/lib/network.py", line 261, in get_network_interface_speed
    raise e
  File "/usr/lib/python3/dist-packages/landscape/lib/network.py", line 253, in get_network_interface_speed
    fcntl.ioctl(sock, SIOCETHTOOL, packed) # Status ioctl() call
OSError: [Errno 22] Invalid argument

Changed in landscape-client (Ubuntu):
status: New → Triaged
Balint Reczey (rbalint)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package landscape-client - 19.12-0ubuntu2

---------------
landscape-client (19.12-0ubuntu2) focal; urgency=medium

  * Handle EINVAL error of SIOCETHTOOL ioctl (LP: #1855522)
    The error occurs on WSL (1) and causes an error showing up in MOTD.

 -- Balint Reczey <email address hidden> Sat, 07 Dec 2019 15:52:03 +0100

Changed in landscape-client (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Balint, or anyone else affected,

Accepted landscape-client into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/landscape-client/18.01-0ubuntu9.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in landscape-client (Ubuntu Eoan):
status: New → Fix Committed
tags: added: verification-needed verification-needed-eoan
Revision history for this message
Balint Reczey (rbalint) wrote :

Verified on 18.01-0ubuntu9.1

tags: added: verification-done verification-done-eoan
removed: verification-needed verification-needed-eoan
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package landscape-client - 18.01-0ubuntu9.1

---------------
landscape-client (18.01-0ubuntu9.1) eoan; urgency=medium

  * Handle EINVAL error of SIOCETHTOOL ioctl (LP: #1855522)
    The error occurs on WSL (1) and causes an error showing up in MOTD.

 -- Balint Reczey <email address hidden> Sat, 07 Dec 2019 10:32:06 +0100

Changed in landscape-client (Ubuntu Eoan):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for landscape-client has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers