[FFE] reseed landscape in 18.04

Bug #1756261 reported by Christian Ehrhardt  on 2018-03-16
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
landscape-client (Ubuntu)
Undecided
Unassigned

Bug Description

After Wily landscape was taken out of the default installs for dragging in too much of python2 dependencies.

But recently landscape is now on python3 and back then the plan was to bring it back in when that happens.

It was discussed by the product stakeholders and decided to do so.

I wanted to document some details in the bug to refer to them from the seed entry.

In the past (pre Xenial) there were more components than today:
* landscape-client - was in the cloud-image (and pulled in landscape-common by dependencies)
* landscape-common - was in the default server install
* landscape-client - was on the Server ISO to install along landscape-common off the disk
* landscape-client-ui-install - was on the Desktop

These days there only are (both in main already)
* landscape-client
* landscape-common

We do not want to touch the Desktop case, but now that it is py3 it should be back on the server.
I discussed the details and we want:
* landscape-common - installed in cloud-image and default server install
* landscape-client - available from the ISO

But while py3 means it will not pull in "all of py2" it still hase py3 dependencies that would not be needed without any dependencies. It will drag in some python packages still.
The following analysis was done with landscape-common 18.01-0ubuntu2 as it is in bionic today and a fresh clean cloud-image as well as lxd container.
In both it will additionally bring in:
The following NEW packages will be installed:
  bc
  landscape-common
  python3-attr
  python3-automat
  python3-click
  python3-colorama
  python3-constantly
  python3-hyperlink
  python3-incremental
  python3-openssl
  python3-pam
  python3-pyasn1
  python3-pyasn1-modules
  python3-service-identity
  python3-twisted
  python3-twisted-bin
  python3-zope.interface

That will be 15.6 MB of additional disk space (after install).
This will be ~the amount the cloud image qcow grows, but will be less in the compressed form of the lxd image.

I can prep the seed changes, but need two acks to be sure:
1. a confirm that this really is exactly the change we want
2. that the extra dependencies that will be installed were considered when the decision to bring it back was made

@Andreas - thanks for the mail clarification on landscape package history.

The needed seed change will be:
- server - add landscape common
- (cloud-image implicitly pulls in the ubuntu-server meta package)
- (landscape-client is already in server-ship so both are on the ISO)

So the change itself is minimal and consists of:
=== modified file 'server'
--- server 2018-03-07 17:32:29 +0000
+++ server 2018-03-16 07:00:35 +0000
@@ -64,3 +64,4 @@
  * s390-tools [s390x] # needed for z block devices, bootloader, encryption features, etc.
  * gnupg
  * dirmngr
+ * landscape-common # LP: #1756261

And a follow on update on ubuntu-meta to update the "ubuntu-server" package.

Waiting for the ack on the questions I outlined (at the end of the description) to go on - David/Steve you were part of these discussions - can you confirm?

Andreas Hasenack (ahasenack) wrote :

Note that some of the packages you got in your test were due to recommends. Are recommends taken into consideration when building the image?

--- no-recommends.txt 2018-03-16 13:31:56.159543451 +0000
+++ with-recommends.txt 2018-03-16 13:32:19.197819032 +0000
@@ -2,10 +2,13 @@
 landscape-common
 python3-attr
 python3-automat
+python3-click
+python3-colorama
 python3-constantly
 python3-hyperlink
 python3-incremental
 python3-openssl
+python3-pam
 python3-pyasn1
 python3-pyasn1-modules
 python3-service-identity

Allowing for recommends adds python3-click, python3-colorama and python3-pam.

landscape-common itself has no recommends, these come through dependent packages.

Not sure on the recommends/depends question for image builds, but it is not too important for the questions that are open - those make up just a few MB of all of that.

David Britton (davidpbritton) wrote :

+1 on landscape-common in server-seed, pulling into the cloud images
+1 on landscape-client in server-ship

Thanks for the confirmation David.
Since the latter is already (still) done - it is on the iso, only changing the former.

Pushed the MP for review.

Hi,
I'm not entirely sure, but since resolving this delayed enough after the FF I'm unsure if this needs a Feature Freeze ack.

It is not adding/removing anything from a package. But it does to the default images.
And none of the categories in [1] applies to this - which is why I feel unsure.
So, better be correct and ask for an FFE ack.

[1]: https://wiki.ubuntu.com/FreezeExceptionProcess#FeatureFreeze_Exceptions

summary: - reseed landscape in 18.04
+ [FFE] reseed landscape in 18.04
Steve Langasek (vorlon) wrote :

Thanks, I agree that such a large change to the install footprint / package set warrants going through the FFe process.

Given that the size impact has already been reviewed and signed off by the Server Team, I'm +1 for this.

Changed in landscape-client (Ubuntu):
status: New → Triaged

ubuntu-meta 1.414 was relased just now, so this is done.
We should keep an eye on image builds the next few days if things are as they should be.

Changed in landscape-client (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers