PackageReporter kicks in during do-release-upgrade
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Landscape Client |
Fix Released
|
Undecided
|
Unassigned | ||
landscape-client (Ubuntu) |
Fix Released
|
Medium
|
Andreas Hasenack | ||
Trusty |
Fix Released
|
Medium
|
Simon Poirier | ||
Xenial |
Fix Released
|
Medium
|
Simon Poirier | ||
Artful |
Won't Fix
|
Medium
|
Unassigned | ||
Bionic |
Fix Released
|
Medium
|
Andreas Hasenack |
Bug Description
[Impact]
* This issue affects users of the release-upgrade feature of landscape.
* Landscape package monitor would previously race during an upgrade
and possibly grab apt locks, thus making the upgrade fail.
* The fix adds checks during package operations to make sure a
release upgrade is not in progresss.
[Test Case]
* in /etc/landscape/
"log_
* Launch a release upgrade from landscape-server. Look for messages
in the package-monitor logs stating "conditions not met"
[Regression Potential]
* Unlikely, as this has already been released to newer ubuntu releases
and is fairly well tested.
* Any issue with related changes would likely only affect the client
getting new package info, but won't affect other functionality.
[Original description]
Affected release: Ubuntu 14.04.5
Version of package: 14.12-0ubuntu5.
Steps to reproduce:
1. Run do-release-upgrade to upgrade to 16.04.2.
2. Trigger the package-reporter to kick in while do-release-upgrade is working but not having the package database locked.
3. Package database is locked by package-reporter, do-release-upgrade fails to access it and exits.
Expected result:
Landscape detects that there's an release upgrade in progress and will wait for it to finish.
Actual result:
PackageReporter locks the apt database, do-release-upgrade cannot access it, exits with an error and may leave the system in an unusable state.
* Link to Dariusz's PR on GitHub:
https:/
Related branches
- Andreas Hasenack: Approve
- Canonical Server: Pending requested
- git-ubuntu developers: Pending requested
-
Diff: 548 lines (+502/-0)7 files modifieddebian/changelog (+16/-0)
debian/patches/1616116-resync-loop.patch (+142/-0)
debian/patches/nutanix-kvm.patch (+17/-0)
debian/patches/post-upgrade-reboot.patch (+132/-0)
debian/patches/release-upgrade-success.patch (+23/-0)
debian/patches/series (+5/-0)
debian/patches/unicode-tags-script.patch (+167/-0)
- Andreas Hasenack: Approve
- git-ubuntu developers: Pending requested
-
Diff: 601 lines (+555/-0)7 files modifieddebian/changelog (+16/-0)
debian/patches/1616116-resync-loop.patch (+142/-0)
debian/patches/1699179-release-upgrade-check.diff (+219/-0)
debian/patches/nutanix-kvm.patch (+18/-0)
debian/patches/post-upgrade-reboot.patch (+132/-0)
debian/patches/release-upgrade-success.patch (+23/-0)
debian/patches/series (+5/-0)
- Andreas Hasenack: Approve
- git-ubuntu developers: Pending requested
-
Diff: 601 lines (+555/-0)7 files modifieddebian/changelog (+16/-0)
debian/patches/1616116-resync-loop.patch (+142/-0)
debian/patches/1699179-release-upgrade-check.diff (+219/-0)
debian/patches/nutanix-kvm.patch (+18/-0)
debian/patches/post-upgrade-reboot.patch (+132/-0)
debian/patches/release-upgrade-success.patch (+23/-0)
debian/patches/series (+5/-0)
summary: |
- package-reporter kicks in during do-release-upgrade + PackageReporter kicks in during do-release-upgrade |
description: | updated |
Changed in landscape-client (Ubuntu): | |
assignee: | nobody → Dariusz Gadomski (dgadomski) |
tags: | added: sts sts-sru-needed |
description: | updated |
Changed in landscape-client (Ubuntu Artful): | |
assignee: | Dariusz Gadomski (dgadomski) → nobody |
tags: | added: sts-sponsor-slashd |
tags: | removed: sts-sponsor-slashd |
Changed in landscape-client: | |
status: | New → Fix Committed |
milestone: | none → 18.01 |
no longer affects: | landscape-client (Ubuntu Zesty) |
Changed in landscape-client (Ubuntu Bionic): | |
assignee: | nobody → Andreas Hasenack (ahasenack) |
status: | New → In Progress |
Changed in landscape-client: | |
status: | Fix Committed → Fix Released |
Changed in landscape-client (Ubuntu Trusty): | |
importance: | Undecided → Medium |
Changed in landscape-client (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in landscape-client (Ubuntu Artful): | |
importance: | Undecided → Medium |
Changed in landscape-client (Ubuntu Bionic): | |
importance: | Undecided → Medium |
Changed in landscape-client (Ubuntu Artful): | |
status: | New → Won't Fix |
description: | updated |
Changed in landscape-client (Ubuntu Cosmic): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Simon Poirier (simpoir) |
Changed in landscape-client (Ubuntu Xenial): | |
status: | New → In Progress |
assignee: | nobody → Simon Poirier (simpoir) |
Changed in landscape-client (Ubuntu Trusty): | |
status: | New → In Progress |
assignee: | nobody → Simon Poirier (simpoir) |
tags: |
added: verification-done-xenial removed: verification-needed-xenial |
tags: |
added: verification-done-trusty removed: verification-needed verification-needed-trusty |
Link to Dariusz's PR on GitHub:
https:/ /github. com/CanonicalLt d/landscape- client/ pull/14