make sourcepackage is broken
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Landscape Client |
Fix Committed
|
Undecided
|
Ursula Junque | ||
landscape-client (Ubuntu) |
Fix Released
|
Undecided
|
Andreas Hasenack |
Bug Description
As of r931, make sourcepackage is broken. It fails showing a diff from the orig file, saying .bzr-builddeb isn't there. Tested on trusty.
make sdist is responsible for creating the source tarball, using "bzr export" to copy files to a temporary sdist folder. Issue is that command ignores the hidden files, leaving the checked in .bzr-builddeb directory behind. When the step to build the actual package runs, it finds the diff as that directory is missing and fails:
{{{
dpkg-source: info: local changes detected, the modified files are:
trunk/
dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/landscape-
dpkg-source: info: you can integrate the local changes with dpkg-source --commit
dpkg-buildpackage: error: dpkg-source -b trunk gave error exit status 2
debuild: fatal error at line 1364:
dpkg-buildpackage -rfakeroot -d -us -uc -S failed
make: *** [sourcepackage] Error 29
}}}
To fix this, we need to add a line to Makefile so these are copied over, or delete the directory altogether before running make sourcepackage.
Related branches
- Adam Collard (community): Approve
- Alberto Donato (community): Approve
- 🤖 Landscape Builder: Approve (test results)
-
Diff: 1 lines (+0/-0)0 files modified
description: | updated |
description: | updated |
Changed in landscape-client: | |
status: | New → In Progress |
assignee: | nobody → Ursula Junque (ursinha) |
Changed in landscape-client: | |
status: | In Progress → Fix Committed |
Changed in landscape-client (Ubuntu): | |
assignee: | nobody → Andreas Hasenack (ahasenack) |
status: | New → In Progress |
Hmm, I can see this but not when I rm -r .bzr-builddeb. - it doesn't appear to be related to the recent changes (i get the same issue on r929)
Ursula, can you confirm that you're able to reproduce this on a clean checkout?