driverevent has timing issue

Bug #1282074 reported by Harald Sitter on 2014-02-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kubuntu-notification-helper (Ubuntu)
High
Rohan Garg

Bug Description

driverevent::show decides whether to show a notificaiton based on m_showNotification, which is set via an async call chain starting in the constructor. however, ::show() is called by the module.cpp regardless of whether the async call chain has finished yet, thus causing bogus behavior if the call chain has not reached ::driverMapFinished by the time ::show is called.

Rohan Garg (rohangarg) on 2014-02-20
Changed in kubuntu-notification-helper (Ubuntu):
status: Triaged → Fix Committed
Harald Sitter (apachelogger) wrote :

Still broken, just in other ways now. Should get architectural fix as currently the ctor triggers show() which is wrong.

Changed in kubuntu-notification-helper (Ubuntu):
status: Fix Committed → Triaged
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kubuntu-notification-helper - 14.04ubuntu6

---------------
kubuntu-notification-helper (14.04ubuntu6) trusty; urgency=low

  [ Harald Sitter ]
  * Prevent events from spwaning more than one notifier item at a time.
    Notifications are still issued whenever show() is called as they serve
    a reminding purpose. LP: #1275427
  * Drop ubuntu-release-upgrader-qt depends (upgrade handling moved to muon)
  * Implement L10nEvent notifying the user once (after login) if the language
    support is incomplete and uses qapt-batch to complete it.
    + Add new build dep on libkubuntu to do completeness checks.
  * Event::show now only manually dispatches a KNotification iff tray icons
    are deactivated. KSNI has a dedicated showMessage function that handles
    issuing a notification for a present KSNI, this also avoids pixmap passing
    in default installation giving an overall better quality.
  * Bump KNotification pixmap size to 32x32 (from 22x22) to reduce amount of
    ugly scaling artifacts (going up or down from 32 is more reasonable than
    for example 22 to 64 - as would be the case with a plasma notification).
  * Drop unused kcm_notificationhelper-es.po (supposedly the export from
    launchpad went wrong in 13.10)
  * Change module.cpp init list to c++11 'nullptr' and fix indention level

  [ Rohan Garg ]
  * Add a DriverEvent class to show notifications when the system has extra
    drivers that can be installed.
    + Misc. bug fixes
      - LP: #128208 , LP: #1282082 , LP: #1282085 , LP: #1282471 ,
        LP: #1282468 , LP: #1282074 , LP: #1282462, LP: #1282095 ,
        LP: #1282464
  * Add runtime dep on kubuntu-driver-manager
 -- Rohan Garg <email address hidden> Thu, 20 Feb 2014 16:22:31 +0100

Changed in kubuntu-notification-helper (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers