Kubuntu "start here" icon moved

Bug #559725 reported by Jonathan Thomas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kdebase-workspace (Ubuntu)
Fix Released
Low
Alessandro Ghersi
Lucid
Fix Released
Low
Alessandro Ghersi
kubuntu-default-settings (Ubuntu)
Fix Released
Low
Harald Sitter
Lucid
Fix Released
Low
Harald Sitter

Bug Description

Binary package hint: kubuntu-default-settings

The Kubuntu "start here" icon's name changed in the latest k-d-s upload. Now KIconLoader is in it's smartness using an alternate low-res logo as a fallback.

Changed in kubuntu-default-settings (Ubuntu):
milestone: none → ubuntu-10.04
Changed in kdebase-workspace (Ubuntu):
milestone: none → ubuntu-10.04
Changed in kubuntu-default-settings (Ubuntu):
assignee: nobody → Harald Sitter (apachelogger)
Changed in kubuntu-default-settings (Ubuntu):
status: New → Fix Committed
Changed in kdebase-workspace (Ubuntu Lucid):
status: New → Confirmed
Changed in kubuntu-default-settings (Ubuntu Lucid):
importance: Undecided → Low
Changed in kdebase-workspace (Ubuntu Lucid):
assignee: nobody → Harald Sitter (apachelogger)
importance: Undecided → Low
Changed in kdebase-workspace (Ubuntu Lucid):
assignee: Harald Sitter (apachelogger) → Alessandro Ghersi (alessandro-ghersi)
Revision history for this message
Alessandro Ghersi (alessandro-ghersi) wrote :

Looking quickly...I can move configuration reading and setup from init() to the slot configChanged() like that:

plasma/desktop/applets/kickoff/applet/applet.cpp

void LauncherApplet::init()
{
- KConfigGroup cg = config();
- setPopupIcon(cg.readEntry("icon", "start-here-kde"));
+ configChanged();

............

+void LauncherApplet::configChanged()
+{
+ KConfigGroup cg = config();
+ setPopupIcon(cg.readEntry("icon", "start-here-kde"));
+}

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kubuntu-default-settings - 1:10.04ubuntu16

---------------
kubuntu-default-settings (1:10.04ubuntu16) lucid; urgency=low

  [ Harald Sitter ]
  * Add plasma-desktop update script 02-kubuntu-menu-icon.js to migrate
    from wrongly named kubuntu-menu to start-here-kubuntu icon (LP: #559725)
    + This requires a configChanged() interface to be implemented in kickoff

  [ Ryan Kavanagh ]
  * Updated the plymouth-theme-kubuntu-logo logo with the new logo (we've got
    a pretty K now). (LP: #557220)

  [ Steve Langasek ]
  * Sync up the plymouth theme script with the version in ubuntu-logo, fixing
    a number of text display bugs. The only remaining delta is the background
    color, and the logo name. LP: #557102.
 -- Kubuntu Developers <email address hidden> Fri, 09 Apr 2010 21:23:53 -0400

Changed in kubuntu-default-settings (Ubuntu Lucid):
status: Fix Committed → Fix Released
Revision history for this message
Harald Sitter (apachelogger) wrote :

Above mentioned approach will only work as long as the function only contains loading the icon, though from an upstream POV it should also contain all the other stuffs, I suppose even then it stays valid as long as no special magic is necessar.

I am not sure I like the naming though ;)
init should call loadConfig or reloadConfig IMHO, which might also be an interface of interest for configChanged, but that init calls configChanged is a bit weird, since the config didn't change, or at least we do not know about it ;)

Also, in the particular code example presented, I would like to mention that the overhead of creating the function is probably not worth the code reusage, and implementing it inline would not make any difference from not using the function in init.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kdebase-workspace - 4:4.4.2-0ubuntu8

---------------
kdebase-workspace (4:4.4.2-0ubuntu8) lucid; urgency=low

  [ Scott Kitterman ]
  * Add systemsettings replaces kde-systemsettings for Hardy upgrades where
    Ubuntu and Kubuntu are both installed
  * Add klipper replaces klipper-kde4 for Hardy upgrades
  * Add kdm replaces kdm-kde4 for Hardy upgrades

  [ Harald Sitter ]
  * Add kubuntu_03_kickoff_configchanged.diff to add a simplified configChanged
    interface to kickoff, so that we can temper with it's config via scripts.
    As done in kubuntu-default-settings for LP: #559725
 -- Harald Sitter <email address hidden> Sat, 10 Apr 2010 12:08:54 +0200

Changed in kdebase-workspace (Ubuntu Lucid):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.