SIGSEGV when using kopete-cryptography with kopete 4.2.3

[x127]

Binary package hint: kopete-cryptography

I am using kopete-cryptography 1.3.0-kde4.2.0-0ubuntu4 together with kopete 4:4.2.3-0ubuntu1~jaunty1~ppa1 from the kubuntu-ppa repository to avoid other kopete-cryptography related bugs (https://bugs.launchpad.net/ubuntu/+source/kopete-cryptography/+bug/293146 ).

I have noticed two issues. This is the first one.

When receiving an encrypted jabber message from a contact whose chat window is not open, kopete crashes with SIGSEGV. If, on the other hand, the chat window is already opened before the encrypted message arrives it is decrypted just fine.

I am using Ubuntu 9.04 for amd64 with the kubuntu-ppa repository. My window manager is wmaker.

It appears that there is a newer version of kopete-cryptography available upstream (ftp://ftp.kde.org/pub/kde/stable/latest/src/extragear/kopete-cryptography-1.3.0-kde4.2.3.tar.bz2 ) which is not yet included in kubuntu-ppa with the rest of kde-4.2.3.

(I'm not sure if it is okay to report bugs regarding ppa packages here. Please tell me if it is not. )

[Jaroslav Reznik (jreznik)]

Version: 1.3.0-kde4.1.3 (using KDE 4.1.3)
OS: Linux
Installed from: Fedora RPMs

Chat session is destroyed before finalizing crypto job and Kopete crashes on appending message to it.

How to reproduce:
Send encrypted message to some (Jabber) contact with no chat session established.
Result:
Kopete crashes
Expected result:
Kopete do not crash
Workaround:
Use msg.manager()->setCanBeDeleted( false ) when starting crypto job and set it to true after job is finalized.

[Jaroslav Reznik (jreznik)]

Created attachment 29175
Workaround?

[Alan Jones (skyphyr)]

Hi Jaroslav,

I've been attempting repro on this and not managed. The sessions are automatically establishing here. If there's any additional information you could provide, or ideally a backtrace. That would be great. If you can manage a backtrace please post it in the comment as attachment contents aren't searchable.

Cheers,

Alan.

[Jaroslav Reznik (jreznik)]

Hi Alan,
message manager is deleted too early, so in finalizeMessage does not exists and Crypto plugin crashes. Preventing deletion of message manager with setCanBeDeleted helps - see my patch. What's your Kopete version?.

Backtrace:
[KCrash handler]
#5 Kopete::ChatSession::myself (this=0x0)
    at /home/jreznik/Download/kdenetwork-4.1.3/kopete/libkopete/kopetechatsession.cpp:188
#6 0x0000003371699963 in Kopete::ChatSession::appendMessage (
    this=<value optimized out>, msg=<value optimized out>)
    at /home/jreznik/Download/kdenetwork-4.1.3/kopete/libkopete/kopetechatsession.cpp:279
#7 0x00007f79e1b74dfe in CryptographyPlugin::finalizeMessage (
    this=<value optimized out>, msg=@0x7ffff32fd010,
    intendedBody=<value optimized out>, verificationResult=@0x7ffff32fcfe0,
    encrypted=true)
    at /home/jreznik/Download/kopete-cryptography-1.3.0-kde4.1.3/cryptographyplugin.cpp:266
#8 0x00007f79e1b75993 in CryptographyPlugin::slotIncomingEncryptedMessageContinued (this=0x13a1800, decryptionResult=@0x7ffff32fd190,
    plainText=@0x7ffff32fd1b0)
    at /home/jreznik/Download/kopete-cryptography-1.3.0-kde4.1.3/cryptographyplugin.cpp:199
#9 0x00007f79e1b760e8 in CryptographyPlugin::qt_metacall (this=0x13a1800,
    _c=QMetaObject::InvokeMetaMethod, _id=<value optimized out>,
    _a=0x7ffff32fd150)
    at /home/jreznik/Download/kopete-cryptography-1.3.0-kde4.1.3/build/cryptographyplugin.moc:94
#10 0x00000038c1d56764 in QMetaObject::activate ()
   from /usr/lib64/libQtCore.so.4
#11 0x00007f79e187dea1 in Kleo::DecryptJob::result ()
   from /usr/lib64/libkleo.so.4
#12 0x00007f79e18ccea5 in ?? () from /usr/lib64/libkleo.so.4
#13 0x00000038c1d56764 in QMetaObject::activate ()
   from /usr/lib64/libQtCore.so.4
#14 0x00000038c1c4b657 in QFutureWatcherBasePrivate::sendCallOutEvent ()
   from /usr/lib64/libQtCore.so.4
#15 0x00000038c1c4ba5d in QFutureWatcherBase::event ()
   from /usr/lib64/libQtCore.so.4
#16 0x000000336bb8281d in QApplicationPrivate::notify_helper ()
   from /usr/lib64/libQtGui.so.4
#17 0x000000336bb8a5ca in QApplication::notify () from /usr/lib64/libQtGui.so.4
#18 0x000000336d1fb46b in KApplication::notify () from /usr/lib64/libkdeui.so.5
#19 0x00000038c1d42391 in QCoreApplication::notifyInternal ()
   from /usr/lib64/libQtCore.so.4
#20 0x00000038c1d4302a in QCoreApplicationPrivate::sendPostedEvents ()
   from /usr/lib64/libQtCore.so.4
#21 0x00000038c1d6ab13 in ?? () from /usr/lib64/libQtCore.so.4
#22 0x00000038b903779b in g_main_context_dispatch ()
   from /lib64/libglib-2.0.so.0
#23 0x00000038b903af6d in ?? () from /lib64/libglib-2.0.so.0
#24 0x00000038b903b12b in g_main_context_iteration ()
   from /lib64/libglib-2.0.so.0
#25 0x00000038c1d6a79f in QEventDispatcherGlib::processEvents ()
   from /usr/lib64/libQtCore.so.4
#26 0x000000336bc1319f in ?? () from /usr/lib64/libQtGui.so.4
#27 0x00000038c1d40cb2 in QEventLoop::processEvents ()
   from /usr/lib64/libQtCore.so.4
#28 0x00000038c1d40e3d in QEventLoop::exec () from /usr/lib64/libQtCore.so.4
#29 0x00000038c1d432ed in QCoreApplication::exec ()
   from /usr/lib64/libQtCore.so.4
#30 0x00000000004429c1 in main (argc=1, argv=0x7ffff32fe8a8)
    at /home/jreznik/Download/kdene...

[Olivier Goffart (ogoffart)]

Hi Jaroslav, Thanks for your patch.
You should use ref()/deref() instead of setCanBeDeleted.

You can send your patch on reviewboard.kde.org

[Jonathan Thomas (echidnaman)]

Thank you for your bug report. This bug has been reported to the developers of the software. You can track it and make comments at: https://bugs.kde.org/show_bug.cgi?id=177302

[Pino Toscano (pinotree)]

*** Bug 255827 has been marked as a duplicate of this bug. ***

[Pino Toscano (pinotree)]

*** Bug 255876 has been marked as a duplicate of this bug. ***

[adaptee (adaptee)]

*** Bug 284660 has been marked as a duplicate of this bug. ***

[adaptee (adaptee)]

*** Bug 297855 has been marked as a duplicate of this bug. ***

[Andrew-crouthamel (andrew-crouthamel)]

Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!

[Bug-janitor (bug-janitor)]

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

[Bug-janitor (bug-janitor)]

This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!