Solarized color scheme is broken

[soredake]

This is displayed with "Solarized":
https://invent.kde.org/utilities/konsole/uploads/2c16c1f86db4dfdeb9618d16e0fc0654/image.png

And this is with default "Breeze":
https://invent.kde.org/utilities/konsole/uploads/a4793763738031bf0c4d54f20034fe2a/image.png

Tested with konsole from flatpak + bash and konsole from apt with fish/bash

My os is kubuntu 20.04

[Rschirone (rschirone)]

If you select the "Solarized Dark" theme or the "Solarized Light" one, when you do `ls --color` all files are displayed pretty much with the same color, even if they are directories or normal files. Other commands like `grep --color PATTERN files` seem to work and they are correctly coloured.

I tried this on OpenSUSE Leap, OpenSUSE Tumbleweed and KUbuntu 16.04 (and with the PPA to have an updated KDE version), all with the same result. The only distro where the Solarized them works well is Fedora 23 KDE.

Looking at their package, there is this patch http://pkgs.fedoraproject.org/cgit/rpms/konsole5.git/tree/konsole-15.12.3-xterm-256color.patch but even setting that variable didn't solve the issue. I believe Fedora is working well because they applied also some patches to the coreutils package (for example http://pkgs.fedoraproject.org/cgit/rpms/coreutils.git/tree/coreutils-8.25-DIR_COLORS.patch, http://pkgs.fedoraproject.org/cgit/rpms/coreutils.git/tree/coreutils-8.5-dircolors.patch, http://pkgs.fedoraproject.org/cgit/rpms/coreutils.git/tree/coreutils-colorls.sh).

I think it would be nice having the right colours for `ls --color` even without changing the colors of ls.

Reproducible: Always

Steps to Reproduce:
1. Goto Settings > Edit Current Profile > Appearance
2. Select Solarized Dark theme > Apply > Ok
3. Execute `ls --color /etc`

Actual Results:
Directories and normal files in /etc are all displayed with the same color and regular style

Expected Results:
Directories should have a different colour, to make it easier distinguish dirs and files.

[Hook Hong (cat-hook31894)]

Also reference to this bug: https://bugs.kde.org/show_bug.cgi?id=387709

[Strangiato Xanadu (strangiato)]

Both solarized and solarized light color schemes use the same color to list files and folders on Arch Linux, konsole 18.04.

[soredake (soredake)]

It still happening https://invent.kde.org/utilities/konsole/-/issues/7

[Justin Zobel (justin-zobel)]

Can confirm still an issue on 20.08.1

If anyone has time to tinker with the color schemes they are in:

https://invent.kde.org/utilities/konsole/-/blob/master/data/color-schemes/SolarizedLight.colorscheme
https://invent.kde.org/utilities/konsole/-/blob/master/data/color-schemes/Solarized.colorscheme

[Aapje112513-q (aapje112513-q)]

So this appears to be 'fixed' in 4:20.12.0-0xneon+20.04+focal+build10. My fresh install of KDE Neon now shows full coloring. Upon reverting Konsole and Konsole-kpart to 4:20.08.3-0xneon+20.04+focal+build9 the old coloring is back.

However, I liked it the color-less way, and I would like to keep it.

Looking at the changes, I don't see what caused it to get 'fixed': https://invent.kde.org/utilities/konsole/-/compare/release%2F20.12...release%2F20.08

What would be the way to keep the old gray solarized-dark theming? Could anyone point at the commit that fixed this?