>yiaddr is set elsewhere in the code already (in dhcp_send_discover()
If that is the case it is also wrong;
I wonder what IP are they using in a DHCP DISCOVERY??
that makes absolute not sense for a booting client trying to get an IP.
> please check whether this actually fixes the issue.
I encourage you to stop the guesswork and fix this upon what RFC2131 says
(which is pretty clear on this regard, just see its page 36)
yiaddr must be 0 on packets sent by the client.
I encourage you not to tag this bug as "fix released"
>yiaddr is set elsewhere in the code already (in dhcp_send_ discover( )
If that is the case it is also wrong;
I wonder what IP are they using in a DHCP DISCOVERY??
that makes absolute not sense for a booting client trying to get an IP.
anyway it seems you are wrong:
int dhcp_send_ discover( struct netdev *dev)
{
dev->ip_addr = INADDR_ANY;
dev->ip_gateway = INADDR_ANY;
dprintf("-> dhcp discover ");
return dhcp_send(dev, dhcp_discover_iov);
}
> please check whether this actually fixes the issue.
I encourage you to stop the guesswork and fix this upon what RFC2131 says
(which is pretty clear on this regard, just see its page 36)
yiaddr must be 0 on packets sent by the client.
I encourage you not to tag this bug as "fix released"
Best,
Patrick