svn_dirent_join: Assertion `svn_dirent_is_canonical(base, pool)' failed.

[Pierre Schweitzer]

Dear all,

KGB-client is totally broken on Ubuntu 14.04 LTS with SVN repository.

When invoking it as it would be from a hook:
kgb-client --conf /etc/kgb-client/kgb-reactos.conf --repository svn /srv/svn/reactos/ 65590
given is experimental at /usr/bin/kgb-client line 245.
when is experimental at /usr/bin/kgb-client line 246.
when is experimental at /usr/bin/kgb-client line 247.
given is experimental at /usr/bin/kgb-client line 265.
when is experimental at /usr/bin/kgb-client line 266.
when is experimental at /usr/bin/kgb-client line 267.
given is experimental at /usr/bin/kgb-client line 293.
when is experimental at /usr/bin/kgb-client line 294.
when is experimental at /usr/bin/kgb-client line 295.
perl: /build/buildd/subversion-1.8.8/subversion/libsvn_subr/dirent_uri.c:972: svn_dirent_join: Assertion `svn_dirent_is_canonical(base, pool)' failed.
Aborted

Googled a bit, and found this: http://svn.haxx.se/dev/archive-2014-01/0161.shtml
So, this is related to subversion 1.8.8.

A kind of fix is proposed here: http://svn.haxx.se/dev/archive-2014-01/0162.shtml

Cheers,
Pierre

[Pierre Schweitzer (pierre-jean-schweitzer)]

I also tried with package 1.33-2ubuntu1 (from Vivid), nothing better, still the same error (less verbose though :-)):
kgb-client --conf /etc/kgb-client/kgb-reactos.conf --repository svn "/srv/svn/reactos/" "65590"
perl: /build/buildd/subversion-1.8.8/subversion/libsvn_subr/dirent_uri.c:972: svn_dirent_join: Assertion `svn_dirent_is_canonical(base, pool)' failed.
Aborted

[Pierre Schweitzer (pierre-jean-schweitzer)]

It's interestingg to note that with the latest package, the assertion still fails BUT it can display a bit of information: commiter name, files changed. But it eats the commit message.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Pierre Schweitzer (pierre-jean-schweitzer)]

So, after discussing with the devs, when called from a SVN hook, a leading "/" is added to the path and it produces the error.
If removed, it doesn't hit the assert.

So, the bug is that kgb-client should chomp the leadng "/" if any.