On Fri, Dec 02, 2011 at 07:29:50AM -0000, Louis Bouchard wrote:
> Mouting the root filesystem Read/Write is required in order to save the
> vmcore information on the root filesystem, which is the sole intent of
> this script.
Yes, I understand that. I was referring to the reordering done in your
patch, which moved the rw remount call ahead of two checks that, if they
fail, call panic().
I've dropped this particular change in committing to bzr, because I don't
see any reason it's needed. Sounds like you don't either. :)
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>
On Fri, Dec 02, 2011 at 07:29:50AM -0000, Louis Bouchard wrote:
> Mouting the root filesystem Read/Write is required in order to save the
> vmcore information on the root filesystem, which is the sole intent of
> this script.
Yes, I understand that. I was referring to the reordering done in your
patch, which moved the rw remount call ahead of two checks that, if they
fail, call panic().
I've dropped this particular change in committing to bzr, because I don't
see any reason it's needed. Sounds like you don't either. :)
Thanks, www.debian. org/
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://
<email address hidden> <email address hidden>