kexec-tools does not build for armhf

Bug #1671246 reported by Manoj Iyer on 2017-03-08
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kexec-tools (Ubuntu)
High
Manoj Iyer
Xenial
High
Manoj Iyer
Yakkety
High
Manoj Iyer

Bug Description

[Impact]
On armhf system kexec build fails as follows:
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fno-strict-aliasing -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -I./include -I./util_lib/include -Iinclude/ -I./kexec/libfdt -I./kexec/arch/arm/include -c -MD -o kexec/arch/arm/phys_to_virt.o kexec/arch/arm/phys_to_virt.c
make[1]: *** No rule to make target 'kexec/arch/arm/iomem.o', needed by 'build/sbin/kexec'. Stop.

The fix for this issue is already upstream:

From c901bae8683c59a7bc002bd6a1e3e4b6b7d9c5f1 Mon Sep 17 00:00:00 2001
From: Simon Horman <email address hidden>
Date: Fri, 9 Dec 2016 10:10:49 +0100
Subject: [PATCH] arm: do not build iomem.o target with no soruce

Header files should be added to the distribution but not
used to derive targets for compilation. In this an attempt was
made to build iomem.o, but iomem.c does not exist so this fails.

Fixes: 1574ff1aae4f ("arm: include phys_to_virt.h and iomem.h in distribution")
Signed-off-by: Simon Horman <email address hidden>
Reviewed-by: Pratyush Anand <email address hidden>

[Test Case]
Build kexec-tools package from Xenial/Yakkety source in armhf system.

[Regression Potential]
Since patch is confined to arm there is a low overall risk of regression

Manoj Iyer (manjo) wrote :

This debdiff applies cleanly and builds https://pastebin.canonical.com/181891/

Manoj Iyer (manjo) wrote :

This debdiff applies and builds cleanly https://pastebin.canonical.com/181893/ on armhf

Changed in kexec-tools (Ubuntu):
status: New → Incomplete

The attachment "[Xenial] kexec fix armhf build failure" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
dann frazier (dannf) on 2017-03-09
Changed in kexec-tools (Ubuntu Xenial):
status: New → In Progress
Changed in kexec-tools (Ubuntu Yakkety):
status: New → In Progress
Changed in kexec-tools (Ubuntu Xenial):
importance: Undecided → High
Changed in kexec-tools (Ubuntu Yakkety):
importance: Undecided → High
dann frazier (dannf) on 2017-03-09
Changed in kexec-tools (Ubuntu Xenial):
assignee: nobody → Manoj Iyer (manjo)
Changed in kexec-tools (Ubuntu Yakkety):
assignee: nobody → Manoj Iyer (manjo)
Changed in kexec-tools (Ubuntu):
status: Incomplete → Invalid
Chris J Arges (arges) wrote :

This upload is waiting on verification of bug 1663400 and bug 1661363 before this version can make it into -proposed. Thanks.

Hello Manoj, or anyone else affected,

Accepted kexec-tools into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/kexec-tools/1:2.0.10-1ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in kexec-tools (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
tags: added: ftbfs
Changed in kexec-tools (Ubuntu):
status: Invalid → Fix Released
Manoj Iyer (manjo) on 2017-05-22
tags: added: verification-done
removed: verification-needed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers