fix kernel-wedge to accept all modules as optional

Bug #570625 reported by Amit Kucheria
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kernel-wedge (Ubuntu)
Triaged
Wishlist
Unassigned

Bug Description

Binary package hint: kernel-wedge

kernel-wedge requires that atleast one module is built-in. This is a drawback to make the d-i directory common across all archs/flavours in the kernel package.

The end goal is to have a common d-i directory with minimal changes across flavours.

Amit Kucheria (amitk)
Changed in kernel-wedge (Ubuntu):
importance: Undecided → Wishlist
milestone: none → later
Revision history for this message
Colin Watson (cjwatson) wrote : Re: [Bug 570625] [NEW] fix kernel-wedge to accept all modules as optional

I'm surprised that simply adding the ' ?' suffix doesn't deal with this.
Could you give me the error message that results from trying this?

Revision history for this message
Tim Gardner (timg-tpi) wrote :

I think the offending code is in commands/check:

#!/bin/sh -e
empty=
for pkg in $(dh_listpackages -s | grep -- '-di$'); do
 if [ -z "$(find debian/$pkg -type f)" ]; then
  echo "$pkg will be empty" >&2
  empty=1
 fi
done
if [ "$empty" ]; then
 exit 1
fi

I think we can get by with just emitting a warning and not returning an error.

Revision history for this message
Colin Watson (cjwatson) wrote : Re: [Bug 570625] Re: fix kernel-wedge to accept all modules as optional

We would need to ensure that the udeb is omitted (rather than generated
but empty) and that any dependencies on it are filtered out. Or
something like that.

Colin Watson (cjwatson)
Changed in kernel-wedge (Ubuntu):
status: New → Triaged
assignee: nobody → Colin Watson (cjwatson)
Colin Watson (cjwatson)
Changed in kernel-wedge (Ubuntu):
assignee: Colin Watson (cjwatson) → nobody
milestone: later → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.