[REMOVE PACKAGE] keras

[Heinrich Schuchardt]

Autopackage tests with python3-defaults 3.10 fail.

https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/k/keras/20220126_091515_f47bd@/log.gz

https://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html#python3-defaults

[Heinrich Schuchardt (xypron)]

keras 2.3.1 which we have packaged is only compatible to Python 2.7 - 3.6

The build errors relating to collections using Python 3.10 where fixed with patch e08753b3ebbcca2c7 in keras v2.7.0. The current version is v2.8.0.

[Andreas Hasenack (ahasenack)]

There are other instances of collections, which I fixed with the attached patch, or so I think.

But the build fails elsewhere, also during tests (and it's a long build, 6h!): https://launchpadlibrarian.net/584187637/buildlog_ubuntu-jammy-amd64.keras_2.3.1+dfsg-3ubuntu1~ppa2_BUILDING.txt.gz

For example:
            assert 'group3' in group2
            group3 = group2['group3']
> assert group3['y'] == [b'efg', b'hij', b'klmn']
E ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

and

        if 'keras_version' in f.attrs:
> original_keras_version = f.attrs['keras_version'].decode('utf8')
E AttributeError: 'str' object has no attribute 'decode'

[Andreas Hasenack (ahasenack)]

I've been using this ppa: https://launchpad.net/~ahasenack/+archive/ubuntu/py310-collections/+packages

[Heinrich Schuchardt (xypron)]

The build errors relating to collections using Python 3.10 where fixed with patch e08753b3ebbcca2c7 in keras v2.7.0. The current version is v2.8.0.

I guess we should upgrade to the v2.8.0 upstream instead of patching an outdated version.

[Heinrich Schuchardt (xypron)]

For Python 3.10 we would need Keras v2.8.0. Since v2.6.0 Keras does not support Theano as backend anymore but requires TensorFlow. We don't package TensorFlow.

So removing Keras and its reverse dependencies seems to be the best choice.

The following reverse dependencies need to be removed too:

* invesalius
* keras-preprocessing/python3-keras-preprocessing
* keras-applications/python3-keras-applications

A 'Recommends:' for python3-keras should be removed in debian-astro/astro-python3.

[Andreas Hasenack (ahasenack)]

It would require a lot of time for me to try to fix the remaining test issues, and I don't know this package well enough to update it to the latest upstream ahead of debian, or even to test my changes properly. I'm +1 for removal, and if debian updates it to latest upstream, we can let it in again.

[Steve Langasek (vorlon)]

$ reverse-depends src:keras
Reverse-Recommends
* astro-python3 (for python3-keras)
* python3-keras-applications (for python3-keras)
* python3-keras-preprocessing (for python3-keras)

Reverse-Depends
* invesalius (for python3-keras)

Packages without architectures listed are reverse-dependencies in: amd64, arm64, armhf, i386, ppc64el, s390x
$

Requests for removal need to either confirm there are no reverse-dependencies of the package, or indicate what should be done with those reverse-dependencies (fix or remove) to avoid increasing the count of uninstallable packages in the archive.

[Steve Langasek (vorlon)]

This was addressed in a previous comment that I overlooked.

The only hard reverse-dependency is invesalius. It in turn has no reverse-dependencies.

[Steve Langasek (vorlon)]

Removing packages from jammy:
 invesalius 3.1.99995-1 in jammy
  invesalius 3.1.99995-1 in jammy amd64
  invesalius 3.1.99995-1 in jammy arm64
  invesalius 3.1.99995-1 in jammy armhf
  invesalius 3.1.99995-1 in jammy i386
  invesalius 3.1.99995-1 in jammy ppc64el
  invesalius 3.1.99995-1 in jammy riscv64
  invesalius 3.1.99995-1 in jammy s390x
  invesalius-bin 3.1.99995-1 in jammy amd64
  invesalius-bin 3.1.99995-1 in jammy arm64
  invesalius-bin 3.1.99995-1 in jammy armhf
  invesalius-bin 3.1.99995-1 in jammy ppc64el
  invesalius-bin 3.1.99995-1 in jammy riscv64
  invesalius-bin 3.1.99995-1 in jammy s390x
  invesalius-examples 3.1.99995-1 in jammy amd64
  invesalius-examples 3.1.99995-1 in jammy arm64
  invesalius-examples 3.1.99995-1 in jammy armhf
  invesalius-examples 3.1.99995-1 in jammy i386
  invesalius-examples 3.1.99995-1 in jammy ppc64el
  invesalius-examples 3.1.99995-1 in jammy riscv64
  invesalius-examples 3.1.99995-1 in jammy s390x
Comment: Depends on keras, which ftbfs and blocks python3.10; LP: #1959918, Debian bug #997068.
1 package successfully removed.

[Steve Langasek (vorlon)]

Removing packages from jammy:
 keras 2.3.1+dfsg-3 in jammy
  python3-keras 2.3.1+dfsg-3 in jammy amd64
  python3-keras 2.3.1+dfsg-3 in jammy arm64
  python3-keras 2.3.1+dfsg-3 in jammy armhf
  python3-keras 2.3.1+dfsg-3 in jammy i386
  python3-keras 2.3.1+dfsg-3 in jammy ppc64el
  python3-keras 2.3.1+dfsg-3 in jammy riscv64
  python3-keras 2.3.1+dfsg-3 in jammy s390x
Comment: FTBFS, blocks python3.10; LP: #1959918, Debian bug #997068.
1 package successfully removed.