[SRU] Do not restart keepalived on unattended-upgrades
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
keepalived (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
Noble |
New
|
Undecided
|
Unassigned | ||
Oracular |
New
|
Undecided
|
Unassigned | ||
needrestart (Ubuntu) |
Fix Released
|
Undecided
|
Pragyansh Chaturvedi | ||
Noble |
New
|
Undecided
|
Unassigned | ||
Oracular |
New
|
Undecided
|
Unassigned |
Bug Description
[ Impact ]
* keepalived.service should not be automatically restarted after an
update as other services which depend on it might get disrupted.
* This change adds a regex pattern for keepalived.service in the default
needrestart.conf to prevent it's automatic restart.
[ Test Plan ]
* Install keepalived
* Create /etc/keepalived
* Enable and start keepalived using systemctl (it might get stuck while starting, just interrupt it using Ctrl-C)
* Then run `sudo apt reinstall libc6`
* keepalived.service will appear under `Restarting services...`, while it
should actually appear under `Service restarts being deferred:`
[ Where problems could occur ]
* If another service using /usr/sbin/
might reoccur.
[ Other Info ]
* Original bug report:
```
unattended-upgrades has restarted keepalived (noble,now 1:2.2.8-1build2 amd64) due to the update of library libglib2.0-0t64.
It is not excluded in /etc/needrestar
Please add an entry so keepalived is not restarted automatically by unattended-
```
Related branches
- Simon Quigley (community): Needs Fixing (noop)
- Andreas Hasenack: Needs Fixing
- Canonical Server Reporter: Pending requested
-
Diff: 1314 lines (+1161/-1)21 files modifieddebian/README.Ubuntu (+9/-0)
debian/changelog (+215/-0)
debian/control (+2/-1)
debian/needrestart.docs (+1/-0)
debian/patches/lp2063442/0017-Don-t-restart-the-google-guest-agent-services.patch (+21/-0)
debian/patches/lp2067482/0001-Factor-out-the-service-name-extraction-into-its-own-.patch (+141/-0)
debian/patches/lp2067482/0002-defer-restarting-the-service-that-called-needrestart.patch (+32/-0)
debian/patches/lp2067800/0018-Don-t-restart-the-GH-runner-provisionner-it-doesn-t-.patch (+21/-0)
debian/patches/lp2068573/0016-Document-the-custom-Ubuntu-m-u.patch (+56/-0)
debian/patches/lp2085070/0020-ubuntu-avoid-restart-glusterd.patch (+21/-0)
debian/patches/lp2089155/0021-ubuntu-avoid-restart-keepalived.patch (+21/-0)
debian/patches/series (+9/-0)
debian/patches/ubuntu-avoid-restart-cloud-final.patch (+28/-0)
debian/patches/ubuntu-mode.patch (+303/-0)
debian/tests/control (+12/-0)
debian/tests/mockuname.c (+46/-0)
debian/tests/prompt-reboot.py (+34/-0)
debian/tests/prompt-services.py (+128/-0)
debian/tests/restart-libc6-once.sh (+19/-0)
debian/tests/self-restart.sh (+19/-0)
debian/tests/testutils.py (+23/-0)
- Simon Quigley (community): Needs Fixing
- git-ubuntu import: Pending requested
-
Diff: 83 lines (+55/-0)4 files modifieddebian/changelog (+11/-0)
debian/patches/lp2085070/0022-ubuntu-avoid-restart-glusterd.patch (+21/-0)
debian/patches/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch (+21/-0)
debian/patches/series (+2/-0)
- Nick Rosbrook (community): Approve
- git-ubuntu import: Pending requested
-
Diff: 83 lines (+55/-0)4 files modifieddebian/changelog (+11/-0)
debian/patches/lp2085070/0020-ubuntu-avoid-restart-glusterd.patch (+21/-0)
debian/patches/lp2089155/0021-ubuntu-avoid-restart-keepalived.patch (+21/-0)
debian/patches/series (+2/-0)
- Simon Chopin: Pending requested
-
Diff: 82 lines (+54/-0)4 files modifieddebian/changelog (+11/-0)
debian/patches/lp2085070/0022-ubuntu-avoid-restart-glusterd.patch (+20/-0)
debian/patches/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch (+21/-0)
debian/patches/series (+2/-0)
affects: | needrestart (Ubuntu) → keepalived (Ubuntu) |
tags: | added: server-triage-discuss |
summary: |
- Do not restart keepalived on unattended-upgrades + [SRU] Do not restart keepalived on unattended-upgrades |
Changed in needrestart (Ubuntu): | |
assignee: | nobody → Pragyansh Chaturvedi (r41k0u) |
description: | updated |
Changed in needrestart (Ubuntu): | |
status: | New → In Progress |
tags: | removed: server-triage-discuss |
Hi,
We usually centralize those exceptions in the default needrestart conf rather than through snippets shipped per-package since a needrestart SRU is typically less costly.
Now, I have to ask a potentially stupid question here: *why* shouldn't keepalived be restarted?