Please sync from debian unstable 1.2.13-1

Bug #1460120 reported by Bryan Quigley
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keepalived (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

I first thought we couldn't do a sync, because of:
"Default-Stop: 1, instead of 0,1,6
Remove shutdown and reboot links"

but it turns out that is no longer correct for keepalived (see comment #2) and should be dropped.

Other Ubuntu specific change are fixed in Debian (for libnl3-dev).

The Ubuntu changes should be dropped and we should sync from Debian.

Changelog since 1.2.7:
keepalived (1:1.2.13-1) unstable; urgency=medium

  * [1e9c32b] Imported Upstream version 1.2.11
  * [bac64d6] Imported Upstream version 1.2.13
    - keep retry in case of early TCP failures in checks
      (Closes: #626466 #504069)
    - Add To header for SMTP alerts.
      (Closes: #627169)
    - handle passwords up to 8 characters
      (Closes: #614562)
    - modprobe handling fixed
      (Closes: #714377)
    - Support more than 31 interfaces
      (Closes: #723106)
    - Fix ipv6 realserver handling
      (Closes: #740258)
    - extend ip parser to support default and default6
      (Closes: #740573)

  * [65d5b11] Add pkg-config to build-deps
  * [af497e7] Disable obsolete patches
  * [4761254] Bump standards version (no changes)

 -- Alexander Wirt <email address hidden> Wed, 28 May 2014 09:01:38 +0200

keepalived (1:1.2.9-1) unstable; urgency=low

  * [8cd7bad] Imported Upstream version 1.2.9

 -- Alexander Wirt <email address hidden> Mon, 11 Nov 2013 22:45:58 +0100

keepalived (1:1.2.8-1) unstable; urgency=low

  * [b25f231] Patch configure.in instead of configure
  * [aa70432] Fix configure
  * [3a728cd] Enable sha1 support
  * [e257779] Add Homepage field
  * Allow providing of daemon args via /etc/defaul/keepalived
    Closes: #693877
  * Import upstream version 1.2.8 (Closes: #721966)
    - Fix reload handling (Closes: #652260)

 -- Alexander Wirt <email address hidden> Fri, 13 Sep 2013 08:54:19 +0200

Robie Basak (racb)
tags: added: upgrade-software-version
Robie Basak (racb)
Changed in keepalived (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Bryan Quigley (bryanquigley) wrote :

I'm looking to switch this back to a sync request -
The slight snmpd dependency bump isn't required (5.7 ubuntu and 5.7.2 are practically the same)
Removing the runlevel scripts for 06 might not be necessary with systemd (https://lists.ubuntu.com/archives/ubuntu-devel-discuss/2015-June/015560.html)

What I did to test sync:
Start with Wily cloud image install. Install keepalived build-depends.
Switch to debian archive, apt-get source keepalived
switch back to wily archive.
debuild -S -us -uc and debuild -B -us -uc - both worked fine
tried installing the created package, dpkg installs fine (plus apt-get -f install due to missing dependencies)
sudo service keepalived start/stop/status all work. No other tests were done, yet. Will try some other tests and then (if works) propose as sync tomorrow.

Revision history for this message
Bryan Quigley (bryanquigley) wrote :

Adding the removal of shutdown/restart scripts was discussed with Debian in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=495546

The Debian maintainer wanted more assurances that this wouldn't break things and ideally upstream approval. Since that bug was reported (2008) keepalived appears to have added actions to do on shutdown like (from the changelog):
vrrp: VRRP should notify other routers before it does any
  action that effects traffic flow. From John Southworth:
  Move the shutdown_vrrp_instances code to before the deletion
  of sock_pool. Move sending priority 0 adverts to before address
  removal occurs
VRRP : On shutdown, release sockets later to be able to send
  shutdown packet.

This would seem to indicate we should drop these Ubuntu modifications, which would also allow us to sync from Debian.
FYI - This initiative appears to be what added the change - https://wiki.ubuntu.com/Teardown

summary: - Please merge from debian unstable 1.2.13-1
+ Please sync from debian unstable 1.2.13-1
Revision history for this message
Bryan Quigley (bryanquigley) wrote :

Reseting to New as I changed it from a Merge to a Sync.

description: updated
Changed in keepalived (Ubuntu):
status: Triaged → New
Revision history for this message
Iain Lane (laney) wrote :

OK, if it needs to do stuff before shutdown then we should do this.

Revision history for this message
Iain Lane (laney) wrote :

This bug was fixed in the package keepalived - 1:1.2.13-1
Sponsored for Bryan Quigley (bryanquigley)

---------------
keepalived (1:1.2.13-1) unstable; urgency=medium

  * [1e9c32b] Imported Upstream version 1.2.11
  * [bac64d6] Imported Upstream version 1.2.13
    - keep retry in case of early TCP failures in checks
      (Closes: #626466 #504069)
    - Add To header for SMTP alerts.
      (Closes: #627169)
    - handle passwords up to 8 characters
      (Closes: #614562)
    - modprobe handling fixed
      (Closes: #714377)
    - Support more than 31 interfaces
      (Closes: #723106)
    - Fix ipv6 realserver handling
      (Closes: #740258)
    - extend ip parser to support default and default6
      (Closes: #740573)

  * [65d5b11] Add pkg-config to build-deps
  * [af497e7] Disable obsolete patches
  * [4761254] Bump standards version (no changes)

 -- Alexander Wirt <email address hidden> Wed, 28 May 2014 09:01:38 +0200

keepalived (1:1.2.9-1) unstable; urgency=low

  * [8cd7bad] Imported Upstream version 1.2.9

 -- Alexander Wirt <email address hidden> Mon, 11 Nov 2013 22:45:58 +0100

keepalived (1:1.2.8-1) unstable; urgency=low

  * [b25f231] Patch configure.in instead of configure
  * [aa70432] Fix configure
  * [3a728cd] Enable sha1 support
  * [e257779] Add Homepage field
  * Allow providing of daemon args via /etc/defaul/keepalived
    Closes: #693877
  * Import upstream version 1.2.8 (Closes: #721966)
    - Fix reload handling (Closes: #652260)

 -- Alexander Wirt <email address hidden> Fri, 13 Sep 2013 08:54:19 +0200

Changed in keepalived (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.