kde4 startupconfig missing

[humufr]

Binary package hint: kde4base

Hello,

I tried the last ppa package http://ppa.launchpad.net/kubuntu-members-kde4/ubuntu
for kde4 and I notice a problem. You cannot start kde4 with this packages.
If you don't have a previously .kde4 folder with a file ~/.kde4/share/config/startupconfig
you cannot not start kde4. To try it just remove the .kde4 folder and try to start from gdm/kdm the kde4 session.
The script will create a file: ~/.kde4/share/config/startupconfigkeys but not ~/.kde4/share/config/startupconfig and so you'll have an .xsession-errors because of this.

I copy the file ~/.kde4/share/config/startupconfigkeys as ~/.kde4/share/config/startupconfig and the kde4 session can start after this.

Thanks for the packages, it better to have some pre-compiled kde4 package so people can tell the problems encounter with kde4.

N.

[ilia (ilia)]

Confirming the issue. I've just installed latest KDE4 from PPA.
File /usr/lib/kde4/bin/startkde (belongs to kdebase-workspace-bin), line 82 reads:
. $kdehome/share/config/startupconfig

This file is initially missing. The problem is, that this script is run by /bin/sh, not /bin/bash and sh terminates a script, when it tries to source a non-existent file. Either an interpreter should be changed to bash (on the 1st line: #!/bin/bash), or the line should be changed to:
[ -e $kdehome/share/config/startupconfig] && . $kdehome/share/config/startupconfig

Importance of this bug should be increased (but it looks like I don't have an appropriate permissions), because this will totally prevent KDE 4 session from being started. However, it's quite easy to fix (see above).

[Terence Simpson (tsimpson)]

changing source package to kdebase-kde4

[Terence Simpson (tsimpson)]

Re-confirming against kdebase-kde4

[Che Guevara (che-guevara-3)]

It's kdebase-workspace not kdelibs

[Che Guevara (che-guevara-3)]

Debdiff to fix this

--- kdebase-workspace-3.97.0/debian/patches/series
+++ kdebase-workspace-3.97.0/debian/patches/series
@@ -8,0 +9 @@
+14_fix_startkde_bashism_svn_r748614.patch
diff -u kdebase-workspace-3.97.0/debian/changelog kdebase-workspace-3.97.0/debian/changelog
--- kdebase-workspace-3.97.0/debian/changelog
+++ kdebase-workspace-3.97.0/debian/changelog
@@ -1,3 +1,9 @@
+kdebase-workspace (4:3.97.0-1ubuntu6) hardy; urgency=low
+
+ * Fix bashism in startkde (upstream SVN r748614) (LP: #176135)
+
+ -- Ilya Eremin <email address hidden> Sat, 15 Dec 2007 00:50:00 +0000
+
 kdebase-workspace (4:3.97.0-1ubuntu5) hardy; urgency=low

   * Fix Exec= entry in .desktop files
only in patch2:
unchanged:
--- kdebase-workspace-3.97.0.orig/debian/patches/14_fix_startkde_bashism_svn_r748614.patch
+++ kdebase-workspace-3.97.0/debian/patches/14_fix_startkde_bashism_svn_r748614.patch
@@ -0,0 +1,14 @@
+Index: b/startkde.cmake
+===================================================================
+--- a/startkde.cmake
++++ b/startkde.cmake
+@@ -79,7 +79,7 @@
+ xmessage -geometry 500x100 "Could not start kstartupconfig4. Check your installation."
+ exit 1
+ fi
+-. $kdehome/share/config/startupconfig
++[ -e $kdehome/share/config/startupconfig] && . $kdehome/share/config/startupconfig
+
+ # XCursor mouse theme needs to be applied here to work even for kded or ksmserver
+ if test -n "$kcminputrc_mouse_cursortheme" -o -n "$kcminputrc_mouse_cursorsize" ; then
+

[Che Guevara (che-guevara-3)]

kdebase-workspace (4:3.97.0-1ubuntu6) hardy; urgency=low

  * Fix bashism in startkde (upstream SVN r748614) (LP: #176135)

 -- Ilya Eremin <email address hidden> Sat, 15 Dec 2007 00:50:00 +0000

[ilia (ilia)]

Thanks, Ilya!
Now I understand, your message in yesterday IRC :)

Please, ensure a space is added before the closing bracket in "[ -e
$kdehome/share/config/startupconfig ]". It seems like I've mistyped it
in a browser when I've reported a bug. I noted that in a patch above
it looks like there is no space before "]".

Sorry for inconvenience.

[Terence Simpson (tsimpson)]

This should fix that

[Che Guevara (che-guevara-3)]

wow sorry for the mess up, don't know how I didn't notice that
I've pushed this change upstream and I'll try to get the change into ubuntu (if stdin doesn't do it before me)

[Terence Simpson (tsimpson)]

This fix was committed a while ago, so I'm closing this bug.