12.04 plasma init script order wrong

Bug #1123126 reported by lordievader on 2013-02-12
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kde-workspace (Ubuntu)
Undecided
Unassigned
Precise
Critical
Rohan Garg

Bug Description

The folder-view widget with the installer link is not present on the desktop of the Kubuntu 12.04.2 live-cd (20130211). On both the i386 and amd64 is the folder-view widget missing from the desktop.

This is caused by plasma-desktop running upstream's init script
/usr/share/kde4/apps/plasma-desktop/init/00-defaultLayout.js
on first run instead of the one from kubuntu-default-settings
/usr/share/kubuntu-default-settings/kde4-profile/default/share/apps/plasma-desktop/init/00-defaultLayout.js

Ubuntu version: Kubuntu 12.04.2 live-cd (20130211)
What is expected: On the desktop there should be a folder-view widget with a link to the installer (ubiquity).
What happend instead: The folder-view widget is missing from the desktop.

tags: added: desktop
tags: added: live-cd
tags: added: folder-view

I have no idea why this happens.

there has been no change in kubuntu-default-settings

if I copy the k-d-s 00-defaultLayout.js script to /usr/share/kde4/apps/plasma-desktop/init/00-defaultLayout.js then it runs fine

kde4-config --path data does point to the k-d-s path before /usr/share/kde4/apps/

this did not happen in 12.04.1 which used KDE SC 4.8.2

this does not happen in quantal or raring

summary: - Folder view not present on the desktop of live-cd
+ plasma-desktop not running init script from k-d-s
description: updated
Ubuntu QA Website (ubuntuqa) wrote :

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/1123126

tags: added: iso-testing
Harald Sitter (apachelogger) wrote :
Download full text (3.9 KiB)

<apachelogger> QStringList scripts = KGlobal::dirs()->findAllResources("data", appName + "/init/*.js");
<apachelogger> scripts.sort();
<apachelogger> Riddell: that's why the plasma init script is not run
<shadeslayer> didn't we fix that already
<shadeslayer> s/we/I/
<kubotu> shadeslayer meant: "didn't I fix that already"
<apachelogger> not upstream apparently?
<shadeslayer> lolwot
<shadeslayer> untrue
<apachelogger> dunno
<apachelogger> looking at the sourcery right now
<shadeslayer> I upstreamed it man
<shadeslayer> I upstream all the things
<apachelogger> shadeslayer: not fixed in the 4.8 branch
<shadeslayer> bah
<apachelogger> or
<apachelogger> hm
<shadeslayer> patch it patch it patch it
<shadeslayer> 4.8 was EOL
<shadeslayer> right?
<apachelogger> there also was no patch in 4.8.2
<apachelogger> wtf
<shadeslayer> @_@
-*- shadeslayer sighs
<apachelogger> so
<apachelogger> it was
<apachelogger> QStringList scripts = KGlobal::dirs()->findAllResources("data", appName + "/init/*.js");
<apachelogger> QStringList scriptPaths;
<apachelogger> then it got a sort
<shadeslayer> right
<apachelogger> both shit because master looks completely different
<shadeslayer> we could actually get rid of all the weird logic
<apachelogger> well, not completely different
<apachelogger> just vastly different
<apachelogger> ah
<apachelogger> we should patch master into .5
<shadeslayer> dude, just look at my commit or sth
<apachelogger> much nicer code
<shadeslayer> heh
<shadeslayer> this is in workspace right?
<apachelogger> it uses findDirs rather than findAllResources and then builds the script paths manually
<apachelogger> http://quickgit.kde.org/?p=kde-workspace.git&a=blob&h=620915cc319bae50830a3b521f0f981a72c0d772&hb=e656398cefa2167aee1913244f633579676db985&f=libs%2Fplasmagenericshell%2Fscripting%2Fscriptengine.cpp
<apachelogger> last function
<shadeslayer> yus, that's me
<shadeslayer> omg apachelogger said my code is nice
<shadeslayer> my life is complete
<shadeslayer> :P
<apachelogger> well
<apachelogger> IIRC I came up with the algorithm :P
<apachelogger> did not realize it was such a well thought through one
<apachelogger> :)
<shadeslayer> eh, no one here wanted to know that :P
<apachelogger> shadeslayer: so you did not patch .8 for which you should get a beating really
<apachelogger> and that .sort there is what breaks it obviously
<apachelogger> what with /usr/share/kde4 < /usr/share/kubuntu-*
<shadeslayer> no, I was under the assumption that .8 was EOL so it was pointless
<shadeslayer> but turns out we ship EOL software for precise
<apachelogger> version+2 needs to be released for a release to go EOL upstream
<apachelogger> shadeslayer: it was not EOL at the time
<shadeslayer> and we discovered this issue in the first 4.10 release IIRC
<apachelogger> it only went EOL like 2 weeks ago :S
<apachelogger> shadeslayer: nope
<apachelogger> that should have been .9
<shadeslayer> oh
<shadeslayer> hm
<shadeslayer> fine, patch it
<apachelogger> otherwise they'd not have it backported to .8.5
<apachelogger> shadeslayer: u break it, you fix it :P

last function on each
4.8.2: http://quickgit.kde.org/?p=kde-workspace.git&a=blob&h=0fb2d38ae97351201fd36ff...

Read more...

Changed in kde-runtime (Ubuntu Precise):
importance: Undecided → Critical
affects: kde-runtime (Ubuntu) → kde-workspace (Ubuntu)
Changed in kde-workspace (Ubuntu):
status: New → Fix Released
summary: - plasma-desktop not running init script from k-d-s
+ 12.04 plasma init script order wrong
Changed in kde-workspace (Ubuntu Precise):
status: New → Triaged
tags: added: regression-update
Harald Sitter (apachelogger) wrote :

Not an issue in 4.9 or 4.10, marking fixed except for the Precise task. Also tagged as update-regression.

Changed in kde-workspace (Ubuntu Precise):
assignee: nobody → Rohan Garg (rohangarg)
Rohan Garg (rohangarg) on 2013-02-13
Changed in kde-workspace (Ubuntu Precise):
status: Triaged → In Progress
Jonathan Riddell (jr) wrote :
Jonathan Riddell (jr) wrote :

Uploading to precise-proposed for SRU

Hello lordievader, or anyone else affected,

Accepted kde-workspace into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/kde-workspace/4:4.8.5-0ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in kde-workspace (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Jonathan Riddell (jr) wrote :

Fix works great from ubuntu-proposed
I loaded up a 12.04.2 candidate image into the live system and saw it didn't load the right Plasma desktop layout. Then I added raring-proposed to sources.list and did a dist-upgrade. Then I added a new user and logged in with that user. It successfully loaded the kubuntu layout.

Rohan Garg (rohangarg) on 2013-02-13
tags: added: verification-done
removed: verification-needed

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Changed in kde-workspace (Ubuntu Precise):
milestone: none → ubuntu-12.04.2
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kde-workspace - 4:4.8.5-0ubuntu0.3

---------------
kde-workspace (4:4.8.5-0ubuntu0.3) precise-proposed; urgency=low

  * Add fix_plasma_init_order.diff from upstream to fix plasma init
    order LP: #1123126
 -- Rohan Garg <email address hidden> Wed, 13 Feb 2013 10:18:02 +0000

Changed in kde-workspace (Ubuntu Precise):
status: Fix Committed → Fix Released
Howard Chan (smartboyhw) wrote :

I confirm this bug has been fixed in the new Kubuntu Desktop amd64 ISO (20130214).

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers