json_gvariant_deserialize can fail due to unrelated code setting errno

Bug #1871023 reported by Robert Ancell
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
json-glib (Ubuntu)
Fix Released
High
Robert Ancell
Bionic
Fix Released
High
Robert Ancell
Eoan
Fix Released
High
Robert Ancell
Focal
Fix Released
High
Robert Ancell

Bug Description

[Impact]
json_gvariant_deserialize can fail due to unrelated code setting errno, this is causing snapd-glib to not be able to decode responses from snapd. Fixed in https://gitlab.gnome.org/GNOME/json-glib/-/merge_requests/22

[Test Case]
1. Run GNOME Software from the command line
2. Browse to postman

Expected result:
Errors are not shown on the command line

Observed result:
The following errors are shown on the command line:
05:17:29:0875 GLib g_variant_new_variant: assertion 'value != NULL' failed
05:17:29:0875 GLib g_variant_new_variant: assertion 'value != NULL' failed
05:17:29:0877 Gs not GsPlugin error g-io-error-quark:35: Invalid string value converting to GVariant
05:17:29:0877 Gs not handling error failed for action refine: Invalid string value converting to GVariant

(These errors may not always occur, and is likely racy).

[Regression Potential]
Small risk of introducing other bugs.

Changed in json-glib (Ubuntu Bionic):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in json-glib (Ubuntu Eoan):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in json-glib (Ubuntu Focal):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in json-glib (Ubuntu Focal):
status: New → Fix Committed
importance: Undecided → High
Changed in json-glib (Ubuntu Eoan):
importance: Undecided → High
Changed in json-glib (Ubuntu Bionic):
importance: Undecided → High
description: updated
Changed in json-glib (Ubuntu Eoan):
status: New → Fix Committed
Changed in json-glib (Ubuntu Bionic):
status: New → Fix Committed
Changed in json-glib (Ubuntu Bionic):
status: Fix Committed → In Progress
Changed in json-glib (Ubuntu Eoan):
status: Fix Committed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package json-glib - 1.4.4-2ubuntu2

---------------
json-glib (1.4.4-2ubuntu2) focal; urgency=medium

  * debian/patches/0001-json-gvariant-Stop-string-to-GVariant-conversion-fai.patch:
    - Fix JSON to GVariant conversion failing sometimes (LP: #1871023)

 -- Robert Ancell <email address hidden> Tue, 07 Apr 2020 09:50:05 +1200

Changed in json-glib (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted json-glib into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/json-glib/1.4.4-2ubuntu0.19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in json-glib (Ubuntu Eoan):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-eoan
Changed in json-glib (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Robert, or anyone else affected,

Accepted json-glib into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/json-glib/1.4.2-3ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (json-glib/1.4.4-2ubuntu0.19.10.1)

All autopkgtests for the newly accepted json-glib (1.4.4-2ubuntu0.19.10.1) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:

libgdata/0.17.11-3build1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/eoan/update_excuses.html#json-glib

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Confirmed fixed in Eoan with json-glib 1.4.4-2ubuntu0.19.10.1

tags: added: verification-done-eoan
removed: verification-needed-eoan
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Confirmed fixed in Bionic with json-glib 1.4.2-3ubuntu0.18.04.1

tags: added: verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for json-glib has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package json-glib - 1.4.2-3ubuntu0.18.04.1

---------------
json-glib (1.4.2-3ubuntu0.18.04.1) bionic; urgency=medium

  * debian/patches/0001-json-gvariant-Stop-string-to-GVariant-conversion-fai.patch:
    - Fix JSON to GVariant conversion failing sometimes (LP: #1871023)

 -- Robert Ancell <email address hidden> Tue, 07 Apr 2020 09:50:05 +1200

Changed in json-glib (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package json-glib - 1.4.4-2ubuntu0.19.10.1

---------------
json-glib (1.4.4-2ubuntu0.19.10.1) eoan; urgency=medium

  * debian/patches/0001-json-gvariant-Stop-string-to-GVariant-conversion-fai.patch:
    - Fix JSON to GVariant conversion failing sometimes (LP: #1871023)

 -- Robert Ancell <email address hidden> Tue, 07 Apr 2020 09:50:05 +1200

Changed in json-glib (Ubuntu Eoan):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.