jool-dkms FTBS with linux 6.2 on jammy

[Andrea Righi]

[Impact]

jool-dkms fails to build with linux 6.2 with the following errors:

/var/lib/dkms/jool-dkms/4.1.7/build/src/mod/common/nl/nl_handler.c:211:21: error: initialization of ‘int (*)(const struct genl_split_ops *, struct sk_buff *, struct genl_info *)’ from incompatible pointer type ‘int (*)(const struct genl_ops *, struct sk_buff *, struct genl_info *)’ [-Werror=incompatible-pointer-types]
  211 | .pre_doit = pre_handle_request,
      | ^~~~~~~~~~~~~~~~~~
/var/lib/dkms/jool-dkms/4.1.7/build/src/mod/common/nl/nl_handler.c:211:21: note: (near initialization for ‘jool_family.pre_doit’)
/var/lib/dkms/jool-dkms/4.1.7/build/src/mod/common/nl/nl_handler.c:212:22: error: initialization of ‘void (*)(const struct genl_split_ops *, struct sk_buff *, struct genl_info *)’ from incompatible pointer type ‘void (*)(const struct genl_ops *, struct sk_buff *, struct genl_info *)’ [-Werror=incompatible-pointer-types]
  212 | .post_doit = post_handle_request,
      | ^~~~~~~~~~~~~~~~~~~
/var/lib/dkms/jool-dkms/4.1.7/build/src/mod/common/nl/nl_handler.c:212:22: note: (near initialization for ‘jool_family.post_doit’)

[Test case]

 $ sudo apt install jool-dkms

With the fix applied:

 - release kernel 5.15:

Building for 5.15.0-77-generic
Building initial module for 5.15.0-77-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

jool_common.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-77-generic/updates/dkms/

 - hwe kernel 6.2:

Building for 6.2.0-25-generic
Building initial module for 6.2.0-25-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

jool_common.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.2.0-25-generic/updates/dkms/

[Fix]

Backport the right patches from lunar to support the new 6.2 kernel ABI.

[Regression potential]

Jool is an IP/ICMP translator, so with this change we may experience networking regressions in those systems that are using this dkms.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: jool-dkms 4.1.7-1
ProcVersionSignature: User Name 6.2.0-23.23~22.04.1-generic 6.2.12
Uname: Linux 6.2.0-23-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
Date: Sun Jun 11 17:00:15 2023
PackageArchitecture: all
SourcePackage: jool
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

debdiff to support linux 6.2 in jammy.

[Steve Langasek (vorlon)]

Hello Andrea, or anyone else affected,

Accepted jool into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/jool/4.1.7-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Alberto Leiva Popper (ydahhrk)]

Fixed in upstream 4.1.10, as well as Debian's 4.1.10-1. you might want to pull it.

[Andrea Righi (arighi)]

Verified on jammy and updated test plan with result. If upstream is also fixed we can resync with that next time. Thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package jool - 4.1.7-1ubuntu1

---------------
jool (4.1.7-1ubuntu1) jammy; urgency=medium

  * Support Linux 6.2 (LP: #2023489):
    - debian/patches/0001-Linux-6.2.patch

 -- Andrea Righi <email address hidden> Mon, 12 Jun 2023 07:32:23 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for jool has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.