quotation marks on jocky/ui.py:121-124 are wrong

Bug #910278 reported by Koichi Akabe on 2011-12-31
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
jockey (Ubuntu)
Undecided
Martin Pitt

Bug Description

I think the following codes on jocky/ui.py:121-124 are wrong.

Actual code:
----
self.error_message(self._('Cannot connect to D-BUS,"+\
    " please use the --no-dbus option as root to"+\
    " use jockey without it.'),
    str(e))
----

This code will print the following sentence:
----
Cannot connect to D-BUS,"+ " please use the --no-dbus option as root to"+ " use jockey without it.
----

Expected result is the following sentence:
----
Cannot connect to D-BUS, please use the --no-dbus option as root to use jockey without it.
----

Expected code:
----
self.error_message(self._('Cannot connect to D-BUS,'+\
    ' please use the --no-dbus option as root to'+\
    ' use jockey without it.'),
    str(e))
----

Martin Pitt (pitti) wrote :

Thanks! Fixed in trunk r780.

affects: jockey → jockey (Ubuntu)
Changed in jockey (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
status: New → Fix Committed
Martin Pitt (pitti) wrote :

This was fixed in 0.9.7-0ubuntu1 yesterday.

Changed in jockey (Ubuntu):
status: Fix Committed → Fix Released
Koichi Akabe (vbkaisetsu) wrote :

It is also wrong.
Translation template of jockey #34 is "Cannot connect to D-BUS," and the next words are removed.

I think that gettext can't process split strings.

Changed in jockey (Ubuntu):
status: Fix Released → Incomplete
Martin Pitt (pitti) wrote :

Fixed in trunk r791.

Changed in jockey (Ubuntu):
status: Incomplete → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jockey - 0.9.7-0ubuntu2

---------------
jockey (0.9.7-0ubuntu2) precise; urgency=low

  * Merge from trunk:
    - ui.py: Use gettext friendly string line splitting. (LP: #910278)
    - Update translations from Launchpad.
 -- Martin Pitt <email address hidden> Mon, 05 Mar 2012 06:48:41 +0100

Changed in jockey (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers