jockey-gtk crashed with bad character range

Bug #193521 reported by Harry Leitzell
14
Affects Status Importance Assigned to Milestone
jockey (Ubuntu)
Fix Released
Medium
Martin Pitt

Bug Description

Binary package hint: jockey-gtk

I'm going to go out on a limb here and say that info regarding my IBM workstation's dmi is not exactly what jockey-gtk was looking to find.

-( harry@gooble )- -( Tue Feb 19 05:26 PM )- -( 0 )-
(~) % jockey-gtk --debug
2008-02-19 17:30:43,454 DEBUG: reading modalias file /lib/modules/2.6.24-8-generic/modules.alias
2008-02-19 17:30:43,610 DEBUG: reading modalias file /usr/share/jockey/modaliases/disable-upstream-nvidia
2008-02-19 17:30:43,901 DEBUG: reading modalias file /usr/share/linux-restricted-modules/2.6.24-8-generic/modules.alias.override/ath_hal
2008-02-19 17:30:43,902 DEBUG: reading modalias file /usr/share/linux-restricted-modules/2.6.24-8-generic/modules.alias.override/fglrx
2008-02-19 17:30:43,920 DEBUG: reading modalias file /usr/share/linux-restricted-modules/2.6.24-8-generic/modules.alias.override/nvidia
2008-02-19 17:30:43,924 DEBUG: loading custom handler /usr/share/jockey/handlers/sl_modem.py
2008-02-19 17:30:43,955 DEBUG: Instantiated Handler subclass __builtin__.SlModem from name SlModem
2008-02-19 17:30:43,968 DEBUG: Software modem not available
2008-02-19 17:30:43,969 DEBUG: loading custom handler /usr/share/jockey/handlers/nvidia.py
2008-02-19 17:30:43,982 DEBUG: Instantiated Handler subclass __builtin__.NewNvidiaDriver from name NewNvidiaDriver
2008-02-19 17:30:44,080 DEBUG: NVIDIA accelerated graphics driver (latest cards) availability undetermined, adding to pool
2008-02-19 17:30:44,105 DEBUG: Instantiated Handler subclass __builtin__.NvidiaDriver from name NvidiaDriver
2008-02-19 17:30:44,151 DEBUG: NVIDIA accelerated graphics driver availability undetermined, adding to pool
2008-02-19 17:30:44,177 DEBUG: Instantiated Handler subclass __builtin__.LegacyNvidiaDriver from name LegacyNvidiaDriver
2008-02-19 17:30:44,223 DEBUG: NVIDIA accelerated graphics driver (legacy cards) availability undetermined, adding to pool
2008-02-19 17:30:44,223 DEBUG: loading custom handler /usr/share/jockey/handlers/b43.py
2008-02-19 17:30:44,291 DEBUG: Instantiated Handler subclass __builtin__.B43Handler from name B43Handler
2008-02-19 17:30:44,335 DEBUG: Broadcom B43 wireless driver availability undetermined, adding to pool
2008-02-19 17:30:44,336 DEBUG: loading custom handler /usr/share/jockey/handlers/fglrx.py
2008-02-19 17:30:44,366 DEBUG: Instantiated Handler subclass __builtin__.FglrxDriver from name FglrxDriver
2008-02-19 17:30:44,411 DEBUG: ATI accelerated graphics driver availability undetermined, adding to pool
2008-02-19 17:30:44,412 DEBUG: all custom handlers loaded
2008-02-19 17:30:44,934 DEBUG: querying driver db about HardwareID('modalias', 'pci:v00008086d0000255Dsv00001014sd00001014bc06sc00i00')
2008-02-19 17:30:49,997 DEBUG: no corresponding handler available
2008-02-19 17:30:49,998 DEBUG: no corresponding handler available
2008-02-19 17:30:49,998 DEBUG: querying driver db about HardwareID('modalias', 'pci:v000014E4d000016A6sv00001014sd0000027Bbc02sc00i00')
2008-02-19 17:30:50,225 DEBUG: no corresponding handler available
2008-02-19 17:30:50,225 DEBUG: querying driver db about HardwareID('modalias', 'pci:v00008086d000024C5sv00001014sd00001F00bc04sc01i00')
2008-02-19 17:30:50,446 DEBUG: no corresponding handler available
2008-02-19 17:30:50,463 DEBUG: querying driver db about HardwareID('modalias', 'pci:v00008086d000024C2sv00001014sd00001F00bc0Csc03i00')
2008-02-19 17:30:50,693 DEBUG: no corresponding handler available
2008-02-19 17:30:50,693 DEBUG: querying driver db about HardwareID('modalias', 'pci:v00008086d000024C4sv00001014sd00001F00bc0Csc03i00')
2008-02-19 17:30:50,914 DEBUG: no corresponding handler available
2008-02-19 17:30:50,914 DEBUG: querying driver db about HardwareID('modalias', 'pci:v000010DEd00000322sv00000000sd00000000bc03sc00i00')
2008-02-19 17:30:51,201 DEBUG: XorgDriverHandler(nvidia_new, nvidia-glx-new, nvidia): xorg.conf driver matches
2008-02-19 17:30:51,745 DEBUG: ModulePackageHandler(nvidia_new, nvidia-glx-new): module enabled: True, package installed: True
2008-02-19 17:30:51,791 DEBUG: XorgDriverHandler(nvidia_new, nvidia-glx-new, nvidia): xorg.conf driver matches
2008-02-19 17:30:52,345 DEBUG: ModulePackageHandler(nvidia_new, nvidia-glx-new): module enabled: True, package installed: True
2008-02-19 17:30:51,143 DEBUG: got handler NewNvidiaDriver([nvidia_new, nonfree, enabled] NVIDIA accelerated graphics driver (latest cards))
2008-02-19 17:30:52,346 DEBUG: no corresponding handler available
2008-02-19 17:30:52,346 DEBUG: querying driver db about HardwareID('modalias', 'platform:pcspkr')
2008-02-19 17:30:52,347 DEBUG: no corresponding handler available
2008-02-19 17:30:52,348 DEBUG: querying driver db about HardwareID('modalias', 'pci:v00001102d00007002sv00001102sd00000020bc09sc80i00')
2008-02-19 17:30:52,599 DEBUG: no corresponding handler available
2008-02-19 17:30:52,600 DEBUG: querying driver db about HardwareID('modalias', 'pci:v00008086d000024CBsv00001014sd00001F00bc01sc01i8a')
2008-02-19 17:30:52,829 DEBUG: no corresponding handler available
2008-02-19 17:30:52,829 DEBUG: no corresponding handler available
2008-02-19 17:30:52,830 DEBUG: no corresponding handler available
2008-02-19 17:30:52,830 DEBUG: querying driver db about HardwareID('modalias', 'platform:iTCO_wdt')
2008-02-19 17:30:52,847 DEBUG: querying driver db about HardwareID('modalias', 'usb:v0000p0000d0206dc09dsc00dp00ic09isc00ip00')
2008-02-19 17:30:56,837 DEBUG: no corresponding handler available
2008-02-19 17:30:56,837 DEBUG: no corresponding handler available
2008-02-19 17:30:56,837 DEBUG: querying driver db about HardwareID('modalias', 'usb:v0000p0000d0206dc09dsc00dp00ic09isc00ip00')
2008-02-19 17:30:57,005 DEBUG: no corresponding handler available
2008-02-19 17:30:57,023 DEBUG: no corresponding handler available
2008-02-19 17:30:57,023 DEBUG: querying driver db about HardwareID('modalias', 'usb:v0000p0000d0206dc09dsc00dp01ic09isc00ip00')
2008-02-19 17:30:57,178 DEBUG: no corresponding handler available
2008-02-19 17:30:57,178 DEBUG: no corresponding handler available
2008-02-19 17:30:57,178 DEBUG: querying driver db about HardwareID('modalias', 'pci:v00008086d000024CDsv00001014sd00001F00bc0Csc03i20')
2008-02-19 17:30:57,411 DEBUG: no corresponding handler available
2008-02-19 17:30:57,412 DEBUG: querying driver db about HardwareID('modalias', 'serio:ty01pr00id00ex00')
2008-02-19 17:30:57,481 DEBUG: no corresponding handler available
2008-02-19 17:30:57,482 DEBUG: no corresponding handler available
2008-02-19 17:30:57,482 DEBUG: querying driver db about HardwareID('modalias', 'input:b0010v001Fp0001e0100-e0,12,kramls1,2,fw')
2008-02-19 17:30:57,505 DEBUG: no corresponding handler available
2008-02-19 17:30:57,505 DEBUG: no corresponding handler available
2008-02-19 17:30:57,505 DEBUG: querying driver db about HardwareID('modalias', 'input:b0011v0001p0001eAB41-e0,1,4,11,14,k71,72,73,74,75,76,77,79,7A,7B,7C,7D,7E,7F,80,8C,8E,8F,9B,9C,9D,9E,9F,A3,A4,A5,A6,AC,AD,B7,B8,B9,D9,E2,ram4,l0,1,2,sfw')
2008-02-19 17:30:57,506 DEBUG: no corresponding handler available
2008-02-19 17:30:57,506 DEBUG: no corresponding handler available
2008-02-19 17:30:57,506 DEBUG: querying driver db about HardwareID('modalias', 'input:b0011v0002p0006e0000-e0,1,2,k110,111,112,113,114,r0,1,6,8,amlsfw')
2008-02-19 17:30:57,523 DEBUG: no corresponding handler available
2008-02-19 17:30:57,523 DEBUG: no corresponding handler available
2008-02-19 17:30:57,523 DEBUG: querying driver db about HardwareID('modalias', 'platform:eisa')
2008-02-19 17:30:57,524 DEBUG: querying driver db about HardwareID('modalias', 'platform:floppy')
2008-02-19 17:30:57,525 DEBUG: querying driver db about HardwareID('modalias', 'platform:bluetooth')
2008-02-19 17:30:57,525 DEBUG: querying driver db about HardwareID('modalias', 'dmi:bvnIBM:bvr-[M6E131AUS-1.31]-:bd07/20/2005:svnIBM:pn-[621912U]-:pvrIBMCORPORATION:rvnIBM:rn-[W51G]-:rvr-1:cvnN/A:ct6:cvrN/A:')
Traceback (most recent call last):
  File "/usr/bin/jockey-gtk", line 299, in <module>
    u = GtkUI()
  File "/usr/lib/python2.5/site-packages/jockey/ui.py", line 59, in __init__
    mode=self.argv_options.mode)
  File "/usr/lib/python2.5/site-packages/jockey/detection.py", line 409, in get_handlers
    for did in driverdb.query(hwid):
  File "/usr/lib/python2.5/site-packages/jockey/detection.py", line 183, in query
    if HardwareID('modalias', a) == hwid and mods:
  File "/usr/lib/python2.5/site-packages/jockey/detection.py", line 64, in __eq__
    return fnmatch(self.id, other.id)
  File "/usr/lib/python2.5/fnmatch.py", line 38, in fnmatch
    return fnmatchcase(name, pat)
  File "/usr/lib/python2.5/fnmatch.py", line 69, in fnmatchcase
    _cache[pat] = re.compile(res)
  File "/usr/lib/python2.5/re.py", line 180, in compile
    return _compile(pattern, flags)
  File "/usr/lib/python2.5/re.py", line 233, in _compile
    raise error, v # invalid expression
sre_constants.error: bad character range

Related branches

Changed in jockey:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Martin Pitt (pitti) wrote :

Indeed, fnmatch() does not cope with [ and ] characters in the pattern.

Changed in jockey:
assignee: nobody → pitti
status: Confirmed → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Note to self: I should use re.escape() and turn * into a regexp instead of using fnmatch.

Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in upstream trunk.

Changed in jockey:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jockey - 0.3-0ubuntu1

---------------
jockey (0.3-0ubuntu1) hardy; urgency=low

  * Merge with trunk to update to the 0.3 release. We already had all the new
    features like the KDE interface, so this only imports bug fixes, in
    particular:
    - Update fglrx handler for current upstream version, to actually work
      again at all (DisplayDepth) and declare support for composite. Thanks to
      Sander Jonkes! (LP: #194963)
    - Quiesce backtraces from failed handler instantiation. (LP: #195548)
    - Use regular expressions, not fnmatch for modalias pattern matching,
      since we do not want to treat '[' and ']' specially. (LP: #193521)
    - Port --enable and --disable options from restricted-manager.
      (LP: #181832)
    - Port --check-composite from restricted-manager. (LP: #193978)
  * Fixed Vcs-Bzr field.
  * Remove do-release from this branch, it's only useful for upstream
    developers on trunk and confusing in the package.
  * debian/jockey-common.postinst: Remove --check cache on upgrade from
    << 0.3, since the format changed (much more robust now).

 -- Martin Pitt <email address hidden> Tue, 04 Mar 2008 16:48:50 +0100

Changed in jockey:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.