jockey-gtk crashed with NameError in install_package()

[fromillo]

I sent a bug report because ubuntu asked me to do so...

ProblemType: Crash
Architecture: i386
Date: Wed Feb 6 15:23:25 2008
DistroRelease: Ubuntu 8.04
ExecutablePath: /usr/bin/jockey-gtk
InterpreterPath: /usr/bin/python2.5
NonfreeKernelModules: fglrx
Package: jockey-gtk 0.2-0ubuntu2
PackageArchitecture: all
ProcCmdline: /usr/bin/python /usr/bin/jockey-gtk
ProcCwd: /home/enrico
ProcEnviron:
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin
 LANG=C
 SHELL=/bin/bash
PythonArgs: ['/usr/bin/jockey-gtk']
SourcePackage: jockey
Title: jockey-gtk crashed with NameError in install_package()
Uname: Linux computer 2.6.24-5-generic #1 SMP Thu Jan 24 19:45:21 UTC 2008 i686 GNU/Linux
UserGroups:

[Apport retracing service (apport)]

This crash has the same stack trace characteristics as bug #186883. However, the latter was already fixed in an earlier package version than the one in this report. This might be a regression or because the problem is in a dependent package.

[Martin Pitt (pitti)]

I cannot reproduce this here, the code is fine now. Maybe the problem is a stale .pyc file.

 - What did you do when the crash happened?

 - Can you please copy&paste the output of the following Terminal command?

   ls -l /usr/lib/python2.5/site-packages/jockey/oslib*

Thank you!

[Martin Pitt (pitti)]

I still don't know how to reproduce this, it just works.

Do you still get the issue after

  sudo dpkg -P --force-depends jockey-common jockey-gtk
  sudo apt-get install jockey-gtk jockey-common

?

[Martin Pitt (pitti)]

(Background for my question: There were some problems with python-central recently, which have been fixed now.)

[hotani (hotani)]

This happens to me when attempting to enable a Broadcom wireless driver.

---
Traceback (most recent call last):
  File "/usr/bin/jockey-gtk", line 279, in on_handler_changed
    if self.toggle_handler(self.model[path][0]):
  File "/usr/lib/python2.5/site-packages/jockey/ui.py", line 483, in toggle_handler
    handler.enable()
  File "/usr/lib/python2.5/site-packages/jockey/handlers.py", line 679, in enable
    DriverPackageHandler.enable(self)
  File "/usr/lib/python2.5/site-packages/jockey/handlers.py", line 596, in enable
    self.ui.install_package(self.package)
  File "/usr/lib/python2.5/site-packages/jockey/ui.py", line 493, in install_package
    oslib.OSLib.inst.install_package(package, self)
  File "/usr/lib/python2.5/site-packages/jockey/oslib.py", line 186, in install_package
    env.update(os.environ)
NameError: global name 'env' is not defined

[Nobu (benjo316)]

Happened to me when trying to enable nvidia drivers via "Hardware Drivers" in Ubuntu Hardy.
This is after a clean install of 7.10 then an upgrade immediately to 8.04.

>super@nobu-desktop:~$ ls -l /usr/lib/python2.5/site-packages/jockey/oslib*
>-rw-r--r-- 1 root root 15251 2008-04-03 11:16 /usr/lib/python2.5/site-packages/jockey/oslib.py
>-rw-r--r-- 1 root root 13952 2008-04-03 16:32 /usr/lib/python2.5/site-packages/jockey/oslib.pyc
(before dpkg/apt-get commands suggested by Martin Pitt)

Problem persists after dpkg/apt-get commands...
>super@nobu-desktop:~$ ls -l /usr/lib/python2.5/site-packages/jockey/oslib*
>-rw-r--r-- 1 root root 15251 2008-04-03 11:16 /usr/lib/python2.5/site-packages/jockey/oslib.py
>-rw-r--r-- 1 root root 13952 2008-04-03 18:36 /usr/lib/python2.5/site-packages/jockey/oslib.pyc

The included crash report file is probably from trying to remove the drivers, since I installed them via aptitude after "Hardware Drivers" failed, though I think it should help none the less.

[The Outfield (outfield)]

I think I found a fix!

I took the file /usr/lib/python2.5/site-packages/jockey/oslib.py from my other installation (hardy-upgraded Gutsy) and replaced the one on my 64-bit hardy, restarted jockey and installed ok.

Only problem was that when I logged in the taskbar icon reported a jockey error. Despite this, the driver works just fine.

If anyone wants to try my oslib.py, here it is.

[Martin Pitt (pitti)]

Ah, silly me. I just fixed the "env" problem.

[Launchpad Janitor (janitor)]

This bug was fixed in the package jockey - 0.3.3-0ubuntu5

---------------
jockey (0.3.3-0ubuntu5) hardy; urgency=low

  * jockey/oslib.py: Fix undeclared 'env' variable, residue from fix in
    0.3.3-0ubuntu3. (LP: #189611)

 -- Martin Pitt <email address hidden> Fri, 04 Apr 2008 09:16:08 +0200