Jack_control in jackd2 1.9.14 will not accept char parameters

Bug #1899349 reported by Len Ovens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
jackd2 (Ubuntu)
Fix Released
High
Unassigned

Bug Description

trying to set self-connect-mode (for example):
$ jack_control eps self-connect-mode e
gives:
--- engine param set "self-connect-mode" -> "e"
Traceback (most recent call last):
  File "/usr/bin/jack_control", line 400, in <module>
    main()
  File "/usr/bin/jack_control", line 283, in main
    configure_iface.SetParameterValue(['engine', param], python_type_to_jackdbus_type(value, type_char))
  File "/usr/bin/jack_control", line 46, in python_type_to_jackdbus_type
    return dbus.Byte(value);
TypeError: Expected a bytes or str of length 1, or an int in the range 0-255

This bug has been fixed upstream in commit ba28ffa

@@ -43,7 +43,7 @@ def python_type_to_jackdbus_type(value, type_char):
    if type_char == "b":
        return bool_convert(value);
    elif type_char == "y":
- return dbus.Byte(value);
+ return dbus.Byte(ord(value));
    elif type_char == "i":
        return dbus.Int32(value)
    elif type_char == "u":

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report and patch, I'm going to upload that to the current Ubuntu serie, unsure it qualifies for a stable update though since it's only a fix to an example utility

Changed in jackd2 (Ubuntu):
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Erich Eickmeyer (eeickmeyer) wrote :

Sebastien,

Example utility or not, this is something that is used by studio-controls for controlling Jack. Whether or not it was intended to be an example utility is irrellevant. If you don't have the time to fix this and upload, I'll do it.

Changed in jackd2 (Ubuntu):
importance: Low → High
Revision history for this message
Erich Eickmeyer (eeickmeyer) wrote :

Sebastien,

My apologies, I saw you uploaded. Pretty sure this will be accepted for the Groovy cycle since we're not at final freeze yet.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jackd2 - 1.9.14-0ubuntu3.1

---------------
jackd2 (1.9.14-0ubuntu3.1) groovy; urgency=medium

  * debian/patches/git_dbus_bytes.patch:
    - Fix jack_control handling of dbus bytes, thanks Len
      (lp: #1899349)

 -- Sebastien Bacher <email address hidden> Wed, 14 Oct 2020 09:59:30 +0200

Changed in jackd2 (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.