iscsi target not DKMS compiling for kernel 4.4.0-57

[ilemur]

Reading package lists... Done
Building dependency tree
Reading state information... Done
The following extra packages will be installed:
  dkms fakeroot libfakeroot
Suggested packages:
  dpkg-dev debhelper iscsitarget
The following NEW packages will be installed:
  dkms fakeroot iscsitarget-dkms libfakeroot
0 upgraded, 4 newly installed, 0 to remove and 0 not upgraded.
Need to get 146 kB/210 kB of archives.
After this operation, 1,139 kB of additional disk space will be used.
Preparing to unpack .../dkms_2.2.0.3-1.1ubuntu5.14.04.9_all.deb ...
Unpacking dkms (2.2.0.3-1.1ubuntu5.14.04.9) ...
Selecting previously unselected package libfakeroot:amd64.
Preparing to unpack .../libfakeroot_1.20-3ubuntu2_amd64.deb ...
Unpacking libfakeroot:amd64 (1.20-3ubuntu2) ...
Selecting previously unselected package fakeroot.
Preparing to unpack .../fakeroot_1.20-3ubuntu2_amd64.deb ...
Unpacking fakeroot (1.20-3ubuntu2) ...
Selecting previously unselected package iscsitarget-dkms.
Preparing to unpack .../iscsitarget-dkms_1.4.20.3+svn499-0ubuntu2.1_all.deb ...
Unpacking iscsitarget-dkms (1.4.20.3+svn499-0ubuntu2.1) ...
Processing triggers for man-db (2.6.7.1-1ubuntu1) ...
Setting up dkms (2.2.0.3-1.1ubuntu5.14.04.9) ...
Setting up libfakeroot:amd64 (1.20-3ubuntu2) ...
Setting up fakeroot (1.20-3ubuntu2) ...
update-alternatives: using /usr/bin/fakeroot-sysv to provide /usr/bin/fakeroot (fakeroot) in auto mode
Setting up iscsitarget-dkms (1.4.20.3+svn499-0ubuntu2.1) ...

Creating symlink /var/lib/dkms/iscsitarget/1.4.20.3+svn499/source ->
                 /usr/src/iscsitarget-1.4.20.3+svn499

DKMS: add completed.

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area....
make KERNELRELEASE=4.4.0-57-generic -C /lib/modules/4.4.0-57-generic/build M=/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build........(bad exit status: 2)
ERROR: Cannot create report: [Errno 17] File exists: '/var/crash/iscsitarget-dkms.0.crash'
Error! Bad return status for module build on kernel: 4.4.0-57-generic (x86_64)
Consult /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/make.log for more information.

#cat /var/crash/iscsitarget-dkms.0.crash

ProblemType: Package
DKMSBuildLog:
 DKMS make.log for iscsitarget-1.4.20.3+svn499 for kernel 4.4.0-57-generic (x86_64)
 Tue Jan 3 11:33:44 MSK 2017
 make: Entering directory `/usr/src/linux-headers-4.4.0-57-generic'
   LD /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/built-in.o
   LD /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/built-in.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/tio.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/iscsi.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.o
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.c: In function ‘forward_iov’:
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.c:94:6: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default]
   iov = msg->msg_iter.iov;
       ^
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.c: In function ‘close_conn’:
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.c:676:32: warning: assignment from incompatible pointer type [enabled by default]
   conn->sock->sk->sk_data_ready = target->nthread_info.old_data_ready;
                                 ^
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.c: In function ‘do_recv’:
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/nthread.c:154:1: warning: the frame size of 1128 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  }
  ^
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/wthread.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/config.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/digest.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/conn.o
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/conn.c: In function ‘iet_socket_bind’:
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/conn.c:137:38: warning: assignment from incompatible pointer type [enabled by default]
   target->nthread_info.old_data_ready = conn->sock->sk->sk_data_ready;
                                       ^
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/conn.c:138:32: warning: assignment from incompatible pointer type [enabled by default]
   conn->sock->sk->sk_data_ready = iet_data_ready;
                                 ^
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/session.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/target.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/volume.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/iotype.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/file-io.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/null-io.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/target_disk.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/event.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/param.o
   CC [M] /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.o
 In file included from include/linux/bitops.h:36:0,
                  from include/linux/kernel.h:10,
                  from include/linux/sched.h:17,
                  from include/linux/blkdev.h:4,
                  from /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:13:
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c: In function ‘blockio_bio_endio’:
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:36:19: error: ‘BIO_UPTODATE’ undeclared (first use in this function)
   error = test_bit(BIO_UPTODATE, &bio->bi_flags) ? error : -EIO;
                    ^
 ./arch/x86/include/asm/bitops.h:336:25: note: in definition of macro ‘test_bit’
   (__builtin_constant_p((nr)) \
                          ^
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:36:19: note: each undeclared identifier is reported only once for each function it appears in
   error = test_bit(BIO_UPTODATE, &bio->bi_flags) ? error : -EIO;
                    ^
 ./arch/x86/include/asm/bitops.h:336:25: note: in definition of macro ‘test_bit’
   (__builtin_constant_p((nr)) \
                          ^
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:36:2: warning: passing argument 2 of ‘constant_test_bit’ from incompatible pointer type [enabled by default]
   error = test_bit(BIO_UPTODATE, &bio->bi_flags) ? error : -EIO;
   ^
 In file included from include/linux/bitops.h:36:0,
                  from include/linux/kernel.h:10,
                  from include/linux/sched.h:17,
                  from include/linux/blkdev.h:4,
                  from /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:13:
 ./arch/x86/include/asm/bitops.h:308:28: note: expected ‘const volatile long unsigned int *’ but argument is of type ‘unsigned int *’
  static __always_inline int constant_test_bit(long nr, const volatile unsigned long *addr)
                             ^
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:36:2: warning: passing argument 2 of ‘variable_test_bit’ from incompatible pointer type [enabled by default]
   error = test_bit(BIO_UPTODATE, &bio->bi_flags) ? error : -EIO;
   ^
 In file included from include/linux/bitops.h:36:0,
                  from include/linux/kernel.h:10,
                  from include/linux/sched.h:17,
                  from include/linux/blkdev.h:4,
                  from /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:13:
 ./arch/x86/include/asm/bitops.h:314:19: note: expected ‘const volatile long unsigned int *’ but argument is of type ‘unsigned int *’
  static inline int variable_test_bit(long nr, volatile const unsigned long *addr)
                    ^
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c: In function ‘blockio_make_request’:
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:71:3: error: implicit declaration of function ‘bio_get_nr_vecs’ [-Werror=implicit-function-declaration]
    max_pages = bio_get_nr_vecs(bio_data->bdev);
    ^
 /var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:92:18: warning: assignment from incompatible pointer type [enabled by default]
    bio->bi_end_io = blockio_bio_endio;
                   ^
 cc1: some warnings being treated as errors
 make[2]: *** [/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.o] Error 1
 make[1]: *** [/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel] Error 2
 make: *** [_module_/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build] Error 2
 make: Leaving directory `/usr/src/linux-headers-4.4.0-57-generic'
DKMSKernelVersion: 4.4.0-57-generic
Date: Tue Jan 3 11:34:06 2017
DuplicateSignature: dkms:iscsitarget-dkms:1.4.20.3+svn499-0ubuntu2.1:/var/lib/dkms/iscsitarget/1.4.20.3+svn499/build/kernel/block-io.c:36:19: error: ‘BIO_UPTODATE’ undeclared (first use in this function)
Package: iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.1
PackageVersion: 1.4.20.3+svn499-0ubuntu2.1
SourcePackage: iscsitarget
Title: iscsitarget-dkms 1.4.20.3+svn499-0ubuntu2.1: iscsitarget kernel module failed to build

[Christian Ehrhardt  (paelzer)]

This was dropped >=Yakkety so not showing up there.

The last build of the package itself is from Nov 6 18:17:28 UTC 2015
https://launchpadlibrarian.net/227560295/buildlog_ubuntu-xenial-amd64.iscsitarget_1.4.20.3+svn502-2ubuntu4_BUILDING.txt.gz

It has patches to work with new kernels up until 4.3
./usr/src/iscsitarget-1.4.20.3+svn502/patches/compat-4.3.patch

[Christian Ehrhardt  (paelzer)]

The bug here is about the dkms build that fails.

[Christian Ehrhardt  (paelzer)]

Confirmed for latest 4.4.0-64-generic

The issue I get with that is slightly different thou:
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/make.log => http://paste.ubuntu.com/24083367/
/var/crash/iscsitarget-dkms.0.crash => http://paste.ubuntu.com/24083366/

Since the last compat patches came from the kernel Team I'm adding a kernel bug task for them to trigage as well.

[Brad Figg (brad-figg)]

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1654011

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Christian Ehrhardt  (paelzer)]

Hmm,
it seems this can happen due to out-of-date kernels.
E.g. running kernel vs installed kernel (headers).

I was able to resolve for myself by installing the latest kernel headers and reinstalling.

$ apt-get install linux-headers-4.4.0-64-generic
# then to trigger all the DKMS again
$ apt-get install --reinstall iscsitarget-dkms

Full build of all modules http://paste.ubuntu.com/24083415/

In my case I had a outdated lxd guest (4.4-0.63) and a host running 4.4-0.64 already.
That caused my mismatch

Is your current kernel matching the installed headers?
$ dpkg -l '*linux*head*'
$ uname -r

Since it is DKMS actually have you headers for all installed kernels (maybe time to clean up some)? Are all kernels or just one failing?