init/irqbalance should support $OPTIONS
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
irqbalance (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Trusty |
Fix Released
|
Medium
|
Unassigned |
Bug Description
[SRU justification]
Without this modification, adding an $OPTIONS variable in /etc/default/
[Impact]
Impossibility to add startup options using $OPTIONS
[Fix]
Add $OPTIONS to the upstart script similar to what is used in the SysV script
[Test Case]
Run the following script :
#!/bin/bash
apt-get update && apt-get -y install irqbalance
cat << EOF >> /etc/default/
OPTIONS=
EOF
restart irqbalance
Return=$(ps aux | grep irqbalance | grep -v grep | grep hintpolicy)
if [[ -z $Return ]];then
# Test fails : $OPTIONS not taken into account
echo "Test Failed"
exit -1
else
echo "Test Succeeded"
exit 0
fi
[Regression]
Risk of irqbalance not starting if invalid option were present in /etc/default/
[Original description of the problem]
/etc/init.
/etc/init/
Usage example to workaround #1321425
/etc/default/
OPTIONS=
Changed in irqbalance (Ubuntu): | |
status: | Confirmed → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Louis Bouchard (louis-bouchard) |
Changed in irqbalance (Ubuntu Trusty): | |
status: | New → Confirmed |
assignee: | nobody → Louis Bouchard (louis-bouchard) |
importance: | Undecided → Medium |
description: | updated |
Changed in irqbalance (Ubuntu Trusty): | |
status: | Confirmed → In Progress |
Changed in irqbalance (Ubuntu): | |
assignee: | Louis Bouchard (louis-bouchard) → nobody |
Changed in irqbalance (Ubuntu Trusty): | |
assignee: | Louis Bouchard (louis-bouchard) → nobody |
Attaching a simple /etc/init/ irqbalance. conf patch