init/irqbalance should support $OPTIONS

Bug #1328556 reported by Grant Slater on 2014-06-10
32
This bug affects 5 people
Affects Status Importance Assigned to Milestone
irqbalance (Ubuntu)
Medium
Unassigned
Trusty
Medium
Unassigned

Bug Description

[SRU justification]
Without this modification, adding an $OPTIONS variable in /etc/default/irqbalance is useless.

[Impact]
Impossibility to add startup options using $OPTIONS

[Fix]
Add $OPTIONS to the upstart script similar to what is used in the SysV script

[Test Case]
Run the following script :

#!/bin/bash

apt-get update && apt-get -y install irqbalance

cat << EOF >> /etc/default/irqbalance
OPTIONS="--hintpolicy=ignore"
EOF

restart irqbalance

Return=$(ps aux | grep irqbalance | grep -v grep | grep hintpolicy)

if [[ -z $Return ]];then
   # Test fails : $OPTIONS not taken into account
   echo "Test Failed"
   exit -1
else
   echo "Test Succeeded"
   exit 0
fi

[Regression]
Risk of irqbalance not starting if invalid option were present in /etc/default/irqbalance previously

[Original description of the problem]

/etc/init.d/irqbalance supports setting an $OPTIONS variable to pass parameters to the irqbalance daemon

/etc/init/irqbalance should also support an $OPTIONS variable.

Usage example to workaround #1321425
/etc/default/irqbalance
OPTIONS="--hintpolicy=ignore"

Grant Slater (firefishy) wrote :

Attaching a simple /etc/init/irqbalance.conf patch

description: updated

The attachment "etc-init-irqbalance.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in irqbalance (Ubuntu):
status: New → Confirmed
Ed Taylor (edward-taylor-m) wrote :

Confirmed patch solves problem.

Louis Bouchard (louis) on 2014-08-21
Changed in irqbalance (Ubuntu):
status: Confirmed → In Progress
importance: Undecided → Medium
assignee: nobody → Louis Bouchard (louis-bouchard)
Changed in irqbalance (Ubuntu Trusty):
status: New → Confirmed
assignee: nobody → Louis Bouchard (louis-bouchard)
importance: Undecided → Medium
Louis Bouchard (louis) wrote :

Modification to fix this issue in both Trusty & Utopic

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package irqbalance - 1.0.6-2ubuntu1

---------------
irqbalance (1.0.6-2ubuntu1) utopic; urgency=medium

  * Add support for the $OPTIONS configuration variable in the
    upstart script (LP: #1328556)
 -- Louis Bouchard <email address hidden> Thu, 21 Aug 2014 10:32:23 -0500

Changed in irqbalance (Ubuntu):
status: In Progress → Fix Released
Louis Bouchard (louis) on 2014-08-22
description: updated
Louis Bouchard (louis) wrote :

debdiff for Trusty's SRU

Louis Bouchard (louis) on 2014-08-25
Changed in irqbalance (Ubuntu Trusty):
status: Confirmed → In Progress
Chris J Arges (arges) wrote :

Louis,
Can you make the vesrion 1.0.6-2ubuntu0.14.04.1 instead of ubuntu1.14.04.1, the version string you introduced is > the utopic version. Please re-upload with that fix.

Hello Grant, or anyone else affected,

Accepted irqbalance into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/irqbalance/1.0.6-2ubuntu0.14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in irqbalance (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Louis Bouchard (louis) wrote :

Verification done OK with test script in SRU for Trusty

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package irqbalance - 1.0.6-2ubuntu0.14.04.1

---------------
irqbalance (1.0.6-2ubuntu0.14.04.1) trusty-proposed; urgency=medium

  * Add support for the $OPTIONS configuration variable in the
    upstart script (LP: #1328556)
 -- Louis Bouchard <email address hidden> Thu, 21 Aug 2014 15:49:54 +0200

Changed in irqbalance (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for irqbalance has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Louis Bouchard (louis) on 2014-09-04
Changed in irqbalance (Ubuntu):
assignee: Louis Bouchard (louis-bouchard) → nobody
Changed in irqbalance (Ubuntu Trusty):
assignee: Louis Bouchard (louis-bouchard) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers