ipyparallel ftbfs with Python 3.12 as default

[Chris Peterson]

Imported from Debian bug http://bugs.debian.org/1061744:

Package: src:ipyparallel
Version: 7.1.0-5
Severity: serious
Tags: sid trixie ftbfs
User: <email address hidden>
Usertags: python3.12

With python3-defaults from experimental, the package fails to build:

[...]
=================================== FAILURES
===================================
_____________________________ test_disambiguate_ip
_____________________________

warn_mock = <MagicMock name='warn' id='140702045868912'>

     @mock.patch('warnings.warn')
     def test_disambiguate_ip(warn_mock):
         # garbage in, garbage out
         assert util.disambiguate_ip_address('garbage') == 'garbage'
         assert util.disambiguate_ip_address('0.0.0.0',
socket.gethostname()) == localhost()
         wontresolve = 'this.wontresolve.dns'
         assert util.disambiguate_ip_address('0.0.0.0', wontresolve) ==
wontresolve
         assert warn_mock.called_once_with(
             'IPython could not determine IPs for {}: '
             '[Errno -2] Name or service not known'.format(wontresolve),
             RuntimeWarning,
 > )

ipyparallel/tests/test_util.py:21:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _

self = <MagicMock name='warn' id='140702045868912'>, name =
'called_once_with'

     def __getattr__(self, name):
         if name in {'_mock_methods', '_mock_unsafe'}:
             raise AttributeError(name)
         elif self._mock_methods is not None:
             if name not in self._mock_methods or name in _all_magics:
                 raise AttributeError("Mock object has no attribute %r"
% name)
         elif _is_magic(name):
             raise AttributeError(name)
         if not self._mock_unsafe and (not self._mock_methods or name
not in self._mock_methods):
             if name.startswith(('assert', 'assret', 'asert', 'aseert',
'assrt')) or name in _ATTRIB_DENY_LIST:
 > raise AttributeError(
                     f"{name!r} is not a valid assertion. Use a spec "
                     f"for the mock if {name!r} is meant to be an
attribute.")
E AttributeError: 'called_once_with' is not a valid
assertion. Use a spec for the mock if 'called_once_with' is meant to be
an attribute.. Did you mean: 'assert_called_once_with'?

/usr/lib/python3.12/unittest/mock.py:663: AttributeError

[Chris Peterson (cpete)]

Patch attached. Seemingly only one instance of this issue.

Now passing autopkgtests: https://autopkgtest.ubuntu.com/results/autopkgtest-noble-cpete-ipyparallel/noble/amd64/i/ipyparallel/20240209_042815_6addc@/log.gz

[Graham Inggs (ginggs)]

It looks like there's a typo in your patch, not sure how it passed:

+- assert warn_mock.called_once_with(
++ warn_mock.asset_called_once_with(

I guess that should be "assert_called_once_with".

I noticed your test was run with:

324s ============================= test session starts ==============================
324s platform linux -- Python 3.11.7, pytest-7.4.4, pluggy-1.3.0
324s rootdir: /usr/lib/python3/dist-packages/ipyparallel

For fixes involving a transition, I usually trigger the autopkgtests twice, the second time with &all-proposed=1. I did so in your PPA, and it still passed, with:

276s ============================= test session starts ==============================
276s platform linux -- Python 3.12.2, pytest-7.4.4, pluggy-1.4.0
276s rootdir: /usr/lib/python3/dist-packages/ipyparallel

https://autopkgtest.ubuntu.com/results/autopkgtest-noble-cpete-ipyparallel/noble/amd64/i/ipyparallel/20240209_075236_45a54@/log.gz

[Graham Inggs (ginggs)]

I tested in my own PPA with the typo fixed, and it still passes with Python 3.11 and 3.12. So will upload that.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ipyparallel - 7.1.0-5ubuntu1

---------------
ipyparallel (7.1.0-5ubuntu1) noble; urgency=medium

  * Fix tests for python3.12 (LP: #2052727)

 -- Chris Peterson <email address hidden> Thu, 08 Feb 2024 10:44:16 -0800

[Chris Peterson (cpete)]

Thanks for catching that! Usually my work flow is to make the functional changes and test in a ppa and then edit the headers and do a source build once it's ready to go. I must've typo'd that in the process but I'm not sure how.

Also good note about the autopkgtest triggers.

Anyways, thanks for the sponsor!

[Graham Inggs (ginggs)]

You are welcome!

What I find really weird is that your PPA upload has the same typo, yet the tests passed there.

[Chris Peterson (cpete)]

Hah. Fixed a typo which passed with the same issue as before:

>>> from unittest import mock
>>> my_mock = mock.Mock()
>>> bool(my_mock.asset_called_once_with())
True

mocks objects evaluate to true!