seen in the second focal test rebuild
https://launchpadlibrarian.net/471776606/buildlog_ubuntu-focal-amd64.ipxe-qemu-256k-compat_1.0.0+git-20150424.a25a16d-0ubuntu3_BUILDING.txt.gz
ar: creating bin-x86_64-efi/blib.a
util/elf2efi.c: In function ‘process_section’:
util/elf2efi.c:337:24: warning: implicit declaration of function ‘bfd_get_section_flags’; did you mean ‘bfd_set_section_flags’? [-Wimplicit-function-declaration]
337 | unsigned long flags = bfd_get_section_flags ( bfd, section );
| ^~~~~~~~~~~~~~~~~~~~~
| bfd_set_section_flags
util/elf2efi.c:362:37: warning: passing argument 1 of ‘bfd_section_size’ from incompatible pointer type [-Wincompatible-pointer-types]
362 | section_memsz = bfd_section_size ( bfd, section );
| ^~~
| |
| bfd * {aka struct bfd *}
In file included from util/elf2efi.c:32:
/usr/include/bfd.h:1206:35: note: expected ‘const asection *’ {aka ‘const struct bfd_section *’} but argument is of type ‘bfd *’ {aka ‘struct bfd *’}
1206 | bfd_section_size (const asection *sec)
| ~~~~~~~~~~~~~~~~^~~
util/elf2efi.c:362:18: error: too many arguments to function ‘bfd_section_size’
362 | section_memsz = bfd_section_size ( bfd, section );
| ^~~~~~~~~~~~~~~~
In file included from util/elf2efi.c:32:
/usr/include/bfd.h:1206:1: note: declared here
1206 | bfd_section_size (const asection *sec)
| ^~~~~~~~~~~~~~~~
util/elf2efi.c:372:28: warning: implicit declaration of function ‘bfd_get_section_vma’; did you mean ‘bfd_set_section_vma’? [-Wimplicit-function-declaration]
372 | new->hdr.VirtualAddress = bfd_get_section_vma ( bfd, section );
| ^~~~~~~~~~~~~~~~~~~
| bfd_set_section_vma
make[2]: *** [Makefile.housekeeping:1314: util/elf2efi64] Error 1
make[2]: *** Waiting for unfinished jobs....
ranlib bin-x86_64-efi/blib.a
rm bin-x86_64-efi/version.82540em.efidrv.o
make[2]: Leaving directory '/<<BUILDDIR>>/ipxe-qemu-256k-compat-1.0.0+git-20150424.a25a16d/src'
dh_auto_build: error: cd src && make -j4 V=1 NO_WERROR=1 VERSION=1.0.0\+git-20150424.a25a16d-0ubuntu3 bin-x86_64-efi/82540em.efirom returned exit code 2
make[1]: *** [debian/rules:18: src/bin-x86_64-efi/82540em.efirom] Error 25
We are using a rather old upstream snapshot of ipxe: commit a25a16d dates back to April 2015. I guess this is because upstream didn't tag any release between 2010 and January 2, 2020, when version v1.20.1 was tagged.
The FTBFS does not happen with the latest upstream version, as the use of bfd has been dropped in 2016 by this commit:
https:/
While that's the commit fixing (actually, removing) the issue, I would not consider this "patch on a table" scenario, as at that point the codebase already diverged significantly from what we have in Ubuntu, plus it's difficult to tell what the code status was at that arbitrary point of the commit history.
It would be nice to ship v1.20.1 in Focal, but we are late in the cycle. The attached patch fixes the issue according to:
https:/