Don't report persistentconns as activeconns

Bug #663564 reported by andrew bezella on 2010-10-19
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ipvsadm (Debian)
Fix Released
Unknown
ipvsadm (Ubuntu)
Medium
Unassigned
Lucid
Medium
Clint Byrum

Bug Description

Binary package hint: ipvsadm

Description: Ubuntu 10.04.1 LTS
Release: 10.04

ipvsadm:
  Installed: 1:1.25.clean-1
  Candidate: 1:1.25.clean-1
  Version table:
 *** 1:1.25.clean-1 0
        500 http://apt-mirror1.us.archive.org/ubuntu/ lucid/main Packages
        100 /var/lib/dpkg/status

there is "what appears to be a typo in the netlink client code whereby the activeconns is read as activeconns and then overwritten by persistentconns. The result is that the active connection count reported by ipvsadm -L is wrong if the code is compiled to use the netlink interface." (description taken from http://archive.linuxvirtualserver.org/html/lvs-devel/2010-02/msg00006.html)

the attached patch is taken from https://bugzilla.redhat.com/show_bug.cgi?id=573921 (the same patch as from the lvs-devel link but with unmangled whitespace)

== SRU REPORT ==

=== IMPACT ===

This patch is extremely straight forward and only affects the reporting code, so risk of crash/security problems are low. If somebody has built a workaround for the lack of active connection reporting, or if they have been assuming that the number was lower/0, the update reporting accurate numbers may cause some confusion, but that should be easy to correlate with the system updates.

=== DEV FIX ===

The code was patched and uploaded to natty in version 1:1.25.clean-1ubuntu1

=== PATCH ===

See merge proposal.

=== TEST CASE: ===

From redhat bug report:

Steps to Reproduce:
1. Create an IPVS virtual service, something along these lines:
   ipvsadm -A -t this.host.ip:80
   ipvsadm -a -t this.host.ip:80 -r other.host.ip:80 -m
   (and set up the HTTP server on other.host.ip).
2. from different host run "telnet this.host.ip 80"
3. run /sbin/ipvsadm -L

Actual results:
The "ActiveConn" column is zero even though there is an open connection.

Expected results:
The "ActiveConn" column should be greater than zero.

=== REGRESSION POTENTIAL ===

Very low. See IMPACT.

Related branches

andrew bezella (abezella) wrote :
Thierry Carrez (ttx) on 2010-10-20
Changed in ipvsadm (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Changed in ipvsadm (Ubuntu Lucid):
importance: Undecided → Medium
status: New → Triaged
tags: added: patch
Changed in ipvsadm (Ubuntu):
assignee: nobody → Clint Byrum (clint-fewbar)
status: Triaged → In Progress
Changed in ipvsadm (Debian):
status: Unknown → New
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ipvsadm - 1:1.25.clean-1ubuntu1

---------------
ipvsadm (1:1.25.clean-1ubuntu1) natty; urgency=low

  * libipvs/libipvs.c: upstream patch (r64) to fix incorrect activeconns,
    (Debian bug 574587), (LP: #663564)
 -- Clint Byrum <email address hidden> Tue, 16 Nov 2010 15:25:39 -0800

Changed in ipvsadm (Ubuntu):
status: In Progress → Fix Released
description: updated
Changed in ipvsadm (Ubuntu):
assignee: Clint Byrum (clint-fewbar) → nobody
Changed in ipvsadm (Ubuntu Lucid):
assignee: nobody → Clint Byrum (clint-fewbar)
status: Triaged → In Progress
Martin Pitt (pitti) wrote :

The patch looks fine, but the lucid SRU has an invalid version number. Not only is "1:1.25.clean-1.1" not "Ubuntu"ish, but it is also bigger than the current natty version 1:1.25.clean-1ubuntu1. Please call it "1:1.25.clean-1ubuntu0.1" and reupload.

Clint Byrum (clint-fewbar) wrote :

Ahh, that make sense Martin. Thanks for the guidance.

I've pushed that version up to the merge-proposed branch.

Dustin Kirkland  (kirkland) wrote :

Sponsored/uploaded to proposed. Thanks!

Changed in ipvsadm (Ubuntu Lucid):
status: In Progress → Fix Committed

Accepted ipvsadm into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Imre Gergely (cemc) wrote :

root@utest-lls32:~# apt-cache policy ipvsadm
ipvsadm:
  Installed: 1:1.25.clean-1ubuntu0.1
  Candidate: 1:1.25.clean-1ubuntu0.1
  Version table:
 *** 1:1.25.clean-1ubuntu0.1 0
        500 http://ro.archive.ubuntu.com/ubuntu/ lucid-proposed/main Packages
        100 /var/lib/dpkg/status
     1:1.25.clean-1 0
        500 http://ro.archive.ubuntu.com/ubuntu/ lucid/main Packages

Tested and working as per test case.

root@utest-lls32:~# ipvsadm -L
IP Virtual Server version 1.2.1 (size=4096)
Prot LocalAddress:Port Scheduler Flags
  -> RemoteAddress:Port Forward Weight ActiveConn InActConn
TCP utest-lls32.narancs.net:www wlc
  -> utest-hhs32.narancs.net:www Masq 1 1 0

Clint Byrum (clint-fewbar) wrote :

SRU team.. bump.. Imre seems to have done the verification.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ipvsadm - 1:1.25.clean-1ubuntu0.1

---------------
ipvsadm (1:1.25.clean-1ubuntu0.1) lucid-proposed; urgency=low

  * libipvs/libipvs.c: upstream patch (r64) to fix incorrect activeconns,
    (Debian bug 574587), (LP: #663564)
 -- Clint Byrum <email address hidden> Mon, 22 Nov 2010 15:13:04 -0800

Changed in ipvsadm (Ubuntu Lucid):
status: Fix Committed → Fix Released
tags: added: testcase
Changed in ipvsadm (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.