Activity log for bug #1830033

Date Who What changed Old value New value Message
2019-05-22 12:45:10 Andrii bug added bug
2019-05-23 10:39:44 Paride Legovini tags ipvs ipvsadm lvs ipvs ipvsadm lvs server-next
2019-05-23 10:42:20 Paride Legovini nominated for series Ubuntu Eoan
2019-05-23 10:42:20 Paride Legovini bug task added ipvsadm (Ubuntu Eoan)
2019-05-23 10:42:20 Paride Legovini nominated for series Ubuntu Cosmic
2019-05-23 10:42:20 Paride Legovini bug task added ipvsadm (Ubuntu Cosmic)
2019-05-23 10:42:20 Paride Legovini nominated for series Ubuntu Xenial
2019-05-23 10:42:20 Paride Legovini bug task added ipvsadm (Ubuntu Xenial)
2019-05-23 10:42:20 Paride Legovini nominated for series Ubuntu Bionic
2019-05-23 10:42:20 Paride Legovini bug task added ipvsadm (Ubuntu Bionic)
2019-05-23 10:42:20 Paride Legovini nominated for series Ubuntu Disco
2019-05-23 10:42:20 Paride Legovini bug task added ipvsadm (Ubuntu Disco)
2019-05-23 10:42:36 Paride Legovini ipvsadm (Ubuntu Cosmic): status New Fix Released
2019-05-23 10:42:49 Paride Legovini bug task deleted ipvsadm (Ubuntu Disco)
2019-05-23 10:42:54 Paride Legovini bug task deleted ipvsadm (Ubuntu Eoan)
2019-05-23 10:43:16 Paride Legovini nominated for series Ubuntu Disco
2019-05-23 10:43:16 Paride Legovini bug task added ipvsadm (Ubuntu Disco)
2019-05-23 10:43:48 Paride Legovini bug task deleted ipvsadm (Ubuntu Disco)
2019-05-23 10:43:58 Paride Legovini ipvsadm (Ubuntu Xenial): status New Triaged
2019-05-23 10:44:02 Paride Legovini ipvsadm (Ubuntu): status New Triaged
2019-05-23 10:44:07 Paride Legovini ipvsadm (Ubuntu Bionic): status New Triaged
2019-05-23 10:45:21 Paride Legovini bug watch added https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808950
2019-05-23 10:45:21 Paride Legovini bug task added ipvsadm (Debian)
2019-05-23 12:02:53 Bug Watch Updater ipvsadm (Debian): status Unknown Fix Released
2019-05-24 07:35:44 Christian Ehrhardt  bug added subscriber Ubuntu Server
2019-05-24 07:47:20 Christian Ehrhardt  description The launch script for ipvsadm has a bug that prevents LVS from start in synchronization mode. How to reproduce. 1. Install ipvsadm on ubuntu server 16.04 and modify /etc/default/ipvsadm to lauch LVS in master mode (or backup): AUTO="true" DAEMON="master" IFACE="eno1" SYNCID="0" 2. Start "ipvsadm" service and check systemd unit log: # systemctl start ipvsadm # journalctl -u ipvsadm What you expected to happen The log output without error: May 22 12:41:46 xxxxxxxxxxx systemd[1]: Starting LSB: ipvsadm daemon... May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: * Clearing the current IPVS table... May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: ...done. May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: * Loading IPVS configuration... May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: ...done. May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: * Starting IPVS Connection Synchronization Daemon master May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: ...done. May 22 12:41:46 xxxxxxxxxxx systemd[1]: Started LSB: ipvsadm daemon. What happened instead: May 22 12:32:59 xxxxxxx systemd[1]: Starting LSB: ipvsadm daemon... May 22 12:32:59 xxxxxxx ipvsadm[15743]: * Clearing the current IPVS table... May 22 12:32:59 xxxxxxx ipvsadm[15743]: ...done. May 22 12:32:59 xxxxxxx ipvsadm[15743]: * Loading IPVS configuration... May 22 12:32:59 xxxxxxx ipvsadm[15743]: ...done. May 22 12:32:59 xxxxxxx ipvsadm[15743]: * Starting IPVS Connection Synchronization Daemon master May 22 12:32:59 xxxxxxx ipvsadm[15743]: Try `/sbin/ipvsadm -h' or '/sbin/ipvsadm --help' for more information. May 22 12:32:59 xxxxxxx ipvsadm[15743]: ...fail! May 22 12:32:59 xxxxxxx ipvsadm[15743]: ...done. May 22 12:32:59 xxxxxxx systemd[1]: Started LSB: ipvsadm daemon. As you can see in log output, there is an message: "Try `/sbin/ipvsadm -h' or '/sbin/ipvsadm --help' for more information". This message relates to bug in script /etc/init.d/ipvsadm. Here a difference how script should be updated to get it work: --- /etc/init.d/ipvsadm 2019-05-22 12:41:34.429916226 +0000 +++ /root/ipvsadm 2019-05-22 11:18:04.307344255 +0000 @@ -29,16 +29,16 @@ case $DAEMON in master|backup) log_daemon_msg "Starting IPVS Connection Synchronization Daemon" "$DAEMON" - $IPVSADM --start-daemon $DAEMON --mcast-interface \ + $IPVSADM --syncid $SYNCID --start-daemon $DAEMON --mcast-interface \ $IFACE --syncid $SYNCID || log_end_msg 1 log_end_msg 0 ;; both) log_daemon_msg "Starting IPVS Connection Synchronization Daemon" "master" - $IPVSADM --start-daemon master --mcast-interface \ + $IPVSADM --syncid $SYNCID --start-daemon master --mcast-interface \ $IFACE --syncid $SYNCID || FAILURE=1 log_progress_msg "backup" - $IPVSADM --start-daemon backup --mcast-interface \ + $IPVSADM --syncid $SYNCID --start-daemon backup --mcast-interface \ $IFACE --syncid $SYNCID || FAILURE=1 if [ "$FAILURE" -eq 1 ] then /root/ipvsadm - this is an original script from ipvsadm package # lsb_release -rd Description: Ubuntu 16.04.6 LTS Release: 16.04 # apt-cache policy ipvsadm ipvsadm: Installed: 1:1.28-3 Candidate: 1:1.28-3 Version table: *** 1:1.28-3 500 500 http://nl.archive.ubuntu.com/ubuntu xenial/main amd64 Packages 100 /var/lib/dpkg/status [Impact] * the init script has an argument twice, which makes the service fail to start * Without the fix the service is rather unusable as it can't be started [Test Case] * Needs a VM (no container) $ sudo apt install ipvsadm $ echo 'AUTO="true"' | sudo tee -a /etc/default/ipvsadm $ echo 'DAEMON="master"' | sudo tee -a /etc/default/ipvsadm $ sudo systemctl restart ipvsadm $ systemctl status ipvsadm With the bug this will show the sevrice failing [...] Try `/sbin/ipvsadm -h' or '/sbin/ipvsadm --help' for more information. ...fail! [Regression Potential] * Even in the default config (just enabling it to run) this doesn't work. Hence the risk should be next to none. I can think of setups that "are meant to work" , but so far "didn't start" now properly would start. For example if someone configured the service but ignored that it failed to start. I hope and expect that this is a rather unimportant risk, it actually is the fix we are intending to make. [Other Info] * TBH it is in main for a dependency from keepalive but I wonder how much that could be a sugegsts instead. But that is for the future. --- The launch script for ipvsadm has a bug that prevents LVS from start in synchronization mode. How to reproduce. 1. Install ipvsadm on ubuntu server 16.04 and modify /etc/default/ipvsadm to lauch LVS in master mode (or backup): AUTO="true" DAEMON="master" IFACE="eno1" SYNCID="0" 2. Start "ipvsadm" service and check systemd unit log: # systemctl start ipvsadm # journalctl -u ipvsadm What you expected to happen The log output without error: May 22 12:41:46 xxxxxxxxxxx systemd[1]: Starting LSB: ipvsadm daemon... May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: * Clearing the current IPVS table... May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: ...done. May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: * Loading IPVS configuration... May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: ...done. May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: * Starting IPVS Connection Synchronization Daemon master May 22 12:41:46 xxxxxxxxxxx ipvsadm[4619]: ...done. May 22 12:41:46 xxxxxxxxxxx systemd[1]: Started LSB: ipvsadm daemon. What happened instead: May 22 12:32:59 xxxxxxx systemd[1]: Starting LSB: ipvsadm daemon... May 22 12:32:59 xxxxxxx ipvsadm[15743]: * Clearing the current IPVS table... May 22 12:32:59 xxxxxxx ipvsadm[15743]: ...done. May 22 12:32:59 xxxxxxx ipvsadm[15743]: * Loading IPVS configuration... May 22 12:32:59 xxxxxxx ipvsadm[15743]: ...done. May 22 12:32:59 xxxxxxx ipvsadm[15743]: * Starting IPVS Connection Synchronization Daemon master May 22 12:32:59 xxxxxxx ipvsadm[15743]: Try `/sbin/ipvsadm -h' or '/sbin/ipvsadm --help' for more information. May 22 12:32:59 xxxxxxx ipvsadm[15743]: ...fail! May 22 12:32:59 xxxxxxx ipvsadm[15743]: ...done. May 22 12:32:59 xxxxxxx systemd[1]: Started LSB: ipvsadm daemon. As you can see in log output, there is an message: "Try `/sbin/ipvsadm -h' or '/sbin/ipvsadm --help' for more information". This message relates to bug in script /etc/init.d/ipvsadm. Here a difference how script should be updated to get it work: --- /etc/init.d/ipvsadm 2019-05-22 12:41:34.429916226 +0000 +++ /root/ipvsadm 2019-05-22 11:18:04.307344255 +0000 @@ -29,16 +29,16 @@      case $DAEMON in   master|backup)       log_daemon_msg "Starting IPVS Connection Synchronization Daemon" "$DAEMON" - $IPVSADM --start-daemon $DAEMON --mcast-interface \ + $IPVSADM --syncid $SYNCID --start-daemon $DAEMON --mcast-interface \          $IFACE --syncid $SYNCID || log_end_msg 1       log_end_msg 0       ;;   both)       log_daemon_msg "Starting IPVS Connection Synchronization Daemon" "master" - $IPVSADM --start-daemon master --mcast-interface \ + $IPVSADM --syncid $SYNCID --start-daemon master --mcast-interface \          $IFACE --syncid $SYNCID || FAILURE=1       log_progress_msg "backup" - $IPVSADM --start-daemon backup --mcast-interface \ + $IPVSADM --syncid $SYNCID --start-daemon backup --mcast-interface \          $IFACE --syncid $SYNCID || FAILURE=1       if [ "$FAILURE" -eq 1 ]       then /root/ipvsadm - this is an original script from ipvsadm package # lsb_release -rd Description: Ubuntu 16.04.6 LTS Release: 16.04 # apt-cache policy ipvsadm ipvsadm:   Installed: 1:1.28-3   Candidate: 1:1.28-3   Version table:  *** 1:1.28-3 500         500 http://nl.archive.ubuntu.com/ubuntu xenial/main amd64 Packages         100 /var/lib/dpkg/status
2019-05-24 08:01:36 Launchpad Janitor merge proposal linked https://code.launchpad.net/~paelzer/ubuntu/+source/ipvsadm/+git/ipvsadm/+merge/367890
2019-05-24 08:01:58 Launchpad Janitor merge proposal linked https://code.launchpad.net/~paelzer/ubuntu/+source/ipvsadm/+git/ipvsadm/+merge/367891
2019-05-24 08:05:05 Christian Ehrhardt  bug added subscriber Christian Ehrhardt 
2019-05-24 08:06:20 Christian Ehrhardt  ipvsadm (Ubuntu): status Triaged Fix Released
2019-05-28 18:16:50 Brian Murray ipvsadm (Ubuntu Bionic): status Triaged Fix Committed
2019-05-28 18:16:53 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2019-05-28 18:16:54 Brian Murray bug added subscriber SRU Verification
2019-05-28 18:16:58 Brian Murray tags ipvs ipvsadm lvs server-next ipvs ipvsadm lvs server-next verification-needed verification-needed-bionic
2019-05-28 18:18:39 Brian Murray ipvsadm (Ubuntu Xenial): status Triaged Fix Committed
2019-05-28 18:18:45 Brian Murray tags ipvs ipvsadm lvs server-next verification-needed verification-needed-bionic ipvs ipvsadm lvs server-next verification-needed verification-needed-bionic verification-needed-xenial
2019-05-29 06:04:31 Christian Ehrhardt  tags ipvs ipvsadm lvs server-next verification-needed verification-needed-bionic verification-needed-xenial ipvs ipvsadm lvs server-next verification-done verification-done-bionic verification-done-xenial
2019-06-04 23:14:05 Launchpad Janitor ipvsadm (Ubuntu Bionic): status Fix Committed Fix Released
2019-06-04 23:14:12 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2019-06-04 23:15:28 Launchpad Janitor ipvsadm (Ubuntu Xenial): status Fix Committed Fix Released