iptables-netflow-dkms FTBS on jammy with the latest linux 6.8 hwe kernel

[Andrea Righi]

[Impact]

/var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:4090:17: error: implicit declaration of function ‘strlcpy’; did you mean ‘strscpy’? [-Werror=implicit-function-declaration]
 4090 | strlcpy(info.driver, dev->dev.parent->driver->name, sizeof(info.driver));
      | ^~~~~~~
      | strscpy
cc1: some warnings being treated as errors

[Test case]

install both GA and HWE kernels, and

 $ sudo apt install iptables-netflow-dkms

then check that the build for both kernels succeeds

[Fix]

Backport from Noble the changes to properly support the new linux 6.8 kernel ABI.

[Regression potential]

We may experience networking-related regressions in systems that are using the iptables-netflow-dkms module.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: iptables-netflow-dkms 2.6-2ubuntu3
ProcVersionSignature: User Name 6.8.0-35.35.1~22.04.1-lowlatency 6.8.4
Uname: Linux 6.8.0-35-lowlatency x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Fri Jun 28 16:54:31 2024
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: iptables-netflow
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

Test on 6.8 hwe kernel:

ipt_NETFLOW.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

Test on 5.15 GA kernel:

ipt_NETFLOW.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted iptables-netflow into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/iptables-netflow/2.6-2ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Paolo Pisati (p-pisati)]

$ dkms status
ipt-netflow/2.6, 5.15.0-116-generic, x86_64: installed
ipt-netflow/2.6, 6.8.0-38-generic, x86_64: installed

GA:
$ lsmod | grep ipt
ipt_NETFLOW 98304 0

HWE:
$ lsmod | grep ipt
ipt_NETFLOW 102400 0

build, install and load fine on GA and HWE kernels.

[Launchpad Janitor (janitor)]

This bug was fixed in the package iptables-netflow - 2.6-2ubuntu4

---------------
iptables-netflow (2.6-2ubuntu4) jammy; urgency=medium

  Support linux 6.8 (LP: #2071491):
    - debian/patches/0020-linux-6.8-abi.patch

 -- Andrea Righi <email address hidden> Fri, 05 Jul 2024 08:33:16 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for iptables-netflow has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.