"examples/cbq.init-v0.7.3" script is not in Ubuntu style

Bug #1376979 reported by Kenji Kikuchi on 2014-10-03
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
iproute (Ubuntu)
Undecided
Unassigned

Bug Description

Hello, I noticed three observations in the "cbq.init-v0.7.3" script:
(1) Instead of using the Redhat style '/etc/sysconfig" directory for bandwidth settings it is better to use the existing "/etc/default" directory. Currently it makes us create the new '/etc/sysconfig" directory and the new directory contains only this script.
(2) There is no LSB style init stanza required in the Ubuntu system startup.
(3) It specifies the "-maxdepth" option for "find" command after the "-name" option. It prevents full execution of the script.

If the ”cbq.init-v0.7.3" script follows Ubuntu style it will really simplify our operations.

Kenji Kikuchi (kenji-kikuchi) wrote :

Can you please review and accept the attached changes.

The attachment "cbq-init.patch.gz" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Kenji Kikuchi (kenji-kikuchi) wrote :

Hello,
I attached the patch style file to explain my requests clearly.
Can you explain why should I remove the patch tag?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers