Error when re-building package from source

Bug #2061324 reported by Hector CAO
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
intel-gpu-tools (Ubuntu)
Invalid
Undecided
Hector CAO
Jammy
Fix Committed
Undecided
Hector CAO

Bug Description

[ Impact ]

 Impossible to build the package from source on Ubuntu 22.04, users will get
 this error:

```
int main(void) {
            void *a = (void*) &memfd_create;
            long long b = (long long) a;
            return (int) b;
        }
Compiler stdout:

Compiler stderr:

Checking for function "memfd_create" : YES
Configuring config.h using configuration

../lib/meson.build:155:4: ERROR: Function does not take positional arguments.
dh_auto_configure: error: cd build && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu -Dtests=disabled returned exit code 1
make[1]: *** [debian/rules:19: override_dh_auto_configure] Error 255
make[1]: Leaving directory '/home/ubuntu/hector/intel-gpu-tools-1.26'
make: *** [debian/rules:39: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

```

 The problem comes from the bad call to meson function underscorify in
 lib/meson.build

 This problem has been fixed upstream:

 963917a3565466832a3b2fc22e9285d34a0bf944
 lib/meson.build: Fix underscorify call
 f.underscorify() is correct, f.underscorify(f) is an error that later
 meson versions don't like at all.

 The proposed fix for Ubuntu consists of backporting this patch.

[ Test Plan ]

 Build the package from source on Ubuntu 22.04

 The build command is : dpkg-buildpackage -us -uc -b
 Ubuntu release : Jammy 22.04
 Meson version : 0.61.2

[ Where problems could occur ]

 The problem occurs only at build process

[ Other Info ]

 This issue only happens at build and has been fixed upstream.
 It is safe to have it in SRU

Revision history for this message
Hector CAO (hectorcao) wrote :

This problem has been fixed upstream:

963917a3565466832a3b2fc22e9285d34a0bf944

lib/meson.build: Fix underscorify call
f.underscorify() is correct, f.underscorify(f) is an error that later
meson versions don't like at all.

Closes: #107
Fixes: 588555f7

See : https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/963917a3565466832a3b2fc22e9285d34a0bf944

I propose to backport this patch

Changed in intel-gpu-tools (Ubuntu):
status: New → In Progress
assignee: nobody → Hector CAO (hectorcao)
Revision history for this message
Hector CAO (hectorcao) wrote :

The package with proposed fixed for Jammy can be found at:

https://launchpad.net/~hectorcao/+archive/ubuntu/lp2061324

Revision history for this message
Hector CAO (hectorcao) wrote :

here is the debdiff of the fix

Hector CAO (hectorcao)
description: updated
Revision history for this message
Hector CAO (hectorcao) wrote :

build fix is usually not accepted in SRU, this fix will be part of https://bugs.launchpad.net/ubuntu/+source/intel-gpu-tools/+bug/1949314

Changed in intel-gpu-tools (Ubuntu Jammy):
status: New → In Progress
assignee: nobody → Hector CAO (hectorcao)
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Hector, or anyone else affected,

Accepted intel-gpu-tools into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/intel-gpu-tools/1.26-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in intel-gpu-tools (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Robie Basak (racb) wrote :

This should be Fix Released for the development release, right?

Revision history for this message
Hector CAO (hectorcao) wrote :

Right, thanks @racb, this issue does not affect the development release, I put it to Invalid

Changed in intel-gpu-tools (Ubuntu):
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.