Fix build for Poppler 22.12 transition

[Nathan Teodosio]

Inkscape won't build with Poppler >=22.09 because of calls such as

    state->getLineDash(&dash_pattern, &dash_length, &dash_start);

Poppler's getLineDash API changed.

The attached patch fixes the compilation, nonetheless the package to build (https://launchpad.net/~nteodosio/+archive/ubuntu/poppler/+build/24938248) because of a failed Pango test:

--->
304/307 Test #304: render_text-glyphs-combining ........................................***Failed 1.14 sec
Failed to get connection
** (inkscape:19505): CRITICAL **: 18:49:52.468: dbus_g_proxy_new_for_name: assertion 'connection != NULL' failed

** (inkscape:19505): CRITICAL **: 18:49:52.468: dbus_g_proxy_call: assertion 'DBUS_IS_G_PROXY (proxy)' failed

** (inkscape:19505): CRITICAL **: 18:49:52.468: dbus_g_connection_register_g_object: assertion 'connection != NULL' failed
end_font_face_cb: font face rule limited support.
  font-family : 'Noto Sans';
  src : url(fonts/NotoSans-Regular.ttf)
end_font_face_cb: Added font: /<<PKGBUILDDIR>>/testfiles/rendering_tests/fonts/NotoSans-Regular.ttf
Background RRGGBBAA: ffffff00
Area 0:0:600:600 exported to 600 x 600 pixels (96 dpi)
2
text-glyphs-combining FAILED
Failed to get connection
** (inkscape:19519): CRITICAL **: 18:49:52.688: dbus_g_proxy_new_for_name: assertion 'connection != NULL' failed

** (inkscape:19519): CRITICAL **: 18:49:52.688: dbus_g_proxy_call: assertion 'DBUS_IS_G_PROXY (proxy)' failed

** (inkscape:19519): CRITICAL **: 18:49:52.688: dbus_g_connection_register_g_object: assertion 'connection != NULL' failed
end_font_face_cb: font face rule limited support.
  font-family : 'Noto Sans';
  src : url(fonts/NotoSans-Regular.ttf)
end_font_face_cb: Added font: /<<PKGBUILDDIR>>/testfiles/rendering_tests/fonts/NotoSans-Regular.ttf
Background RRGGBBAA: ffffff00
Area 0:0:600:600 exported to 2400 x 2400 pixels (384 dpi)
text-glyphs-combining-large FAILED
<---

[Nathan Teodosio (nteodosio)]

When I executed the tests locally, they succeeded.

        Start 304: render_text-glyphs-combining
304/307 Test #304: render_text-glyphs-combining ........................................ Passed 1.26 sec

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "fix-build-for-poppler-22-09.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Jeremy Bícha (jbicha)]

That test fails for me in my lunar sbuild also.

If your local environment is Kinetic, one big change is that Lunar includes a much newer harfbuzz than Kinetic.

[Nathan Teodosio (nteodosio)]

Yes, that's right, I'm on Kinetic.

[Jeremy Bícha (jbicha)]

I've uploaded your patch along with some patches from Debian to skip the failing tests.

I've unsubscribed ubuntu-sponsors; please feel free to resubscribe if you have something else that needs to be sponsored.

https://launchpad.net/ubuntu/+source/inkscape/1.1.2-3ubuntu6

[Jeremy Bícha (jbicha)]

Closing issue that was fixed a long time ago