breaks with labels containing slashes

Bug #347685 reported by Colin Watson on 2009-03-24
2
Affects Status Importance Assigned to Milestone
initramfs-tools (Ubuntu)
High
Colin Watson
Jaunty
High
Colin Watson

Bug Description

Binary package hint: initramfs-tools

Maximilian Attems pointed out these patches applied in Debian to fix booting with LABEL=/ and similar. Since we now use LABEL= by default if filesystem labels are set, we should apply these.

  http://git.debian.org/?p=kernel/initramfs-tools.git;a=commit;h=70ff74f8b3d378d7153f9211bbe0e73713a87259
  http://git.debian.org/?p=kernel/initramfs-tools.git;a=commit;h=9e5ff69508479c10548e0fcf4d6f3ee043cff1fe

Colin Watson (cjwatson) on 2009-03-24
Changed in initramfs-tools (Ubuntu Jaunty):
importance: Undecided → High
status: New → Triaged

See discussion on IRC this morning - we should _NOT_ use LABEL by default, even if set on the filesystem.

Arguably this escaping is OTT and we should just use "findfs" instead

Changed in initramfs-tools (Ubuntu Jaunty):
assignee: nobody → cjwatson
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package initramfs-tools - 0.92bubuntu27

---------------
initramfs-tools (0.92bubuntu27) jaunty; urgency=low

  * Backport from Debian (LP: #347685):
    - init: Fix boot with LABEL containing one or several '/'. Thanks to
      Andres Salomon <email address hidden> for testing. (closes: #489008)
    - scripts/local-premount/resume: Fix resume with LABEL containing '/'.

 -- Colin Watson <email address hidden> Fri, 03 Apr 2009 02:04:34 +0100

Changed in initramfs-tools (Ubuntu Jaunty):
status: Triaged → Fix Released
Colin Watson (cjwatson) wrote :

Label-by-default: bug 347817 (fixed). Sorry for forgetting about the relevant constraints. I think we should fix this anyway, though.

findfs isn't currently in the initramfs, and I lean strongly towards a simple backport versus writing our own, particularly as this isn't a case we care lots about. The code from Debian ends up being effectively rather simpler than it looks, since we always have sed in our initramfs.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers