Ubuntu
indicator-transfer package

No mechanism for displaying internal downloads in transfer indicator

Bug #1481673 reported by Michael Sheldon on 2015-08-05

This bug affects 3 people

	Status	Importance	Assigned to	Milestone
Canonical System Image	Fix Released	High	Bill Filler	Canonical System Image ww46-2015 "ota8"
indicator-transfer (Ubuntu)	Fix Released	High	Renato Araujo Oliveira Filho
indicator-transfer (Ubuntu RTM)	Fix Released	Undecided	Unassigned
ubuntu-download-manager (Ubuntu)	Fix Released	High	Manuel de la Peña

Bug Description

We're currently adding support to the webbrowser-app to allow it download files internally in addition to sending them to other applications, currently download manager has a metadata property titled "showInIndicator", however this doesn't appear to have any effect when the transfer is happening inside an application without content-hub involvement.

This results in an inconsistent experience for the user, as some downloads from the browser show up in the indicator (those opened immediately with other apps) and some don't (those downloaded for later use).

Related branches

lp:~mandel/ubuntu-download-manager/vivid-add-appid-metadata

Merged into lp:ubuntu-download-manager/vivid at revision 339

Alfonso Sanchez-Beato (community): Approve on 2015-09-17

Diff: 3238 lines (+1069/-303)

72 files modified

CMakeLists.txt (+2/-2)
debian/changelog (+19/-0)
debian/control (+24/-24)
debian/libubuntu-download-manager-client1.install (+1/-1)
debian/libubuntu-download-manager-client1.symbols (+18/-1)
debian/libubuntu-download-manager-common1.install (+1/-1)
debian/libubuntu-download-manager-common1.symbols (+1/-1)
debian/libubuntu-upload-manager-common1.install (+1/-1)
debian/libubuntu-upload-manager-common1.symbols (+1/-1)
debian/libudm-common-dev.install (+1/-0)
debian/libudm-common1.install (+1/-1)
debian/libudm-common1.symbols (+33/-17)
debian/libudm-priv-common1.install (+1/-1)
docs/dbus/com.canonical.applications.download.xml (+7/-0)
docs/dbus/com.canonical.applications.testing.download_manager.xml (+7/-0)
src/common/public/CMakeLists.txt (+2/-0)
src/common/public/ubuntu/transfers/errors/auth_error_struct.cpp (+6/-5)
src/common/public/ubuntu/transfers/errors/auth_error_struct.h (+9/-12)
src/common/public/ubuntu/transfers/errors/hash_error_struct.cpp (+96/-0)
src/common/public/ubuntu/transfers/errors/hash_error_struct.h (+122/-0)
src/common/public/ubuntu/transfers/errors/http_error_struct.cpp (+2/-2)
src/common/public/ubuntu/transfers/errors/http_error_struct.h (+3/-5)
src/common/public/ubuntu/transfers/errors/network_error_struct.cpp (+2/-2)
src/common/public/ubuntu/transfers/errors/network_error_struct.h (+3/-6)
src/common/public/ubuntu/transfers/errors/process_error_struct.cpp (+7/-7)
src/common/public/ubuntu/transfers/errors/process_error_struct.h (+8/-11)
src/common/public/ubuntu/transfers/metadata.cpp (+33/-0)
src/common/public/ubuntu/transfers/metadata.h (+6/-4)
src/downloads/client/symbols.map (+6/-0)
src/downloads/client/ubuntu/download_manager/download.h (+18/-4)
src/downloads/client/ubuntu/download_manager/download_impl.cpp (+19/-1)
src/downloads/client/ubuntu/download_manager/download_impl.h (+4/-4)
src/downloads/client/ubuntu/download_manager/download_interface.cpp (+1/-1)
src/downloads/client/ubuntu/download_manager/download_interface.h (+23/-18)
src/downloads/client/ubuntu/download_manager/error.cpp (+88/-22)
src/downloads/client/ubuntu/download_manager/error.h (+71/-6)
src/downloads/client/ubuntu/download_manager/manager_impl.cpp (+3/-1)
src/downloads/common/ubuntu/download_manager/metatypes.h (+4/-4)
src/downloads/priv/ubuntu/downloads/download.h (+14/-3)
src/downloads/priv/ubuntu/downloads/download_adaptor.cpp (+7/-1)
src/downloads/priv/ubuntu/downloads/download_adaptor.h (+12/-3)
src/downloads/priv/ubuntu/downloads/file_download.cpp (+2/-1)
src/downloads/priv/ubuntu/downloads/file_download.h (+2/-1)
src/downloads/priv/ubuntu/downloads/manager.cpp (+20/-0)
src/downloads/priv/ubuntu/downloads/manager.h (+2/-4)
src/downloads/test-daemon/testing_daemon.cpp (+12/-1)
src/downloads/test-daemon/testing_daemon.h (+3/-4)
src/downloads/test-daemon/testing_file_download.cpp (+17/-1)
src/downloads/test-daemon/testing_file_download.h (+5/-4)
src/downloads/test-daemon/testing_interface.cpp (+1/-1)
src/downloads/test-daemon/testing_interface.h (+8/-1)
src/downloads/test-daemon/testing_manager.cpp (+12/-3)
src/downloads/test-daemon/testing_manager.h (+3/-4)
src/downloads/test-daemon/testing_manager_adaptor.cpp (+9/-1)
src/downloads/test-daemon/testing_manager_adaptor.h (+7/-1)
src/downloads/test-daemon/ubuntu-download-manager-test-daemon.pro.THIS (+0/-44)
tests/common/daemon_testcase.cpp (+26/-3)
tests/common/daemon_testcase.h (+3/-4)
tests/common/testing_interface.cpp (+1/-1)
tests/common/testing_interface.h (+8/-1)
tests/downloads/client/CMakeLists.txt (+7/-6)
tests/downloads/client/test_client_download.cpp (+37/-1)
tests/downloads/client/test_client_download.h (+4/-4)
tests/downloads/client/test_client_manager.cpp (+1/-1)
tests/downloads/client/test_group_manager_watch.h (+3/-5)
tests/downloads/daemon/CMakeLists.txt (+2/-1)
tests/downloads/daemon/test_download.cpp (+3/-1)
tests/downloads/daemon/test_download_manager.cpp (+54/-0)
tests/downloads/daemon/test_final_state.cpp (+0/-4)
tests/downloads/daemon/test_metadata.cpp (+90/-0)
tests/downloads/daemon/test_metadata.h (+10/-3)
tests/downloads/qml/CMakeLists.txt (+30/-24)

lp:~mandel/ubuntu-download-manager/wily-add-appid-metadata

Merged into lp:ubuntu-download-manager at revision 341

Alfonso Sanchez-Beato: Approve on 2015-09-17

PS Jenkins bot: Approve (continuous-integration) on 2015-09-03

Renato Araujo Oliveira Filho (community): Needs Fixing on 2015-08-31

lp:~renatofilho/indicator-transfer/app-id-dm

Merged into lp:indicator-transfer/15.10 at revision 38

Charles Kerr (community): Approve on 2015-09-25

PS Jenkins bot (community): Approve (continuous-integration) on 2015-09-25

Revision history for this message

Charles Kerr (charlesk) wrote on 2015-08-05:

This dovetails with work that Renato and I started last week to show other non-download-manager transfers. The use case we're already looking at is calendar syncing.

It's a work in progress, but the relevant branches are at

https://code.launchpad.net/~charlesk/indicator-transfer/add-plugins

and

https://code.launchpad.net/~renatofilho/indicator-transfer-buteo/initial-version/+merge/266949

Revision history for this message

Michael Sheldon (michael-sheldon) wrote on 2015-08-05:

In the browser case however this is actually a DownloadManager based transfer, it just isn't using content-hub to send it to another application. Presumably it should be possible to expose DownloadManager based downloads without requiring apps to write additional plugins?

Revision history for this message

Bill Filler (bfiller) wrote on 2015-08-25:

I confirmed this is still an issue, even with silo 24 installed

Changed in indicator-transfer (Ubuntu):
assignee:	nobody → Charles Kerr (charlesk)
Changed in canonical-devices-system-image:
milestone:	none → ww40-2015
Changed in indicator-transfer (Ubuntu):
importance:	Undecided → High
status:	New → Confirmed

Manuel de la Peña (mandel) on 2015-08-25

Changed in ubuntu-download-manager (Ubuntu):
status:	New → Confirmed
importance:	Undecided → High
assignee:	nobody → Manuel de la Peña (mandel)

Manuel de la Peña (mandel) on 2015-08-27

Changed in ubuntu-download-manager (Ubuntu):
status:	Confirmed → In Progress

Pat McGowan (pat-mcgowan) on 2015-08-31

Changed in canonical-devices-system-image:
assignee:	nobody → John McAleely (john.mcaleely)
importance:	Undecided → High
status:	New → In Progress

Bill Filler (bfiller) on 2015-09-23

Changed in indicator-transfer (Ubuntu):
assignee:	Charles Kerr (charlesk) → Renato Araujo Oliveira Filho (renatofilho)
Changed in canonical-devices-system-image:
assignee:	John McAleely (john.mcaleely) → Bill Filler (bfiller)

Pat McGowan (pat-mcgowan) on 2015-10-07

Changed in canonical-devices-system-image:
milestone:	ww40-2015 → ww46-2015

Bill Filler (bfiller) on 2015-10-19

Changed in canonical-devices-system-image:
status:	In Progress → Fix Committed

Pat McGowan (pat-mcgowan) on 2015-10-19

Changed in canonical-devices-system-image:
status:	Fix Committed → Fix Released

Revision history for this message

Timo Jyrinki (timo-jyrinki) wrote on 2015-12-22:

indicator-transfer (0.2+15.04.20151216.5-0ubuntu1) vivid; urgency=medium

  [ Renato Araujo Oliveira Filho ]
  * Only allow resume paused downloads.
  * Removed content hub dep from download manager plugin. (LP: #1481673,
    #1488547, #1514109)

-- CI Train Bot <email address hidden> Wed, 16 Dec 2015 19:32:43 +0000

Changed in indicator-transfer (Ubuntu RTM):
status:	New → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-12-22:

This bug was fixed in the package indicator-transfer - 0.2+16.04.20151216.5-0ubuntu1

---------------
indicator-transfer (0.2+16.04.20151216.5-0ubuntu1) xenial; urgency=medium

  [ Renato Araujo Oliveira Filho ]
  * Only allow resume paused downloads.
  * Removed content hub dep from download manager plugin. (LP: #1481673,
    #1488547, #1514109)

-- CI Train Bot <email address hidden> Wed, 16 Dec 2015 19:32:43 +0000

Changed in indicator-transfer (Ubuntu):
status:	Confirmed → Fix Released

Michael Sheldon (michael-sheldon) on 2016-09-20

Changed in ubuntu-download-manager (Ubuntu):
status:	In Progress → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntuindicator-transfer package

No mechanism for displaying internal downloads in transfer indicator

Bug Description

Related branches

Other bug subscribers

Remote bug watches

Ubuntu
indicator-transfer package