Playback controls don't highlight anything like other menu items

[Matthew Paul Thomas]

indicator-sound 0.7.9-0ubuntu2.1, Ubuntu 11.10

The way the playback items (Previous, Play/Pause, Next) highlight when focused is very different from the way other menu items are highlighted when focused.

Specifically, the button icons currently get a blurred ring around them in the highlight color.

Instead, the whole button should be filled with the highlight color, like it would if it was a menu item; and the icon should turn white, or whatever color is used for highlighted menu item text.

[Originally reported as part of <https://blueprints.launchpad.net/ubuntu/+spec/ps-p-indicator-refinements>.]

[Bilal Akhtar (bilalakhtar)]

Incomplete for now, please change status when a mockup is available.

[Conor Curran (cjcurran)]

It is very similar to lp:524541 but I can't see how that branch fixes this bug on the playback controls.

[Charles Kerr (charlesk)]

Conor: yes, you're right. Thanks for the correction

[Lars Karlitski (larsu)]

I implemented Matthew's design on how the playback menu item should be highlighted recently (see bug #733285).

[Matthew Paul Thomas (mpt)]

Bug 733285 was about *when* the items are highlighted, and thank you for fixing it. This bug is about *how* they are highlighted, i.e. what they look like.

[Xavi Garcia (xavi-garcia-mena)]

As the MPRIS controls seem to be OK in the sound indicator and Mathew's comment points to a cosmetic issue I'm assigning this to unity and moving it as Invalid for the indicator-sound.

Please feel free to re-open for indicator-sound if you think this is still a valid bug for indicator-sound.

[Michał Sawicz (saviq)]

This is about unity, not unity8, I've nothing to do with the former :)

[Xavi Garcia (xavi-garcia-mena)]

Confirmed it's not an indicator issue, the issue is very old and the icons seem to be fixed now.