the indicator stopped turning red on restart required

Bug #942104 reported by Sebastien Bacher on 2012-02-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Aptdaemon
Undecided
Unassigned
Session Menu
Fix Released
High
Conor Curran
indicator-session (Ubuntu)
High
Conor Curran

Bug Description

Using precise beta1 (but that started since the indicator got ported to the packagekit api) the indicator doesn't turn red when restart is required

Changed in indicator-session (Ubuntu):
importance: Undecided → High
Changed in indicator-session:
importance: Undecided → High
Changed in indicator-session (Ubuntu):
assignee: nobody → Conor Curran (cjcurran)
Conor Curran (cjcurran) on 2012-03-05
Changed in indicator-session:
assignee: nobody → Conor Curran (cjcurran)
status: New → Triaged
Conor Curran (cjcurran) wrote :

Looks like the signal has changed name. On the package kit interface it is now called 'RestartSchedule' instead of 'RestartShceduled'.
Will get confirmation in the morning and push a fix this week.

Conor Curran (cjcurran) on 2012-03-05
Changed in indicator-session:
status: Triaged → In Progress
Conor Curran (cjcurran) wrote :

Just tested with dbus-monitor and the session service running from terminal.
The update-manager shows that a restart is required but the trace from either process shows nothing.

below is the trace from the dbus-monitor:

 dbus-monitor --system "type='signal',sender='org.freedesktop.PackageKit',interface='org.freedesktop.PackageKit'"
signal sender=org.freedesktop.DBus -> dest=:1.102 serial=2 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameAcquired
   string ":1.102"
signal sender=:1.100 -> dest=(null destination) serial=127 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=TransactionListChanged
   array [
   ]
signal sender=:1.100 -> dest=(null destination) serial=1539 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=TransactionListChanged
   array [
   ]
signal sender=:1.100 -> dest=(null destination) serial=1548 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=UpdatesChanged
signal sender=:1.100 -> dest=(null destination) serial=1565 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=TransactionListChanged
   array [
      string "/3f30a6dd91674d5ca7df10bc03ae4fda"
   ]
signal sender=:1.100 -> dest=(null destination) serial=1870 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=TransactionListChanged
   array [
   ]
signal sender=:1.114 -> dest=(null destination) serial=29 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=Changed
signal sender=:1.114 -> dest=(null destination) serial=48 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=TransactionListChanged
   array [
   ]
signal sender=:1.114 -> dest=(null destination) serial=3483 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=TransactionListChanged
   array [
   ]
signal sender=:1.114 -> dest=(null destination) serial=3491 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=UpdatesChanged
signal sender=:1.114 -> dest=(null destination) serial=3508 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=TransactionListChanged
   array [
      string "/da20bf5db6e0428f890248a00c54c334"
   ]
signal sender=:1.114 -> dest=(null destination) serial=3555 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=TransactionListChanged
   array [
   ]
signal sender=:1.121 -> dest=(null destination) serial=20 path=/org/freedesktop/PackageKit; interface=org.freedesktop.PackageKit; member=Changed

Changed in indicator-session:
status: In Progress → Invalid
Conor Curran (cjcurran) on 2012-03-06
Changed in indicator-session (Ubuntu):
status: New → Invalid
Changed in indicator-session (Ubuntu):
status: Invalid → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-session - 0.3.92-0ubuntu2

---------------
indicator-session (0.3.92-0ubuntu2) precise; urgency=low

  * Backport r243 and r244, should fix the restart required status update
    once aptdaemon is fixed to correctly emit signals (lp: #942104)
  * debian/patches/restore_session_lock.patch, debian/rules:
    - replace by a backport of the official commit
 -- Sebastien Bacher <email address hidden> Tue, 06 Mar 2012 16:06:57 +0100

Changed in indicator-session (Ubuntu):
status: Fix Committed → Fix Released

I already located the bug in aptdaemon. I will pushes the corresponding fix and a test case this evening.
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

Sebastian Heinlein (glatzor) wrote :

There is a miunderstanding of the packagekit api. You need to watch the restartrequired signal on the transaction interface instead. The currently used restartschedule signal is used to indicate the client that a later version of the daemon has been installed as the currently running one.
In packagekit upstream the signal is only emitted during an upgrade transaction (e.g. in the yum backend code).
But aptdaemon will also emit the signal during a get updates call. Hopefully the code on the aptdaemon side will land today or tomorrow.
The packagekit api allows to send different types: application, session and system. At the moment only system restart will be supported.
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

Conor Curran (cjcurran) on 2012-03-08
Changed in indicator-session:
status: Invalid → Fix Released
Conor Curran (cjcurran) on 2012-03-08
Changed in indicator-session:
status: Fix Released → In Progress
Conor Curran (cjcurran) wrote :

ah ok,
On which interface does the transaction interface exist (apt or pkkit), can see a transaction interface at the moment which has that signal.

Does this mean I need to monitor any new transaction kicked off and listen for restart signals.
Obviously many new transactions are kicked off all the time, monitoring all of these is not ideal.
Honestly from my simple usecase this is cumbersome.

Michael Vogt (mvo) wrote :

I pushed a branch that should work once the changes that glatzor mentioned land:
 lp:~mvo/indicator-session/restart-required/

Michael Vogt (mvo) wrote :

@glatzor: if you outline what needs to be done in the pkcompat code I can try to help you with that. if of course you did the work already, well :) even better!

Sebastian Heinlein (glatzor) wrote :

I already wrote the missing pieces in aptdaemon, but I have to wait a little bit before I can push since I am currently on the ride.
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

Changed in indicator-session (Ubuntu):
status: Fix Released → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-session - 0.3.92-0ubuntu3

---------------
indicator-session (0.3.92-0ubuntu3) precise; urgency=low

  * Backport mvo's restart required fix, with the new aptdaemon that
    should fix the issue for good (lp: #942104)
 -- Sebastien Bacher <email address hidden> Fri, 09 Mar 2012 13:39:43 +0100

Changed in indicator-session (Ubuntu):
status: Fix Committed → Fix Released
Sebastien Bacher (seb128) wrote :

Ok, I've tested the new aptdaemon and the patch from mvo, combined they fix the issue \o/ I've backported the patch to precise, Conor you might want to merge it to trunk as well ;-)

Sebastian Heinlein (glatzor) wrote :

You could also use PkControl in indicator-session to get the updates-changed signal.
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

Conor Curran (cjcurran) wrote :

will do Seb, Michael & Sebastian thanks a million. The thought of having to deal with transactions again was making me anxious.

Changed in indicator-session:
status: In Progress → Fix Committed
Ted Gould (ted) on 2012-03-22
Changed in indicator-session:
status: Fix Committed → Fix Released
Changed in aptdaemon:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers