| 2014-08-31 10:37:54 |
Dmitry Shachnev |
bug |
|
|
added bug |
| 2014-08-31 10:38:20 |
Dmitry Shachnev |
tags |
|
utopic |
|
| 2014-08-31 10:38:32 |
Dmitry Shachnev |
bug task added |
|
ubuntu-flashback |
|
| 2014-08-31 10:38:40 |
Dmitry Shachnev |
ubuntu-flashback: importance |
Undecided |
High |
|
| 2014-08-31 10:40:09 |
Launchpad Janitor |
branch linked |
|
lp:~mitya57/indicator-session/lp1363630 |
|
| 2014-09-19 14:36:27 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/utopic-proposed/indicator-session |
|
| 2014-09-19 15:08:27 |
Launchpad Janitor |
indicator-session (Ubuntu): status |
In Progress |
Fix Released |
|
| 2014-09-26 11:48:51 |
Dmitry Shachnev |
ubuntu-gnome-flashback: status |
New |
Fix Released |
|
| 2015-02-25 10:11:10 |
Dmitry Shachnev |
nominated for series |
|
Ubuntu Trusty |
|
| 2015-02-25 10:11:10 |
Dmitry Shachnev |
bug task added |
|
indicator-session (Ubuntu Trusty) |
|
| 2015-02-26 00:05:49 |
Thomas Mayer |
bug |
|
|
added subscriber Thomas Mayer |
| 2015-02-26 00:05:53 |
Launchpad Janitor |
indicator-session (Ubuntu Trusty): status |
New |
Confirmed |
|
| 2015-03-04 19:18:30 |
Frédéric Danis |
bug |
|
|
added subscriber Frédéric Danis |
| 2015-03-11 09:17:03 |
Dmitry Shachnev |
indicator-session (Ubuntu Trusty): importance |
Undecided |
High |
|
| 2015-03-11 09:17:03 |
Dmitry Shachnev |
indicator-session (Ubuntu Trusty): status |
Confirmed |
In Progress |
|
| 2015-03-11 09:17:03 |
Dmitry Shachnev |
indicator-session (Ubuntu Trusty): assignee |
|
Dmitry Shachnev (mitya57) |
|
| 2015-03-18 11:32:32 |
Dmitry Shachnev |
description |
Currently the code in zenity_question() looks like:
if (!g_spawn_check_exit_status (exit_status, &error))
confirmed = TRUE;
else
confirmed = exit_status == 0;
However !g_spawn_check_exit_status() call is mostly equivalent to "exit_status != 0". Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog.
I have prepared a branch to fix this. |
Currently the code in zenity_question() looks like:
if (!g_spawn_check_exit_status (exit_status, &error))
confirmed = TRUE;
else
confirmed = exit_status == 0;
However !g_spawn_check_exit_status() call is mostly equivalent to "exit_status != 0". Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog.
I have prepared a branch to fix this.
== Impact ==
The Cancel buttons in shutdown/end session dialogs are not working, and do the same as "OK" buttons. This may lead to data loss due to unsaved documents/etc.
== Test Case ==
* Log in to GNOME Flashback session.
* Select "Shutdown" from indicator-session menu.
* In the popped up dialog select "Cancel".
Expected result: the dialog will close, the machine won't shut down.
== Development / Stable Fix ==
Please see the attached branches.
== Regression Potential ==
The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. |
|
| 2015-03-18 11:34:39 |
Launchpad Janitor |
branch linked |
|
lp:~mitya57/indicator-session/lp1363630_trusty |
|
| 2015-03-30 21:27:58 |
Erick Brunzell |
bug |
|
|
added subscriber Erick Brunzell |
| 2015-04-08 08:49:45 |
Adam Conrad |
indicator-session (Ubuntu Trusty): status |
In Progress |
Fix Committed |
|
| 2015-04-08 08:49:47 |
Adam Conrad |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2015-04-08 08:49:49 |
Adam Conrad |
bug |
|
|
added subscriber SRU Verification |
| 2015-04-08 08:49:54 |
Adam Conrad |
tags |
utopic |
utopic verification-needed |
|
| 2015-04-08 08:57:39 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/trusty-proposed/indicator-session |
|
| 2015-04-09 22:26:15 |
Alberts Muktupāvels |
tags |
utopic verification-needed |
utopic verification-done |
|
| 2015-04-16 00:14:05 |
Eric Detheridge |
bug |
|
|
added subscriber Eric Detheridge |
| 2015-04-16 16:44:08 |
Launchpad Janitor |
indicator-session (Ubuntu Trusty): status |
Fix Committed |
Fix Released |
|
| 2015-04-16 16:44:27 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
