Hotspot not working with NM 1.2
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Critical
|
Tony Espy | ||
indicator-network (Ubuntu) |
Fix Released
|
Critical
|
Pete Woods |
Bug Description
While testing network-manager 1.1.93-
The first issue was that if no NM connection file yet existed for the hotspot, indicator-network would fail creating one due to a DBus error:
void nmofono:
Failed to add connection: "ipv4.dns: can't set property of type 'au' from value of type 'as'"
This was due to indicator-network using the following code to set this setting:
ipv4[QStringLit
My guess is that NM's re-factoring of it's DBus code to use gdbus instead of dbus-glib, resulting in NM being a bit more strict in it's parameter checking.
Removing this, and the same for the 'addresses' and 'routes' settings allows indicator-network to create hotspot connection files once again.
See the associated branch for the update.
If a connection file already exists, or one is created with the fix from the merge proposal, then the current problem is that when 'Start' is pressed, the UI displays a spinner which is never dismissed.
Testing has shown that the hotspot is actually activated, can be seen from other devices and connected to.
Testing has also shown that it's possible to activate the hotspot using nmcli directly, and the result is usable from other clients.
Related branches
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Pete Woods (community): Approve
-
Diff: 14 lines (+0/-3)1 file modifiedsrc/indicator/nmofono/hotspot-manager.cpp (+0/-3)
- Indicator Applet Developers: Pending requested
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 15 lines (+5/-0)1 file modifiedsrc/indicator/nmofono/hotspot-manager.cpp (+5/-0)
Changed in indicator-network (Ubuntu): | |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
status: | Confirmed → In Progress |
Changed in indicator-network (Ubuntu): | |
importance: | Undecided → Critical |
Changed in indicator-network (Ubuntu): | |
assignee: | nobody → Alfonso Sanchez-Beato (alfonsosanchezbeato) |
Changed in indicator-network (Ubuntu): | |
assignee: | Alfonso Sanchez-Beato (alfonsosanchezbeato) → Pete Woods (pete-woods) |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in indicator-network (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Also should note that a version of indicator-network with the settings fix for hotspot can be found in the following CI ticket / silo:
https:/ /requests. ci-train. ubuntu. com/#/ticket/ 1338 /launchpad. net/~ci- train-ppa- service/ +archive/ ubuntu/ landing- 019
https:/