[indicators] [network] No Validation of Wi-Fi Key/Passphrases is performed

Bug #1091391 reported by Tony Espy on 2012-12-17
This bug affects 2 people
Affects Status Importance Assigned to Milestone
indicator-network (Ubuntu)

Bug Description

The current network indicator does no checking of Wi-Fi key or passphrases, and thus allows a user to enter an invalid key or passphrase and initiate a connection attempt.

For access points using WEP, there are four valid key lengths:

 * 5 ASCII characters or 10 hex characters
 * 13 ASCII characters or 26 hex characters

<https://wiki.ubuntu.com/Networking#wi-fi-authentication-variations>: "“Connect Anyway” should be insensitive whenever the “Password:” field does not contain 5 or 10 Ascii characters, or 13 or 26 hexadecimal characters. The error color should be used to highlight any non-Ascii characters regardless of length, and any non-hexadecimal characters whenever there are 12 or more characters (such that you’re more likely to be aiming for 13 or 26 than for 5 or 10)."

For APs using WPA Personal/PSK, a valid passphrase can be between 8 and 63 characters in length. A full 256-bit key can be specified by entering 64 hex characters.

<https://wiki.ubuntu.com/Networking#wi-fi-authentication-variations>: "“Connect” should be insensitive whenever the “Password:” field contains fewer than 8 characters, more than 64 characters, or exactly 64 characters where any of them are not hexadecimal. Whenever there are exactly 64 characters, any non-hexadecimal characters should be highlighted in the error color."

Note, the chewie server should also probably do some validation as well. It shouldn't be possible for a new network to be created with a single character key ( see attached file ).

Steps to Reproduce:

1. Open the network menu and select an access point known to be using WEP security
2. Enter a 1 character key
3. Click OK

Expected Result:

The user cannot initiate a connection with an invalid key.

Actual Result:

The auth dialog is dismissed and the user appears connected ( note, this is another problem )

Build Details:

Manhattan/Maguro #160

chewie: 0.2.6~quantal1
indicators-client-plugin-network: 0.20~quantal1

Tony Espy (awe) wrote :

Here's the newly created NetworkManager system-connections file, which has an invalid 1-character WEP key.

Changed in manhattan:
status: New → Confirmed
Tony Espy (awe) on 2013-01-30
summary: - [network-indicator] No Validation of Wi-Fi Key/Passphrases is performed
+ [indicators] [network] No Validation of Wi-Fi Key/Passphrases is
+ performed
Bill Filler (bfiller) on 2013-02-03
Changed in manhattan:
assignee: nobody → Alberto Ruiz (alberto.ruiz)
milestone: none → update-1
importance: Undecided → Medium
Bill Filler (bfiller) on 2013-03-01
Changed in manhattan:
milestone: update-1 → update-2
Tony Espy (awe) on 2013-07-08
tags: added: wifi
Changed in manhattan:
assignee: Alberto Ruiz (alberto.ruiz) → nobody
Tony Espy (awe) on 2013-07-08
Changed in manhattan:
milestone: ubuntu-13.04-month-5 → none
information type: Proprietary → Public
affects: manhattan → touch-preview-images

Triaging -- I'm assigning this tentatively to Ted, who normally looks after indicator-network (and opening the bug against indicator-network).

Changed in indicator-network (Ubuntu):
importance: Undecided → Medium
Changed in touch-preview-images:
status: Confirmed → Triaged
Changed in indicator-network (Ubuntu):
status: New → Triaged
assignee: nobody → Ted Gould (ted)
Changed in touch-preview-images:
assignee: nobody → Mathieu Trudel-Lapierre (mathieu-tl)
Ted Gould (ted) wrote :

This is blocked on the dialog support in Unity8 getting landed.

Changed in indicator-network (Ubuntu):
assignee: Ted Gould (ted) → Pete Woods (pete-woods)
status: Triaged → In Progress
assignee: Pete Woods (pete-woods) → Ted Gould (ted)
Ted Gould (ted) wrote :

This will require the enhanced system dialog support that should be coming in Unity 8 in the 14.04 timeframe.

Changed in indicator-network (Ubuntu):
status: In Progress → Triaged
assignee: Ted Gould (ted) → nobody
Changed in indicator-network:
status: New → Triaged
importance: Undecided → Medium
Changed in indicator-network (Ubuntu):
assignee: nobody → Matthew Paul Thomas (mpt)
Changed in indicator-network (Ubuntu):
assignee: Matthew Paul Thomas (mpt) → Antti Kaijanmäki (kaijanmaki)
Changed in touch-preview-images:
assignee: Mathieu Trudel-Lapierre (mathieu-tl) → Antti Kaijanmäki (kaijanmaki)
Changed in indicator-network:
assignee: nobody → Antti Kaijanmäki (kaijanmaki)
Bill Filler (bfiller) on 2014-07-01
no longer affects: touch-preview-images
Pete Woods (pete-woods) on 2015-03-26
no longer affects: indicator-network
Antti Kaijanmäki (kaijanmaki) wrote :

No design for this item.

Changed in indicator-network (Ubuntu):
status: Triaged → Incomplete
importance: Medium → Wishlist
assignee: Antti Kaijanmäki (kaijanmaki) → nobody
Changed in ubuntu-ux:
status: New → Triaged
assignee: nobody → Paty Davila (dizzypaty)
Changed in indicator-network (Ubuntu):
status: Incomplete → Triaged
Matthew Paul Thomas (mpt) wrote :

There is design for this item, and has been since April 2014.

no longer affects: ubuntu-ux
description: updated
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers