indicators should use 'com.canonical.indicators.link' type for Settings links
Bug #1642989 reported by
Charles Kerr
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| indicator-bluetooth (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
| indicator-datetime (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
| indicator-location (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
| indicator-network (Ubuntu) |
Triaged
|
Medium
|
Unassigned | ||
| indicator-power (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
| indicator-session (Ubuntu) |
Triaged
|
Medium
|
Unassigned | ||
| indicator-sound (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
Bug Description
http://
> if (modelData.action !== undefined && modelData.
> // FIXME : At the moment, the indicators aren't using
> // com.canonical.
> return linkMenu;
> }
We should set the type of settings menuitems to 'com.canonical.
Related branches
lp:~pete-woods/indicator-network/use-correct-settings-item-lp1642989
- dobey (community): Needs Fixing
- unity-api-1-bot: Approve (continuous-integration)
-
Diff: 403 lines (+52/-98)8 files modifiedsrc/indicator/CMakeLists.txt (+1/-1)
src/indicator/menuitems/settings-item.cpp (+23/-13)
src/indicator/menuitems/settings-item.h (+16/-20)
src/indicator/menuitems/wifi-link-item.cpp (+0/-13)
src/indicator/sections/ethernet-section.cpp (+3/-3)
src/indicator/sections/vpn-section.cpp (+3/-17)
src/indicator/sections/wifi-section.cpp (+3/-14)
src/indicator/sections/wwan-section.cpp (+3/-17)
| Changed in indicator-network (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
To post a comment you must log in.
