incorrect use of 'summary' event property in popup notifications
Bug #1622682 reported by
Charles Kerr
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| indicator-datetime (Ubuntu) |
In Progress
|
Medium
|
Charles Kerr | ||
Bug Description
As described in RFC 2445:
> When the action is "DISPLAY", the alarm MUST also include a "DESCRIPTION" property, which contains the text to be displayed when the alarm is triggered.
The ingest code in engine-eds.cpp is correctly reading the `description' property to initialize the Alarm struct's 'text' field, but then when it comes time to display the alarm, it uses Appointment.summary instead.
This appears to be a code leftover from the time before indicator-datetime added multiple valarm support by separating the Alarm and Appointment structures.
Related branches
lp:~charlesk/indicator-datetime/lp-1622682-use-valarm-description-property-in-popups
- unity-api-1-bot: Approve (continuous-integration)
- dobey (community): Approve
-
Diff: 43 lines (+4/-4)2 files modifiedsrc/snap.cpp (+2/-2)
tests/test-notification.cpp (+2/-2)
| Changed in indicator-datetime (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Charles Kerr (charlesk) |
| importance: | Undecided → Medium |
| summary: |
- should use vevent 'description' property in notifications + incorrect use of 'summary' event property in popup notifications |
To post a comment you must log in.
